Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/973405/?format=api
{ "id": 973405, "url": "http://patchwork.ozlabs.org/api/patches/973405/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180921193907.4864-1-natechancellor@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180921193907.4864-1-natechancellor@gmail.com>", "list_archive_url": null, "date": "2018-09-21T19:39:07", "name": "i40e: Remove unnecessary print statement", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "664f1658ef5bda885cc1086a961fbe54d34d13f5", "submitter": { "id": 73753, "url": "http://patchwork.ozlabs.org/api/people/73753/?format=api", "name": "Nathan Chancellor", "email": "natechancellor@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180921193907.4864-1-natechancellor@gmail.com/mbox/", "series": [ { "id": 66974, "url": "http://patchwork.ozlabs.org/api/series/66974/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=66974", "date": "2018-09-21T19:39:07", "name": "i40e: Remove unnecessary print statement", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/66974/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/973405/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/973405/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mt/VztWv\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42H3np4cwyz9s3C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 22 Sep 2018 05:39:26 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1BEE487086;\n\tFri, 21 Sep 2018 19:39:25 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id emrtzpCNc7Jt; Fri, 21 Sep 2018 19:39:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BB47987015;\n\tFri, 21 Sep 2018 19:39:22 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id B897D1C20D8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 19:39:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B524787FB9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 19:39:21 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JTa4HzHc0SGR for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 19:39:20 +0000 (UTC)", "from mail-wm1-f66.google.com (mail-wm1-f66.google.com\n\t[209.85.128.66])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 340A087F9F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 19:39:20 +0000 (UTC)", "by mail-wm1-f66.google.com with SMTP id y139-v6so4138145wmc.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 12:39:20 -0700 (PDT)", "from localhost.localdomain ([2a01:4f8:10b:24a5::2])\n\tby smtp.gmail.com with ESMTPSA id\n\tz13sm29773086wrw.19.2018.09.21.12.39.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 21 Sep 2018 12:39:17 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=FAhlPDumkMGXgOo2/rsfaCLRaM0SPVtVgtCJunyOUig=;\n\tb=mt/VztWv3zuy2fDlsKYNJY5nMcr+8usKbyq/7DssLfPa/00bUA+oD/4Ias7FWRQRb8\n\tOTo2PkJoa45KCIKMJl9lBPNjQkphVpRVavPngIWH726XMsE4hRuzQEiG707I+RLn2z61\n\tqYD8E816DJ+B2fYuPlJJ5v07BZ4Od3hNJWcB7uQVJIFGG0qEtYk9UCGiNAuR7ORWf0zR\n\trwVZTmuH/Osufad7CyWMCmvTLrfk2Jf19YFKQD0pu7miAYncOtaGcmsQkN5Fc2becNZ4\n\tnsiFmL8vXSbuDP4Rk34uDbRnX4MZAn4AM5wVmsihW/+Ql0W2SkLgSOSrBVtlwcUwC7qy\n\thOjw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=FAhlPDumkMGXgOo2/rsfaCLRaM0SPVtVgtCJunyOUig=;\n\tb=AR55y3JGKjNv7AJF01aJOiz5p5A0KUljPhZQQis9C8w6NC/bn81F9K6Ekx61ofGX7s\n\tJM/vuylU1eiQv2Vki2FE3FV/m1xt2jjMJgfacW23+uxmAiqZnxAN3DjxQKsUHc18tHdf\n\tAjRzCIm48OoWPqfC+zfr2+/Yy+VBLfrtJsUJc8LQe/bSd2voOhOImCFzC+AL7yx1Oqxs\n\t1gzsujm9kyfLlg5cPOSzwFeUt2GSyu8nMix13lNSkoXPFeB8K64cylGxnx0inHGniQBw\n\tu4YWY00wG57mR56P2/hn44pddXdJjdCWUKdFBSAdDYB7Z2TkgSXVLtlqjbWdqV2KibHW\n\tV4sg==", "X-Gm-Message-State": "APzg51Ch1qJDajZD728XiKEvh6tQHQnT/cxwniFg7KGJ/XLyyLYtr1tD\n\t4kznWPtdoDbMAB5t7cce18o=", "X-Google-Smtp-Source": "ANB0VdY9xcr/X4q07H4Pg0q/hcQOKkM7hImoQYV13+RRJJN/zDCka1H4gr7HGusfKkmW2vOnHGYrig==", "X-Received": "by 2002:a1c:b984:: with SMTP id\n\tj126-v6mr8481409wmf.25.1537558758140; \n\tFri, 21 Sep 2018 12:39:18 -0700 (PDT)", "From": "Nathan Chancellor <natechancellor@gmail.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S. Miller\" <davem@davemloft.net>", "Date": "Fri, 21 Sep 2018 12:39:07 -0700", "Message-Id": "<20180921193907.4864-1-natechancellor@gmail.com>", "X-Mailer": "git-send-email 2.19.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] i40e: Remove unnecessary print statement", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Nathan Chancellor <natechancellor@gmail.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Clang warns that the address of a pointer will always evaluated as true\nin a boolean context.\n\ndrivers/net/ethernet/intel/i40e/i40e_debugfs.c:136:9: warning: address\nof array 'vsi->active_vlans' will always evaluate to 'true'\n[-Wpointer-bool-conversion]\n vsi->active_vlans ? \"<valid>\" : \"<null>\");\n ~~~~~^~~~~~~~~~~~ ~\n./include/linux/device.h:1431:33: note: expanded from macro 'dev_info'\n _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)\n ^~~~~~~~~~~\n1 warning generated.\n\nGiven that the statement shows that active_vlans is always valid, just\nremove the statement since it's not giving any useful information.\n\nLink: https://github.com/ClangBuiltLinux/linux/issues/82\nSigned-off-by: Nathan Chancellor <natechancellor@gmail.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 56b911a5dd8b..a20d1cf058ad 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -132,8 +132,6 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)\n \t\tdev_info(&pf->pdev->dev, \" vlan_features = 0x%08lx\\n\",\n \t\t\t (unsigned long int)nd->vlan_features);\n \t}\n-\tdev_info(&pf->pdev->dev, \" active_vlans is %s\\n\",\n-\t\t vsi->active_vlans ? \"<valid>\" : \"<null>\");\n \tdev_info(&pf->pdev->dev,\n \t\t \" flags = 0x%08lx, netdev_registered = %i, current_netdev_flags = 0x%04x\\n\",\n \t\t vsi->flags, vsi->netdev_registered, vsi->current_netdev_flags);\n", "prefixes": [] }