Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/973323/?format=api
{ "id": 973323, "url": "http://patchwork.ozlabs.org/api/patches/973323/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180921101359.23911-1-natechancellor@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180921101359.23911-1-natechancellor@gmail.com>", "list_archive_url": null, "date": "2018-09-21T10:13:59", "name": "i40e: Use proper enum in i40e_ndo_set_vf_link_state", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a1c00d2ee341a1a10ba82d1fd32f2f768a93dc84", "submitter": { "id": 73753, "url": "http://patchwork.ozlabs.org/api/people/73753/?format=api", "name": "Nathan Chancellor", "email": "natechancellor@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180921101359.23911-1-natechancellor@gmail.com/mbox/", "series": [ { "id": 66949, "url": "http://patchwork.ozlabs.org/api/series/66949/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=66949", "date": "2018-09-21T10:13:59", "name": "i40e: Use proper enum in i40e_ndo_set_vf_link_state", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/66949/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/973323/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/973323/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aFOSd7yK\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42H06947tNz9sCc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 22 Sep 2018 02:53:20 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3A38288531;\n\tFri, 21 Sep 2018 16:53:19 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LWv2Kt7BpQwb; Fri, 21 Sep 2018 16:53:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 75F1088E72;\n\tFri, 21 Sep 2018 16:53:17 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 490B51C07E1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 10:14:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 45215842B5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 10:14:12 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3xariJxEipwk for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 10:14:11 +0000 (UTC)", "from mail-wm1-f65.google.com (mail-wm1-f65.google.com\n\t[209.85.128.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id EBDA684580\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 10:14:10 +0000 (UTC)", "by mail-wm1-f65.google.com with SMTP id c14-v6so2455883wmb.4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 21 Sep 2018 03:14:10 -0700 (PDT)", "from localhost.localdomain ([2a01:4f8:10b:24a5::2])\n\tby smtp.gmail.com with ESMTPSA id\n\tw94-v6sm20016715wrc.38.2018.09.21.03.14.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 21 Sep 2018 03:14:08 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=twlh7GbhGfcC9UTvG9ggOQuu123y4BtnylUREQZ/5O0=;\n\tb=aFOSd7yK6kAXNflKr57Kkn90yqyZx8IB6wS1Kjzby2qZ/JSX6+leF63QYpIieR00ma\n\t1j0yuoIHtmerRL0+A1FnXsdHVwHelRxxtx1D98OiFCF8RiU5ul/YwX7T5m8NjAMSlLpK\n\tuatMYx6DD3lXociFLctUVZ5GUhebhnZmDmBjRoQPSnfZr7Z89Ir1QFQ2hEN4FEpJnpv5\n\tKKeyaHPaLY7fWITMKvejfFmBNsgqP2FY5L1LsvzYw1JBlOzWkYCWuiPVN4XITE8Cz1OR\n\tVXkPSlid/cCkpTBHNfqRV9zqOFo3IT0oUJD4s/xo3WoyVWGX2j59fjFHDPSBYogXgbji\n\t996g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=twlh7GbhGfcC9UTvG9ggOQuu123y4BtnylUREQZ/5O0=;\n\tb=dcJ3j+tVj5o2vwmjP8CEIIZMZsOtiPol2oWUSjqQ48vAqGgoNZ8gwSXKG9ixOkwfAB\n\tLg8cnKUlWnwNUiISODNS7djLHq87PszNToVfnyuzJ5wJaikKL7j8QZYde3TCe21GjJJJ\n\t5XGUu08TEpODV2hSm/abbcqDxWvAF7WiSjXHMCG6SxhlMXsos8F4EqW12x13pCIr8At7\n\tp//Q0B6yT2MYUjd0jGYSpgy1EXcRG0BtyFrWMI3+G3ok3IwOueSVklvWCC6YRh6gpG7a\n\tOhzuaua2oRLPreBCqpgqh5YPKr5VGLJR1mBy7yOwbEPXYS4C4mxTMBRloJxsMCSuLrmE\n\teiFg==", "X-Gm-Message-State": "APzg51CtEWLdFZfT/cZsCFqBUTmb+xZho0FCc5XOfqpLmh+udJZWf2OP\n\tlOo70DD1tuNV8TT5T6Ug6OA=", "X-Google-Smtp-Source": "ANB0VdYyZdwSRU0VsjiFkvZ8IJWcGuKkEQE64dT9JQ3zz/4KI+QWSDQYQyuFLVolJZVcn6we4s1tHQ==", "X-Received": "by 2002:a1c:f60c:: with SMTP id\n\tw12-v6mr6789499wmc.80.1537524848953; \n\tFri, 21 Sep 2018 03:14:08 -0700 (PDT)", "From": "Nathan Chancellor <natechancellor@gmail.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S. Miller\" <davem@davemloft.net>", "Date": "Fri, 21 Sep 2018 03:13:59 -0700", "Message-Id": "<20180921101359.23911-1-natechancellor@gmail.com>", "X-Mailer": "git-send-email 2.19.0", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Fri, 21 Sep 2018 16:53:16 +0000", "Subject": "[Intel-wired-lan] [PATCH] i40e: Use proper enum in\n\ti40e_ndo_set_vf_link_state", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Nathan Chancellor <natechancellor@gmail.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Clang warns when one enumerated type is converted implicitly to another.\n\ndrivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:4214:42: warning:\nimplicit conversion from enumeration type 'enum i40e_aq_link_speed' to\ndifferent enumeration type 'enum virtchnl_link_speed'\n [-Wenum-conversion]\n pfe.event_data.link_event.link_speed = I40E_LINK_SPEED_40GB;\n ~ ^~~~~~~~~~~~~~~~~~~~\n1 warning generated.\n\nUse the proper enum from virtchnl_link_speed, which has the same value\nas I40E_LINK_SPEED_40GB, VIRTCHNL_LINK_SPEED_40GB. This appears to be\nmissed by commit ff3f4cc267f6 (\"virtchnl: finish conversion to virtchnl\ninterface\").\n\nLink: https://github.com/ClangBuiltLinux/linux/issues/81\nSigned-off-by: Nathan Chancellor <natechancellor@gmail.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 3e707c7e6782..916a98e6c0e6 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -4211,7 +4211,7 @@ int i40e_ndo_set_vf_link_state(struct net_device *netdev, int vf_id, int link)\n \t\tvf->link_forced = true;\n \t\tvf->link_up = true;\n \t\tpfe.event_data.link_event.link_status = true;\n-\t\tpfe.event_data.link_event.link_speed = I40E_LINK_SPEED_40GB;\n+\t\tpfe.event_data.link_event.link_speed = VIRTCHNL_LINK_SPEED_40GB;\n \t\tbreak;\n \tcase IFLA_VF_LINK_STATE_DISABLE:\n \t\tvf->link_forced = true;\n", "prefixes": [] }