Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/972701/?format=api
{ "id": 972701, "url": "http://patchwork.ozlabs.org/api/patches/972701/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180920190113.490005-1-songliubraving@fb.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180920190113.490005-1-songliubraving@fb.com>", "list_archive_url": null, "date": "2018-09-20T19:01:13", "name": "[net] ixgbe: check return value of napi_complete_done()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4459a43483f1c67a46a90e36d5d1968b3d4c6a8d", "submitter": { "id": 72600, "url": "http://patchwork.ozlabs.org/api/people/72600/?format=api", "name": "Song Liu", "email": "songliubraving@fb.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180920190113.490005-1-songliubraving@fb.com/mbox/", "series": [ { "id": 66740, "url": "http://patchwork.ozlabs.org/api/series/66740/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=66740", "date": "2018-09-20T19:01:13", "name": "[net] ixgbe: check return value of napi_complete_done()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/66740/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/972701/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/972701/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=fb.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=fb.com header.i=@fb.com header.b=\"G0oz3Tiw\";\n\tdkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42GRwR3j33z9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 21 Sep 2018 05:43:02 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7A36187294;\n\tThu, 20 Sep 2018 19:43:01 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aCjL2wITi+Gw; Thu, 20 Sep 2018 19:42:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5D2308713E;\n\tThu, 20 Sep 2018 19:42:59 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id CE6381C24AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 19:03:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C8ADB309D1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 19:03:31 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VXC4gGeR4J2j for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 19:03:31 +0000 (UTC)", "from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com\n\t[67.231.153.30])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 9177822119\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 19:03:31 +0000 (UTC)", "from pps.filterd (m0109332.ppops.net [127.0.0.1])\n\tby mx0a-00082601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw8KIxQqT009197 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 12:03:30 -0700", "from mail.thefacebook.com ([199.201.64.23])\n\tby mx0a-00082601.pphosted.com with ESMTP id 2mmfge0m9t-5\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT)\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 12:03:30 -0700", "from mx-out.facebook.com (192.168.52.123) by mail.thefacebook.com\n\t(192.168.16.17) with Microsoft SMTP Server (TLS) id 14.3.361.1;\n\tThu, 20 Sep 2018 12:01:29 -0700", "by devbig006.ftw2.facebook.com (Postfix, from userid 4523)\tid\n\tE818962E10B7; Thu, 20 Sep 2018 12:01:24 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com;\n\th=from : to : cc : subject\n\t: date : message-id : mime-version : content-type; s=facebook;\n\tbh=A0u3oXLld/IludRyrl5yv+r5xgTPbwijHqghNxyJDQI=;\n\tb=G0oz3Tiw7xuiNX+WF9jbRsPB7Jaacioqc9Z8QqU5NljGnLKI9hRMMDmrgsropFpDN30L\n\tlHuExSyP1az+MUsPf2Zcv6tfJClwmWlz/1vgnr/XwVElasajoaB6730626fiSAyEKtrR\n\tq++iLPXAEcsLeK08fIQEcpUzG+sTCyW24X8= ", "Smtp-Origin-Hostprefix": "devbig", "From": "Song Liu <songliubraving@fb.com>", "Smtp-Origin-Hostname": "devbig006.ftw2.facebook.com", "To": "<netdev@vger.kernel.org>", "Smtp-Origin-Cluster": "ftw2c04", "Date": "Thu, 20 Sep 2018 12:01:13 -0700", "Message-ID": "<20180920190113.490005-1-songliubraving@fb.com>", "X-Mailer": "git-send-email 2.17.1", "X-FB-Internal": [ "Safe", "Safe" ], "MIME-Version": "1.0", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2018-09-20_11:, , signatures=0", "X-Proofpoint-Spam-Reason": "safe", "X-Mailman-Approved-At": "Thu, 20 Sep 2018 19:42:58 +0000", "Subject": "[Intel-wired-lan] [PATCH net] ixgbe: check return value of\n\tnapi_complete_done()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Song Liu <songliubraving@fb.com>, intel-wired-lan@lists.osuosl.org,\n\tkernel-team@fb.com, stable@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The NIC driver should only enable interrupts when napi_complete_done()\nreturns true. This patch adds the check for ixgbe.\n\nCc: stable@vger.kernel.org # 4.10+\nCc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nSuggested-by: Eric Dumazet <edumazet@google.com>\nSigned-off-by: Song Liu <songliubraving@fb.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 9a23d33a47ed..1497df6a8dff 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -3196,11 +3196,13 @@ int ixgbe_poll(struct napi_struct *napi, int budget)\n \t\treturn budget;\n \n \t/* all work done, exit the polling mode */\n-\tnapi_complete_done(napi, work_done);\n-\tif (adapter->rx_itr_setting & 1)\n-\t\tixgbe_set_itr(q_vector);\n-\tif (!test_bit(__IXGBE_DOWN, &adapter->state))\n-\t\tixgbe_irq_enable_queues(adapter, BIT_ULL(q_vector->v_idx));\n+\tif (likely(napi_complete_done(napi, work_done))) {\n+\t\tif (adapter->rx_itr_setting & 1)\n+\t\t\tixgbe_set_itr(q_vector);\n+\t\tif (!test_bit(__IXGBE_DOWN, &adapter->state))\n+\t\t\tixgbe_irq_enable_queues(adapter,\n+\t\t\t\t\t\tBIT_ULL(q_vector->v_idx));\n+\t}\n \n \treturn min(work_done, budget - 1);\n }\n", "prefixes": [ "net" ] }