Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/972026/?format=api
{ "id": 972026, "url": "http://patchwork.ozlabs.org/api/patches/972026/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180920002311.10891-2-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180920002311.10891-2-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-09-20T00:23:04", "name": "[1/8] ice: use [sr]q.count when checking if queue is initialized", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4bf7e13032ecc3376b488edbaf33049860f71160", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180920002311.10891-2-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 66524, "url": "http://patchwork.ozlabs.org/api/series/66524/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=66524", "date": "2018-09-20T00:23:03", "name": "Minor updates and bug fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/66524/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/972026/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/972026/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42FyBS5Wdqz9s9J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 20 Sep 2018 10:23:28 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 37887882A8;\n\tThu, 20 Sep 2018 00:23:27 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wEtf+L6OAXP0; Thu, 20 Sep 2018 00:23:25 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4AF44882CE;\n\tThu, 20 Sep 2018 00:23:25 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id C73411C08AF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 00:23:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C510E88209\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 00:23:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7PTFDAkQRIua for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 00:23:19 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id AA89087DA1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 20 Sep 2018 00:23:18 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Sep 2018 17:23:18 -0700", "from shasta.jf.intel.com ([10.166.241.11])\n\tby orsmga006.jf.intel.com with ESMTP; 19 Sep 2018 17:23:11 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,396,1531810800\"; d=\"scan'208\";a=\"75747547\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 19 Sep 2018 17:23:04 -0700", "Message-Id": "<20180920002311.10891-2-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20180920002311.10891-1-anirudh.venkataramanan@intel.com>", "References": "<20180920002311.10891-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 1/8] ice: use [sr]q.count when checking if\n\tqueue is initialized", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nWhen shutting down the controlqs, we check if they are initialized\nbefore we shut them down and destroy the lock. This is important, as it\nprevents attempts to access the lock of an already shutdown queue.\n\nUnfortunately, we checked rq.head and sq.head as the value to determine\nif the queue was initialized. This doesn't work, because head is not\nreset when the queue is shutdown. In some flows, the adminq will have\nalready been shut down prior to calling ice_shutdown_all_ctrlqs. This\ncan result in a crash due to attempting to access the already destroyed\nmutex.\n\nFix this by using rq.count and sq.count instead. Indeed, ice_shutdown_sq\nand ice_shutdown_rq already indicate that this is the value we should be\nusing to determine of the queue was initialized.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n[Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> cleaned up commit message]\n---\n drivers/net/ethernet/intel/ice/ice_controlq.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_controlq.c b/drivers/net/ethernet/intel/ice/ice_controlq.c\nindex 1fe026a65d75..3c736b90a6bf 100644\n--- a/drivers/net/ethernet/intel/ice/ice_controlq.c\n+++ b/drivers/net/ethernet/intel/ice/ice_controlq.c\n@@ -597,11 +597,11 @@ static enum ice_status ice_init_check_adminq(struct ice_hw *hw)\n \treturn 0;\n \n init_ctrlq_free_rq:\n-\tif (cq->rq.head) {\n+\tif (cq->rq.count) {\n \t\tice_shutdown_rq(hw, cq);\n \t\tmutex_destroy(&cq->rq_lock);\n \t}\n-\tif (cq->sq.head) {\n+\tif (cq->sq.count) {\n \t\tice_shutdown_sq(hw, cq);\n \t\tmutex_destroy(&cq->sq_lock);\n \t}\n@@ -710,11 +710,11 @@ static void ice_shutdown_ctrlq(struct ice_hw *hw, enum ice_ctl_q q_type)\n \t\treturn;\n \t}\n \n-\tif (cq->sq.head) {\n+\tif (cq->sq.count) {\n \t\tice_shutdown_sq(hw, cq);\n \t\tmutex_destroy(&cq->sq_lock);\n \t}\n-\tif (cq->rq.head) {\n+\tif (cq->rq.count) {\n \t\tice_shutdown_rq(hw, cq);\n \t\tmutex_destroy(&cq->rq_lock);\n \t}\n", "prefixes": [ "1/8" ] }