Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/966235/?format=api
{ "id": 966235, "url": "http://patchwork.ozlabs.org/api/patches/966235/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1536130851-34357-1-git-send-email-radoslawx.tyl@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1536130851-34357-1-git-send-email-radoslawx.tyl@intel.com>", "list_archive_url": null, "date": "2018-09-05T07:00:51", "name": "ixgbe: Fix ixgbe TX hangs with XDP_TX beyond queue limit.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "994b78cda20e97dbcf16c80e7c3d740ef5e22cdc", "submitter": { "id": 74872, "url": "http://patchwork.ozlabs.org/api/people/74872/?format=api", "name": "Radoslaw Tyl", "email": "radoslawx.tyl@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1536130851-34357-1-git-send-email-radoslawx.tyl@intel.com/mbox/", "series": [ { "id": 64163, "url": "http://patchwork.ozlabs.org/api/series/64163/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=64163", "date": "2018-09-05T07:00:51", "name": "ixgbe: Fix ixgbe TX hangs with XDP_TX beyond queue limit.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/64163/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/966235/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/966235/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 424vmt6dx7z9s1x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 5 Sep 2018 17:03:25 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9110323E65;\n\tWed, 5 Sep 2018 07:03:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iqOiA3e5qJzQ; Wed, 5 Sep 2018 07:03:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id C5356235AE;\n\tWed, 5 Sep 2018 07:03:21 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9DF0E1C0186\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Sep 2018 07:03:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9919588862\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Sep 2018 07:03:20 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UQEEVDRp5g7k for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Sep 2018 07:03:19 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 4B76D88763\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 5 Sep 2018 07:03:19 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2018 00:03:18 -0700", "from gklab-246-010.igk.intel.com (HELO s215.localdomain)\n\t([10.217.246.10])\n\tby orsmga007.jf.intel.com with ESMTP; 05 Sep 2018 00:03:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,332,1531810800\"; d=\"scan'208\";a=\"70453121\"", "From": "Radoslaw Tyl <radoslawx.tyl@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 5 Sep 2018 09:00:51 +0200", "Message-Id": "<1536130851-34357-1-git-send-email-radoslawx.tyl@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Fix ixgbe TX hangs with XDP_TX\n\tbeyond queue limit.", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Radoslaw Tyl <radoslawx.tyl@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We have Tx hang when number tx and xdp queues are more than 64.\nIn XDP always is MTQC == 0x0 (64TxQs). We need more space for Tx queues.\n\nSigned-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 604282f..e227549 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -3577,12 +3577,18 @@ static void ixgbe_setup_mtqc(struct ixgbe_adapter *adapter)\n \t\telse\n \t\t\tmtqc |= IXGBE_MTQC_64VF;\n \t} else {\n-\t\tif (tcs > 4)\n+\t\tif (tcs > 4) {\n \t\t\tmtqc = IXGBE_MTQC_RT_ENA | IXGBE_MTQC_8TC_8TQ;\n-\t\telse if (tcs > 1)\n+\t\t} else if (tcs > 1) {\n \t\t\tmtqc = IXGBE_MTQC_RT_ENA | IXGBE_MTQC_4TC_4TQ;\n-\t\telse\n-\t\t\tmtqc = IXGBE_MTQC_64Q_1PB;\n+\t\t} else {\n+\t\t\tu8 max_txq = adapter->num_tx_queues +\n+\t\t\t\tadapter->num_xdp_queues;\n+\t\t\tif (max_txq > 63)\n+\t\t\t\tmtqc = IXGBE_MTQC_RT_ENA | IXGBE_MTQC_4TC_4TQ;\n+\t\t\telse\n+\t\t\t\tmtqc = IXGBE_MTQC_64Q_1PB;\n+\t\t}\n \t}\n \n \tIXGBE_WRITE_REG(hw, IXGBE_MTQC, mtqc);\n", "prefixes": [] }