Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/966062/?format=api
{ "id": 966062, "url": "http://patchwork.ozlabs.org/api/patches/966062/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1536089609-32716-1-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1536089609-32716-1-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2018-09-04T19:33:29", "name": "[next-queue] ixgbevf: fix msglen for ipsec mbx messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dadf1e98821d58fe20a7277f6cb4df05efaae9e0", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1536089609-32716-1-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [ { "id": 64105, "url": "http://patchwork.ozlabs.org/api/series/64105/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=64105", "date": "2018-09-04T19:33:29", "name": "[next-queue] ixgbevf: fix msglen for ipsec mbx messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/64105/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/966062/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/966062/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"FlFHDSZJ\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 424cTL1wQFz9sB5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 5 Sep 2018 05:33:57 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 452CB26244;\n\tTue, 4 Sep 2018 19:33:56 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id j6FporwB0pYF; Tue, 4 Sep 2018 19:33:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5A09A25EA4;\n\tTue, 4 Sep 2018 19:33:55 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id B04531C002D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Sep 2018 19:33:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AB51D82614\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Sep 2018 19:33:54 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yHVNGyxQm1Rk for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Sep 2018 19:33:54 +0000 (UTC)", "from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 1192482431\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Sep 2018 19:33:54 +0000 (UTC)", "from pps.filterd (userp2120.oracle.com [127.0.0.1])\n\tby userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw84JSi9l119898; Tue, 4 Sep 2018 19:33:52 GMT", "from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])\n\tby userp2120.oracle.com with ESMTP id 2m7kdqf6da-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 04 Sep 2018 19:33:52 +0000", "from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w84JXobP021737\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 4 Sep 2018 19:33:51 GMT", "from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw84JXoFr013650; Tue, 4 Sep 2018 19:33:50 GMT", "from slnelson-mint18.us.oracle.com (/10.159.145.56)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Tue, 04 Sep 2018 19:33:50 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : cc :\n\tsubject : date : message-id; s=corp-2018-07-02;\n\tbh=jjFcg6dM8qrjEnPzdROy7WoW+ra2UX1S0kCACStrE1Q=;\n\tb=FlFHDSZJG0dL5TOgZkwvMH4Elg9xfaSXp9omNwbtDWt+m4g+Hj9aOJjzZL0dCWUGK+wj\n\tfhTWxb3uEqvNzp5lH3JWR3ZNdP3IKx30nfK0PKiuKFeO+sOVTJh54SsOZVXGcDE0IcQN\n\tyH5u2a5OECjq5DoiHYDnDELze/lLJisXK+AOHuUAVTDQ7xiJj+rz/28r6XdReMn3I6Pt\n\tk3q2EZk0YxT0cnMpA9jwF5HqkC/GoLsyTR0NUxHxL3XlmWwNQsZwBuO5UNut29C6lSUA\n\tuC7ru7Sz8JruVbvS5HRu+p3bMgY9jUFZgT88gwYUKyL8DtTbz01OBqJx+n/d6No8N3o8\n\tBA== ", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Tue, 4 Sep 2018 12:33:29 -0700", "Message-Id": "<1536089609-32716-1-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 2.7.4", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=9006\n\tsignatures=668708", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=0\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=900\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1807170000 definitions=main-1809040195", "Subject": "[Intel-wired-lan] [PATCH next-queue] ixgbevf: fix msglen for ipsec\n\tmbx messages", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "dan.carpenter@oracle.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Don't be fancy with message lengths, just set lengths to\nnumber of dwords, not bytes.\n\nFixes: 0062e7cc955e (\"ixgbevf: add VF IPsec offload code\")\nReported-by: Dan Carpenter <dan.carpenter@oracle.com>\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ipsec.c | 11 ++++-------\n 1 file changed, 4 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ipsec.c b/drivers/net/ethernet/intel/ixgbevf/ipsec.c\nindex fac91c0..a68586c 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ipsec.c\n@@ -21,7 +21,6 @@ static int ixgbevf_ipsec_set_pf_sa(struct ixgbevf_adapter *adapter,\n \tu32 msgbuf[IXGBE_VFMAILBOX_SIZE] = { 0 };\n \tstruct ixgbe_hw *hw = &adapter->hw;\n \tstruct sa_mbx_msg *sam;\n-\tu16 msglen;\n \tint ret;\n \n \t/* send the important bits to the PF */\n@@ -38,16 +37,14 @@ static int ixgbevf_ipsec_set_pf_sa(struct ixgbevf_adapter *adapter,\n \tmemcpy(sam->key, xs->aead->alg_key, sizeof(sam->key));\n \n \tmsgbuf[0] = IXGBE_VF_IPSEC_ADD;\n-\tmsglen = sizeof(*sam) + sizeof(msgbuf[0]);\n \n \tspin_lock_bh(&adapter->mbx_lock);\n \n-\tret = hw->mbx.ops.write_posted(hw, msgbuf, msglen);\n+\tret = hw->mbx.ops.write_posted(hw, msgbuf, IXGBE_VFMAILBOX_SIZE);\n \tif (ret)\n \t\tgoto out;\n \n-\tmsglen = sizeof(msgbuf[0]) * 2;\n-\tret = hw->mbx.ops.read_posted(hw, msgbuf, msglen);\n+\tret = hw->mbx.ops.read_posted(hw, msgbuf, 2);\n \tif (ret)\n \t\tgoto out;\n \n@@ -80,11 +77,11 @@ static int ixgbevf_ipsec_del_pf_sa(struct ixgbevf_adapter *adapter, int pfsa)\n \n \tspin_lock_bh(&adapter->mbx_lock);\n \n-\terr = hw->mbx.ops.write_posted(hw, msgbuf, sizeof(msgbuf));\n+\terr = hw->mbx.ops.write_posted(hw, msgbuf, 2);\n \tif (err)\n \t\tgoto out;\n \n-\terr = hw->mbx.ops.read_posted(hw, msgbuf, sizeof(msgbuf));\n+\terr = hw->mbx.ops.read_posted(hw, msgbuf, 2);\n \tif (err)\n \t\tgoto out;\n \n", "prefixes": [ "next-queue" ] }