Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/963038/?format=api
{ "id": 963038, "url": "http://patchwork.ozlabs.org/api/patches/963038/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180828171609.78242-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180828171609.78242-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-08-28T17:16:01", "name": "[next,S96,1/9] i40e: Check and correct speed values for link on open", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0f91dedc6a7aee45c88f1ccbb7ee2626eb814467", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180828171609.78242-1-alice.michael@intel.com/mbox/", "series": [ { "id": 62918, "url": "http://patchwork.ozlabs.org/api/series/62918/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=62918", "date": "2018-08-28T17:16:03", "name": "[next,S96,1/9] i40e: Check and correct speed values for link on open", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/62918/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/963038/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/963038/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 420Flr6pw7z9s2P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 29 Aug 2018 03:16:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1DE3686762;\n\tTue, 28 Aug 2018 17:16:23 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KqwYKehoqSyt; Tue, 28 Aug 2018 17:16:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D47B1866FD;\n\tTue, 28 Aug 2018 17:16:20 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id A964D1C2B65\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 Aug 2018 17:16:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A68298577F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 Aug 2018 17:16:19 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MQ4u7e9192me for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 Aug 2018 17:16:19 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 44A2C85762\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 Aug 2018 17:16:19 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Aug 2018 10:16:18 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 28 Aug 2018 10:16:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,300,1531810800\"; d=\"scan'208\";a=\"85666778\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 28 Aug 2018 10:16:01 -0700", "Message-Id": "<20180828171609.78242-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S96 1/9] i40e: Check and correct\n\tspeed values for link on open", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jan Sokolowski <jan.sokolowski@intel.com>\n\nIf our card has been put in an unstable state due to\nother drivers interacting with it, speed settings\nmight be incorrect. If incorrect, forcefully reset them\non open to known default values.\n\nSigned-off-by: Jan Sokolowski <jan.sokolowski@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 27 ++++++++++++++++++++++++---\n 1 file changed, 24 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 1718f2f..fd0c6c5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -6622,6 +6622,24 @@ static i40e_status i40e_force_link_state(struct i40e_pf *pf, bool is_up)\n \tstruct i40e_hw *hw = &pf->hw;\n \ti40e_status err;\n \tu64 mask;\n+\tu8 speed;\n+\n+\t/* Card might've been put in an unstable state by other drivers\n+\t * and applications, which causes incorrect speed values being\n+\t * set on startup. In order to clear speed registers, we call\n+\t * get_phy_capabilities twice, once to get initial state of\n+\t * available speeds, and once to get current phy config.\n+\t */\n+\terr = i40e_aq_get_phy_capabilities(hw, false, true, &abilities,\n+\t\t\t\t\t NULL);\n+\tif (err) {\n+\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\"failed to get phy cap., ret = %s last_status = %s\\n\",\n+\t\t\ti40e_stat_str(hw, err),\n+\t\t\ti40e_aq_str(hw, hw->aq.asq_last_status));\n+\t\treturn err;\n+\t}\n+\tspeed = abilities.link_speed;\n \n \t/* Get the current phy config */\n \terr = i40e_aq_get_phy_capabilities(hw, false, false, &abilities,\n@@ -6635,9 +6653,9 @@ static i40e_status i40e_force_link_state(struct i40e_pf *pf, bool is_up)\n \t}\n \n \t/* If link needs to go up, but was not forced to go down,\n-\t * no need for a flap\n+\t * and its speed values are OK, no need for a flap\n \t */\n-\tif (is_up && abilities.phy_type != 0)\n+\tif (is_up && abilities.phy_type != 0 && abilities.link_speed != 0)\n \t\treturn I40E_SUCCESS;\n \n \t/* To force link we need to set bits for all supported PHY types,\n@@ -6649,7 +6667,10 @@ static i40e_status i40e_force_link_state(struct i40e_pf *pf, bool is_up)\n \tconfig.phy_type_ext = is_up ? (u8)((mask >> 32) & 0xff) : 0;\n \t/* Copy the old settings, except of phy_type */\n \tconfig.abilities = abilities.abilities;\n-\tconfig.link_speed = abilities.link_speed;\n+\tif (abilities.link_speed != 0)\n+\t\tconfig.link_speed = abilities.link_speed;\n+\telse\n+\t\tconfig.link_speed = speed;\n \tconfig.eee_capability = abilities.eee_capability;\n \tconfig.eeer = abilities.eeer_val;\n \tconfig.low_power_ctrl = abilities.d3_lpan;\n", "prefixes": [ "next", "S96", "1/9" ] }