Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/963037/?format=api
{ "id": 963037, "url": "http://patchwork.ozlabs.org/api/patches/963037/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180828171609.78242-3-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180828171609.78242-3-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-08-28T17:16:03", "name": "[next,S96,3/9] i40e: hold the rtnl lock on clearing interrupt scheme", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3efc9545ec0e4feeaabaf231ca56edc97a2775ee", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180828171609.78242-3-alice.michael@intel.com/mbox/", "series": [ { "id": 62918, "url": "http://patchwork.ozlabs.org/api/series/62918/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=62918", "date": "2018-08-28T17:16:03", "name": "[next,S96,1/9] i40e: Check and correct speed values for link on open", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/62918/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/963037/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/963037/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 420Flr6dlFz9s1x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 29 Aug 2018 03:16:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6A068864A4;\n\tTue, 28 Aug 2018 17:16:23 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YFWT61vMsk81; Tue, 28 Aug 2018 17:16:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4F3C68647A;\n\tTue, 28 Aug 2018 17:16:22 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id EF1341C2B65\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 Aug 2018 17:16:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EC6A785755\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 Aug 2018 17:16:19 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BBRYd_GRyRWG for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 Aug 2018 17:16:19 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 7191985779\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 Aug 2018 17:16:19 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Aug 2018 10:16:19 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 28 Aug 2018 10:16:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,300,1531810800\"; d=\"scan'208\";a=\"85666780\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 28 Aug 2018 10:16:03 -0700", "Message-Id": "<20180828171609.78242-3-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180828171609.78242-1-alice.michael@intel.com>", "References": "<20180828171609.78242-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S96 3/9] i40e: hold the rtnl lock on\n\tclearing interrupt scheme", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Patryk Małek <patryk.malek@intel.com>\n\nHold the rtnl lock when we're clearing interrupt scheme\nin i40e_shutdown and in i40e_remove.\n\nSigned-off-by: Patryk Małek <patryk.malek@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex fd0c6c5..79bffaf 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -14726,6 +14726,7 @@ static void i40e_remove(struct pci_dev *pdev)\n \t\tfree_irq(pf->pdev->irq, pf);\n \n \t/* Clear all dynamic memory lists of rings, q_vectors, and VSIs */\n+\trtnl_lock();\n \ti40e_clear_interrupt_scheme(pf);\n \tfor (i = 0; i < pf->num_alloc_vsi; i++) {\n \t\tif (pf->vsi[i]) {\n@@ -14735,6 +14736,7 @@ static void i40e_remove(struct pci_dev *pdev)\n \t\t\tpf->vsi[i] = NULL;\n \t\t}\n \t}\n+\trtnl_unlock();\n \n \t/* shutdown the adminq */\n \ti40e_shutdown_adminq(hw);\n@@ -14963,7 +14965,13 @@ static void i40e_shutdown(struct pci_dev *pdev)\n \t !(pf->flags & I40E_FLAG_MSIX_ENABLED))\n \t\tfree_irq(pf->pdev->irq, pf);\n \n+\t/* Since we're going to destroy queues during the\n+\t * i40e_clear_interrupt_scheme() we should hold the RTNL lock for this\n+\t * whole section\n+\t */\n+\trtnl_lock();\n \ti40e_clear_interrupt_scheme(pf);\n+\trtnl_unlock();\n \n \tif (system_state == SYSTEM_POWER_OFF) {\n \t\tpci_wake_from_d3(pdev, pf->wol_en);\n", "prefixes": [ "next", "S96", "3/9" ] }