Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 962,
    "url": "http://patchwork.ozlabs.org/api/patches/962/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/200809222152.m8MLq9N3031938@imap1.linux-foundation.org/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<200809222152.m8MLq9N3031938@imap1.linux-foundation.org>",
    "list_archive_url": null,
    "date": "2008-09-22T21:52:09",
    "name": "[02/21] forcedeth: fix MAC address detection on network card (regression in 2.6.23)",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "6f245fbb494e3070a2a68c9670a72c24e9942454",
    "submitter": {
        "id": 107,
        "url": "http://patchwork.ozlabs.org/api/people/107/?format=api",
        "name": "Andrew Morton",
        "email": "akpm@linux-foundation.org"
    },
    "delegate": {
        "id": 36,
        "url": "http://patchwork.ozlabs.org/api/users/36/?format=api",
        "username": "jgarzik",
        "first_name": "Jeff",
        "last_name": "Garzik",
        "email": "jgarzik@pobox.com"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/200809222152.m8MLq9N3031938@imap1.linux-foundation.org/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/962/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/962/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 356D2DDE06\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 07:54:10 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753285AbYIVVyF (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 22 Sep 2008 17:54:05 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1753724AbYIVVyE\n\t(ORCPT <rfc822; netdev-outgoing>); Mon, 22 Sep 2008 17:54:04 -0400",
            "from smtp1.linux-foundation.org ([140.211.169.13]:35293 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753154AbYIVVyC (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 22 Sep 2008 17:54:02 -0400",
            "from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8MLqA9N018331\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tMon, 22 Sep 2008 14:52:11 -0700",
            "from localhost.localdomain (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id\n\tm8MLq9N3031938; Mon, 22 Sep 2008 14:52:09 -0700"
        ],
        "Message-Id": "<200809222152.m8MLq9N3031938@imap1.linux-foundation.org>",
        "Subject": "[patch 02/21] forcedeth: fix MAC address detection on network card\n\t(regression in 2.6.23)",
        "To": "jeff@garzik.org",
        "Cc": "netdev@vger.kernel.org, akpm@linux-foundation.org,\n\tmichael.pyne@kdemail.net, AAbdulla@nvidia.com, aabdulla@nvidia.com,\n\tstable@kernel.org",
        "From": "akpm@linux-foundation.org",
        "Date": "Mon, 22 Sep 2008 14:52:09 -0700",
        "X-Spam-Status": "No, hits=-3.359 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED",
        "X-Spam-Checker-Version": "SpamAssassin 3.2.4-osdl_revision__1.47__",
        "X-MIMEDefang-Filter": "lf$Revision: 1.188 $",
        "X-Scanned-By": "MIMEDefang 2.63 on 140.211.169.13",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Michael Pyne <michael.pyne@kdemail.net>\n\nPartially revert a change to mac address detection introduced to the forcedeth\ndriver.  The change was intended to correct mac address detection for newer\nnVidia chipsets where the mac address was stored in reverse order.  One of\nthose chipsets appears to still have the mac address in reverse order (or at\nleast, it does on my system).\n\nThe change that broke mac address detection for my card was commit\nef756b3e56c68a4d76d9d7b9a73fa8f4f739180f \"forcedeth: mac address correct\"\n\nMy network card is an nVidia built-in Ethernet card, output from lspci as\nfollows (with text and numeric ids):\n$ lspci | grep Ethernet\n00:07.0 Bridge: nVidia Corporation MCP61 Ethernet (rev a2)\n$ lspci -n | grep 07.0\n00:07.0 0680: 10de:03ef (rev a2)\n\nThe vendor id is, of course, nVidia.  The device id corresponds to the\nNVIDIA_NVENET_19 entry.\n\nThe included patch fixes the MAC address detection on my system.\nInterestingly, the MAC address appears to be in the range reserved for my\nmotherboard manufacturer (Gigabyte) and not nVidia.\n\nSigned-off-by: Michael J. Pyne <michael.pyne@kdemail.net>\nCc: Jeff Garzik <jeff@garzik.org>\nCc: Ayaz Abdulla <aabdulla@nvidia.com>\nCc: <stable@kernel.org>\n\nOn Wed, 21 Nov 2007 15:34:52 -0800\n\"Ayaz Abdulla\" <AAbdulla@nvidia.com> wrote:\n\n> The solution is to get the OEM to update their BIOS (instead of\n> integrating this patch) since the MCP61 specs indicate that the MAC\n> Address should be in correct order from BIOS.\n> \n> By changing the feature DEV_HAS_CORRECT_MACADDR to all MCP61 boards, it\n> could cause it to break on other OEM systems who have implemented it\n> correctly.\n> \n\nOn Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <jeff@garzik.org> wrote:\n> NAK - this fixes one set of users, and breaks a working set of users.\n> \n> Need to add DMI check for the specific motherboard (dmi_check_system), \n> and flip flag according to success/failure of that check.\n\nSigned-off-by: Andrew Morton <akpm@linux-foundation.org>\n---\n\n drivers/net/forcedeth.c |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff -puN drivers/net/forcedeth.c~forcedeth-fix-mac-address-detection-on-network-card-regression-in-2623 drivers/net/forcedeth.c\n--- a/drivers/net/forcedeth.c~forcedeth-fix-mac-address-detection-on-network-card-regression-in-2623\n+++ a/drivers/net/forcedeth.c\n@@ -6069,7 +6069,7 @@ static struct pci_device_id pci_tbl[] = \n \t},\n \t{\t/* MCP61 Ethernet Controller */\n \t\tPCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_16),\n-\t\t.driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX_V1|DEV_HAS_STATISTICS_V2|DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR,\n+\t\t.driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX_V1|DEV_HAS_STATISTICS_V2|DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT,\n \t},\n \t{\t/* MCP61 Ethernet Controller */\n \t\tPCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_17),\n",
    "prefixes": [
        "02/21"
    ]
}