Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/961101/?format=api
{ "id": 961101, "url": "http://patchwork.ozlabs.org/api/patches/961101/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1534981635-27417-1-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1534981635-27417-1-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2018-08-22T23:47:14", "name": "[next-queue,1/2] ixgbe: disallow ipsec tx offload when in sr-iov mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "22a35ad55bb72798979fa473a5c3eef7074fe61b", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1534981635-27417-1-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [ { "id": 62051, "url": "http://patchwork.ozlabs.org/api/series/62051/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=62051", "date": "2018-08-22T23:47:14", "name": "[next-queue,1/2] ixgbe: disallow ipsec tx offload when in sr-iov mode", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/62051/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/961101/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/961101/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"bq0koKoR\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41wkkr3vzHz9s3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Aug 2018 09:48:18 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2011F87E14;\n\tWed, 22 Aug 2018 23:48:17 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pgsqAoXZL6WP; Wed, 22 Aug 2018 23:48:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4A8B287E0D;\n\tWed, 22 Aug 2018 23:48:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id ADA9D1C0A7F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Aug 2018 23:48:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AA6B287E0A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Aug 2018 23:48:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id l1Li-q8UJaty for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Aug 2018 23:48:15 +0000 (UTC)", "from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 07CCE87DFF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Aug 2018 23:48:14 +0000 (UTC)", "from pps.filterd (userp2130.oracle.com [127.0.0.1])\n\tby userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw7MNhqst180167\n\tfor <intel-wired-lan@lists.osuosl.org>; Wed, 22 Aug 2018 23:48:14 GMT", "from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby userp2130.oracle.com with ESMTP id 2kxavtw476-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK) for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Aug 2018 23:48:13 +0000", "from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw7MNmDL4013552\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK)\n\tfor <intel-wired-lan@lists.osuosl.org>; Wed, 22 Aug 2018 23:48:13 GMT", "from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tw7MNm2mC022451\n\tfor <intel-wired-lan@lists.osuosl.org>; Wed, 22 Aug 2018 23:48:09 GMT", "from slnelson-mint18.us.oracle.com (/10.159.153.199)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Wed, 22 Aug 2018 16:47:53 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : subject : date : message-id; s=corp-2018-07-02;\n\tbh=66Lj25FElFGL9pvRme2v1V4buXHilro/uO5d5AGmob4=;\n\tb=bq0koKoRsWnt4Ur4Vj6jhEcgGnl6ujFDXlj32ys5msW5RBVyWf+8Iga9Tx/1M7gDoL43\n\tbh4RRc3JUVhaDuMfACExKQIOpb2izL74nAgaUl3dEG0gKoGyvL+k90i1Ded2uZ0r3eEt\n\tlTsdPBeP4zgvnOKIvrojip14WfXE6CBBSBYgv0C6oxVgCUKDz8ROsH4EEHCcbyA41PDQ\n\t9YHCjneATkLTr/9FMhWUCUO6JjzicXwpMJNgeg6w/SXeJH5FVKuTVu9Rtp7DL3gqV2Fu\n\tl9p5pwkBTn+xeHBV6quZ9+UjI0AEAFLT2hbCfgNGaFEs2PNKJwqJB2Oh78Ek9fKjU9tk\n\twQ== ", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Aug 2018 16:47:14 -0700", "Message-Id": "<1534981635-27417-1-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 2.7.4", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=8993\n\tsignatures=668707", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=1\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=924\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1807170000 definitions=main-1808220235", "Subject": "[Intel-wired-lan] [PATCH next-queue 1/2] ixgbe: disallow ipsec tx\n\toffload when in sr-iov mode", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "There seems to be a problem in the x540's internal switch wherein if SR/IOV\nmode is enabled and an offloaded IPsec packet is sent to a local VF,\nthe packet is silently dropped. This might never be a problem as it is\nsomewhat a corner case, but if someone happens to be using IPsec offload\nfrom the PF to a VF that just happens to get migrated to the local box,\ncommunication will mysteriously fail.\n\nNot good.\n\nA simple way to protect from this is to simply not allow any IPsec offloads\nfor outgoing packets when num_vfs != 0. This doesn't help any offloads that\nwere created before SR/IOV was enabled, but we'll get to that later.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\nindex 68395ab..24076b4 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n@@ -697,6 +697,9 @@ static int ixgbe_ipsec_add_sa(struct xfrm_state *xs)\n \t} else {\n \t\tstruct tx_sa tsa;\n \n+\t\tif (adapter->num_vfs)\n+\t\t\treturn -EOPNOTSUPP;\n+\n \t\t/* find the first unused index */\n \t\tret = ixgbe_ipsec_find_empty_idx(ipsec, false);\n \t\tif (ret < 0) {\n", "prefixes": [ "next-queue", "1/2" ] }