Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/960023/?format=api
{ "id": 960023, "url": "http://patchwork.ozlabs.org/api/patches/960023/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180820151233.14629-7-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180820151233.14629-7-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-08-20T15:12:28", "name": "[next,S95,07/12] i40e: Unset promiscuous settings on VF reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2d75810e4af0f387ae97edf259829e43c0945163", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180820151233.14629-7-alice.michael@intel.com/mbox/", "series": [ { "id": 61649, "url": "http://patchwork.ozlabs.org/api/series/61649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=61649", "date": "2018-08-20T15:12:30", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/61649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/960023/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/960023/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41vVHb1wwfz9s7X\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Aug 2018 09:23:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B77AD87398;\n\tMon, 20 Aug 2018 23:23:53 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id G1GDPP3QOkcG; Mon, 20 Aug 2018 23:23:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6263A87399;\n\tMon, 20 Aug 2018 23:23:50 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id DFC4F1CF234\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Aug 2018 23:23:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DD37F85C2E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Aug 2018 23:23:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6eyEkLbBDwq8 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Aug 2018 23:23:47 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id DE0C885ABB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Aug 2018 23:23:46 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Aug 2018 16:23:45 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Aug 2018 16:23:32 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,267,1531810800\"; d=\"scan'208\";a=\"83446373\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Mon, 20 Aug 2018 08:12:28 -0700", "Message-Id": "<20180820151233.14629-7-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180820151233.14629-1-alice.michael@intel.com>", "References": "<20180820151233.14629-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S95 07/12] i40e: Unset promiscuous\n\tsettings on VF reset", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Mariusz Stachura <mariusz.stachura@intel.com>\n\nThis patch cleans up promiscuous configuration when a VF reset occurs.\nPreviously the promiscuous mode settings were still there after the VF\ndriver removal.\n\nSigned-off-by: Mariusz Stachura <mariusz.stachura@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 267 ++++++++++++---------\n 1 file changed, 157 insertions(+), 110 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex f56c645..ca423be 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1084,6 +1084,136 @@ static int i40e_quiesce_vf_pci(struct i40e_vf *vf)\n \treturn -EIO;\n }\n \n+static inline int i40e_getnum_vf_vsi_vlan_filters(struct i40e_vsi *vsi);\n+\n+/**\n+ * i40e_config_vf_promiscuous_mode\n+ * @vf: pointer to the VF info\n+ * @vsi_id: VSI id\n+ * @allmulti: set MAC L2 layer multicast promiscuous enable/disable\n+ * @alluni: set MAC L2 layer unicast promiscuous enable/disable\n+ *\n+ * Called from the VF to configure the promiscuous mode of\n+ * VF vsis and from the VF reset path to reset promiscuous mode.\n+ **/\n+static i40e_status i40e_config_vf_promiscuous_mode(struct i40e_vf *vf,\n+\t\t\t\t\t\t u16 vsi_id,\n+\t\t\t\t\t\t bool allmulti,\n+\t\t\t\t\t\t bool alluni)\n+{\n+\ti40e_status aq_ret = 0;\n+\tstruct i40e_pf *pf = vf->pf;\n+\tstruct i40e_hw *hw = &pf->hw;\n+\tstruct i40e_mac_filter *f;\n+\tstruct i40e_vsi *vsi;\n+\tint bkt;\n+\n+\tvsi = i40e_find_vsi_from_id(pf, vsi_id);\n+\tif (!i40e_vc_isvalid_vsi_id(vf, vsi_id) || !vsi)\n+\t\treturn I40E_ERR_PARAM;\n+\n+\tif (!test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps)) {\n+\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\"Unprivileged VF %d is attempting to configure promiscuous mode\\n\",\n+\t\t\tvf->vf_id);\n+\t\t/* Lie to the VF on purpose. */\n+\t\treturn 0;\n+\t}\n+\n+\tif (vf->port_vlan_id) {\n+\t\taq_ret = i40e_aq_set_vsi_mc_promisc_on_vlan(hw, vsi->seid,\n+\t\t\t\t\t\t\t allmulti,\n+\t\t\t\t\t\t\t vf->port_vlan_id,\n+\t\t\t\t\t\t\t NULL);\n+\t\tif (aq_ret) {\n+\t\t\tint aq_err = pf->hw.aq.asq_last_status;\n+\n+\t\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\t\"VF %d failed to set multicast promiscuous mode err %s aq_err %s\\n\",\n+\t\t\t\tvf->vf_id,\n+\t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n+\t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n+\t\t\treturn aq_ret;\n+\t\t}\n+\n+\t\taq_ret = i40e_aq_set_vsi_uc_promisc_on_vlan(hw, vsi->seid,\n+\t\t\t\t\t\t\t alluni,\n+\t\t\t\t\t\t\t vf->port_vlan_id,\n+\t\t\t\t\t\t\t NULL);\n+\t\tif (aq_ret) {\n+\t\t\tint aq_err = pf->hw.aq.asq_last_status;\n+\n+\t\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\t\"VF %d failed to set unicast promiscuous mode err %s aq_err %s\\n\",\n+\t\t\t\tvf->vf_id,\n+\t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n+\t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n+\t\t}\n+\t\treturn aq_ret;\n+\t} else if (i40e_getnum_vf_vsi_vlan_filters(vsi)) {\n+\t\thash_for_each(vsi->mac_filter_hash, bkt, f, hlist) {\n+\t\t\tif (f->vlan < 0 || f->vlan > I40E_MAX_VLANID)\n+\t\t\t\tcontinue;\n+\t\t\taq_ret = i40e_aq_set_vsi_mc_promisc_on_vlan(hw,\n+\t\t\t\t\t\t\t\t vsi->seid,\n+\t\t\t\t\t\t\t\t allmulti,\n+\t\t\t\t\t\t\t\t f->vlan,\n+\t\t\t\t\t\t\t\t NULL);\n+\t\t\tif (aq_ret) {\n+\t\t\t\tint aq_err = pf->hw.aq.asq_last_status;\n+\n+\t\t\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\t\t\"Could not add VLAN %d to multicast promiscuous domain err %s aq_err %s\\n\",\n+\t\t\t\t\tf->vlan,\n+\t\t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n+\t\t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n+\t\t\t}\n+\n+\t\t\taq_ret = i40e_aq_set_vsi_uc_promisc_on_vlan(hw,\n+\t\t\t\t\t\t\t\t vsi->seid,\n+\t\t\t\t\t\t\t\t alluni,\n+\t\t\t\t\t\t\t\t f->vlan,\n+\t\t\t\t\t\t\t\t NULL);\n+\t\t\tif (aq_ret) {\n+\t\t\t\tint aq_err = pf->hw.aq.asq_last_status;\n+\n+\t\t\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\t\t\"Could not add VLAN %d to Unicast promiscuous domain err %s aq_err %s\\n\",\n+\t\t\t\t\tf->vlan,\n+\t\t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n+\t\t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n+\t\t\t}\n+\t\t}\n+\t\treturn aq_ret;\n+\t}\n+\taq_ret = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid, allmulti,\n+\t\t\t\t\t\t NULL);\n+\tif (aq_ret) {\n+\t\tint aq_err = pf->hw.aq.asq_last_status;\n+\n+\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\"VF %d failed to set multicast promiscuous mode err %s aq_err %s\\n\",\n+\t\t\tvf->vf_id,\n+\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n+\t\t\ti40e_aq_str(&pf->hw, aq_err));\n+\t\treturn aq_ret;\n+\t}\n+\n+\taq_ret = i40e_aq_set_vsi_unicast_promiscuous(hw, vsi->seid, alluni,\n+\t\t\t\t\t\t NULL, true);\n+\tif (aq_ret) {\n+\t\tint aq_err = pf->hw.aq.asq_last_status;\n+\n+\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\"VF %d failed to set unicast promiscuous mode err %s aq_err %s\\n\",\n+\t\t\tvf->vf_id,\n+\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n+\t\t\ti40e_aq_str(&pf->hw, aq_err));\n+\t}\n+\n+\treturn aq_ret;\n+}\n+\n /**\n * i40e_trigger_vf_reset\n * @vf: pointer to the VF structure\n@@ -1145,6 +1275,9 @@ static void i40e_cleanup_reset_vf(struct i40e_vf *vf)\n \tstruct i40e_hw *hw = &pf->hw;\n \tu32 reg;\n \n+\t/* disable promisc modes in case they were enabled */\n+\ti40e_config_vf_promiscuous_mode(vf, vf->lan_vsi_id, false, false);\n+\n \t/* free VF resources to begin resetting the VSI state */\n \ti40e_free_vf_res(vf);\n \n@@ -1851,132 +1984,46 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \tstruct virtchnl_promisc_info *info =\n \t (struct virtchnl_promisc_info *)msg;\n \tstruct i40e_pf *pf = vf->pf;\n-\tstruct i40e_hw *hw = &pf->hw;\n-\tstruct i40e_mac_filter *f;\n \ti40e_status aq_ret = 0;\n \tbool allmulti = false;\n-\tstruct i40e_vsi *vsi;\n \tbool alluni = false;\n-\tint aq_err = 0;\n-\tint bkt;\n \n-\tvsi = i40e_find_vsi_from_id(pf, info->vsi_id);\n-\tif (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states) ||\n-\t !i40e_vc_isvalid_vsi_id(vf, info->vsi_id) ||\n-\t !vsi) {\n-\t\taq_ret = I40E_ERR_PARAM;\n-\t\tgoto error_param;\n-\t}\n-\tif (!test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps)) {\n-\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\"Unprivileged VF %d is attempting to configure promiscuous mode\\n\",\n-\t\t\tvf->vf_id);\n-\t\t/* Lie to the VF on purpose. */\n-\t\taq_ret = 0;\n-\t\tgoto error_param;\n-\t}\n+\tif (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states))\n+\t\treturn I40E_ERR_PARAM;\n+\n \t/* Multicast promiscuous handling*/\n \tif (info->flags & FLAG_VF_MULTICAST_PROMISC)\n \t\tallmulti = true;\n \n-\tif (vf->port_vlan_id) {\n-\t\taq_ret = i40e_aq_set_vsi_mc_promisc_on_vlan(hw, vsi->seid,\n-\t\t\t\t\t\t\t allmulti,\n-\t\t\t\t\t\t\t vf->port_vlan_id,\n-\t\t\t\t\t\t\t NULL);\n-\t} else if (i40e_getnum_vf_vsi_vlan_filters(vsi)) {\n-\t\thash_for_each(vsi->mac_filter_hash, bkt, f, hlist) {\n-\t\t\tif (f->vlan < 0 || f->vlan > I40E_MAX_VLANID)\n-\t\t\t\tcontinue;\n-\t\t\taq_ret = i40e_aq_set_vsi_mc_promisc_on_vlan(hw,\n-\t\t\t\t\t\t\t\t vsi->seid,\n-\t\t\t\t\t\t\t\t allmulti,\n-\t\t\t\t\t\t\t\t f->vlan,\n-\t\t\t\t\t\t\t\t NULL);\n-\t\t\taq_err = pf->hw.aq.asq_last_status;\n-\t\t\tif (aq_ret) {\n-\t\t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\t\"Could not add VLAN %d to multicast promiscuous domain err %s aq_err %s\\n\",\n-\t\t\t\t\tf->vlan,\n-\t\t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n-\t\t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n-\t\t\t\tbreak;\n-\t\t\t}\n-\t\t}\n-\t} else {\n-\t\taq_ret = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid,\n-\t\t\t\t\t\t\t allmulti, NULL);\n-\t\taq_err = pf->hw.aq.asq_last_status;\n-\t\tif (aq_ret) {\n-\t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"VF %d failed to set multicast promiscuous mode err %s aq_err %s\\n\",\n-\t\t\t\tvf->vf_id,\n-\t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n-\t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n-\t\t\tgoto error_param;\n-\t\t}\n-\t}\n-\n+\tif (info->flags & FLAG_VF_UNICAST_PROMISC)\n+\t\talluni = true;\n+\taq_ret = i40e_config_vf_promiscuous_mode(vf, info->vsi_id, allmulti,\n+\t\t\t\t\t\t alluni);\n \tif (!aq_ret) {\n-\t\tdev_info(&pf->pdev->dev,\n-\t\t\t \"VF %d successfully set multicast promiscuous mode\\n\",\n-\t\t\t vf->vf_id);\n-\t\tif (allmulti)\n+\t\tif (allmulti) {\n+\t\t\tdev_info(&pf->pdev->dev,\n+\t\t\t\t \"VF %d successfully set multicast promiscuous mode\\n\",\n+\t\t\t\t vf->vf_id);\n \t\t\tset_bit(I40E_VF_STATE_MC_PROMISC, &vf->vf_states);\n-\t\telse\n+\t\t} else {\n+\t\t\tdev_info(&pf->pdev->dev,\n+\t\t\t\t \"VF %d successfully unset multicast promiscuous mode\\n\",\n+\t\t\t\t vf->vf_id);\n \t\t\tclear_bit(I40E_VF_STATE_MC_PROMISC, &vf->vf_states);\n-\t}\n-\n-\tif (info->flags & FLAG_VF_UNICAST_PROMISC)\n-\t\talluni = true;\n-\tif (vf->port_vlan_id) {\n-\t\taq_ret = i40e_aq_set_vsi_uc_promisc_on_vlan(hw, vsi->seid,\n-\t\t\t\t\t\t\t alluni,\n-\t\t\t\t\t\t\t vf->port_vlan_id,\n-\t\t\t\t\t\t\t NULL);\n-\t} else if (i40e_getnum_vf_vsi_vlan_filters(vsi)) {\n-\t\thash_for_each(vsi->mac_filter_hash, bkt, f, hlist) {\n-\t\t\tif (f->vlan < 0 || f->vlan > I40E_MAX_VLANID)\n-\t\t\t\tcontinue;\n-\t\t\taq_ret = i40e_aq_set_vsi_uc_promisc_on_vlan(hw,\n-\t\t\t\t\t\t\t\t vsi->seid,\n-\t\t\t\t\t\t\t\t alluni,\n-\t\t\t\t\t\t\t\t f->vlan,\n-\t\t\t\t\t\t\t\t NULL);\n-\t\t\taq_err = pf->hw.aq.asq_last_status;\n-\t\t\tif (aq_ret)\n-\t\t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\t\"Could not add VLAN %d to Unicast promiscuous domain err %s aq_err %s\\n\",\n-\t\t\t\t\tf->vlan,\n-\t\t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n-\t\t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n \t\t}\n-\t} else {\n-\t\taq_ret = i40e_aq_set_vsi_unicast_promiscuous(hw, vsi->seid,\n-\t\t\t\t\t\t\t alluni, NULL,\n-\t\t\t\t\t\t\t true);\n-\t\taq_err = pf->hw.aq.asq_last_status;\n-\t\tif (aq_ret) {\n-\t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"VF %d failed to set unicast promiscuous mode %8.8x err %s aq_err %s\\n\",\n-\t\t\t\tvf->vf_id, info->flags,\n-\t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n-\t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n-\t\t\tgoto error_param;\n-\t\t}\n-\t}\n-\n-\tif (!aq_ret) {\n-\t\tdev_info(&pf->pdev->dev,\n-\t\t\t \"VF %d successfully set unicast promiscuous mode\\n\",\n-\t\t\t vf->vf_id);\n-\t\tif (alluni)\n+\t\tif (alluni) {\n+\t\t\tdev_info(&pf->pdev->dev,\n+\t\t\t\t \"VF %d successfully set unicast promiscuous mode\\n\",\n+\t\t\t\t vf->vf_id);\n \t\t\tset_bit(I40E_VF_STATE_UC_PROMISC, &vf->vf_states);\n-\t\telse\n+\t\t} else {\n+\t\t\tdev_info(&pf->pdev->dev,\n+\t\t\t\t \"VF %d successfully unset unicast promiscuous mode\\n\",\n+\t\t\t\t vf->vf_id);\n \t\t\tclear_bit(I40E_VF_STATE_UC_PROMISC, &vf->vf_states);\n+\t\t}\n \t}\n \n-error_param:\n \t/* send the response to the VF */\n \treturn i40e_vc_send_resp_to_vf(vf,\n \t\t\t\t VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE,\n", "prefixes": [ "next", "S95", "07/12" ] }