Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/960018/?format=api
{ "id": 960018, "url": "http://patchwork.ozlabs.org/api/patches/960018/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180820151233.14629-5-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180820151233.14629-5-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-08-20T15:12:26", "name": "[next,S95,05/12] i40evf: Change a VF mac without reloading the VF driver", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "60b30dfcd6b308090fa16a6cbd19b50ef4da917b", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180820151233.14629-5-alice.michael@intel.com/mbox/", "series": [ { "id": 61649, "url": "http://patchwork.ozlabs.org/api/series/61649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=61649", "date": "2018-08-20T15:12:30", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/61649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/960018/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/960018/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41vVHW5VNTz9s7X\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Aug 2018 09:23:51 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6F94F84746;\n\tMon, 20 Aug 2018 23:23:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id y2i3G09-RTLD; Mon, 20 Aug 2018 23:23:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B410F82705;\n\tMon, 20 Aug 2018 23:23:48 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1A5421C16D3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Aug 2018 23:23:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 17AD52302C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Aug 2018 23:23:47 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5HJzNM6n-4Mo for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Aug 2018 23:23:46 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3DC1B2301D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Aug 2018 23:23:46 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Aug 2018 16:23:45 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Aug 2018 16:23:32 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,267,1531810800\"; d=\"scan'208\";a=\"83446371\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Mon, 20 Aug 2018 08:12:26 -0700", "Message-Id": "<20180820151233.14629-5-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180820151233.14629-1-alice.michael@intel.com>", "References": "<20180820151233.14629-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S95 05/12] i40evf: Change a VF mac\n\twithout reloading the VF driver", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "=?utf-8?b?UGF3ZcWCIEphYsWCb8WEc2tp?=\n\t<\"pawel.jablonski@intel.compawel.jablonski\"@intel.com>, =?utf-8?q?Paw?=\n\t=?utf-8?b?ZcWCIEphYsWCb8WEc2tp?= <pawel.jablonski@intel.com>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Paweł Jabłoński <pawel.jablonski@intel.com> <pawel.jablonski@intel.com>\n\nAdd possibility to change a VF mac address from host side\nwithout reloading the VF driver on the guest side. Without\nthis patch it is not possible to change the VF mac because\nexecuting i40evf_virtchnl_completion function with\nVIRTCHNL_OP_GET_VF_RESOURCES opcode resets the VF mac\naddress to previous value.\n\nSigned-off-by: Paweł Jabłoński <pawel.jablonski@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 8 +++++---\n drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 11 +++++++++--\n 2 files changed, 14 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex c6d24ea..f56c645 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -2458,7 +2458,7 @@ static inline int i40e_check_vf_permission(struct i40e_vf *vf,\n \t\t !is_multicast_ether_addr(addr) && vf->pf_set_mac &&\n \t\t !ether_addr_equal(addr, vf->default_lan_addr.addr)) {\n \t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"VF attempting to override administratively set MAC address, reload the VF driver to resume normal operation\\n\");\n+\t\t\t\t\"VF attempting to override administratively set MAC address, bring down and up the VF interface to resume normal operation\\n\");\n \t\t\treturn -EPERM;\n \t\t}\n \t}\n@@ -3873,9 +3873,11 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)\n \t\t\t mac, vf_id);\n \t}\n \n-\t/* Force the VF driver stop so it has to reload with new MAC address */\n+\t/* Force the VF interface down so it has to bring up with new MAC\n+\t * address\n+\t */\n \ti40e_vc_disable_vf(vf);\n-\tdev_info(&pf->pdev->dev, \"Reload the VF driver to make this change effective.\\n\");\n+\tdev_info(&pf->pdev->dev, \"Bring down and up the VF interface to make this change effective.\\n\");\n \n error_param:\n \treturn ret;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex 565677d..79b7be8 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -1330,8 +1330,15 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,\n \t\t\t sizeof(struct virtchnl_vsi_resource);\n \t\tmemcpy(adapter->vf_res, msg, min(msglen, len));\n \t\ti40e_vf_parse_hw_config(&adapter->hw, adapter->vf_res);\n-\t\t/* restore current mac address */\n-\t\tether_addr_copy(adapter->hw.mac.addr, netdev->dev_addr);\n+\t\tif (is_zero_ether_addr(adapter->hw.mac.addr)) {\n+\t\t\t/* restore current mac address */\n+\t\t\tether_addr_copy(adapter->hw.mac.addr, netdev->dev_addr);\n+\t\t} else {\n+\t\t\t/* refresh current mac address if changed */\n+\t\t\tether_addr_copy(netdev->dev_addr, adapter->hw.mac.addr);\n+\t\t\tether_addr_copy(netdev->perm_addr,\n+\t\t\t\t\tadapter->hw.mac.addr);\n+\t\t}\n \t\ti40evf_process_config(adapter);\n \t\t}\n \t\tbreak;\n", "prefixes": [ "next", "S95", "05/12" ] }