Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/958752/?format=api
{ "id": 958752, "url": "http://patchwork.ozlabs.org/api/patches/958752/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20180817102645.3839621-8-arnd@arndb.de/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20180817102645.3839621-8-arnd@arndb.de>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20180817102645.3839621-8-arnd@arndb.de/", "date": "2018-08-17T10:26:37", "name": "[RFC,07/15] PCI/ACPI: clean up acpi_pci_root_create()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "8306c7a33499e0740ed8461a962d0eefe64d5b86", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20180817102645.3839621-8-arnd@arndb.de/mbox/", "series": [ { "id": 61229, "url": "http://patchwork.ozlabs.org/api/series/61229/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=61229", "date": "2018-08-17T10:26:32", "name": "PCI: turn some __weak functions into callbacks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/61229/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/958752/comments/", "check": "warning", "checks": "http://patchwork.ozlabs.org/api/patches/958752/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41sKRG0frzz9s3Z\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 17 Aug 2018 20:38:02 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 41sKRF6Z2TzF0vb\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 17 Aug 2018 20:38:01 +1000 (AEST)", "from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 41sKK63ZXZzDr5p\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 17 Aug 2018 20:32:41 +1000 (AEST)", "from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de\n\t(mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0M7Knm-1g271607FO-00x44h; Fri, 17 Aug 2018 12:27:18 +0200" ], "Authentication-Results": [ "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de", "lists.ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de", "lists.ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=arndb.de\n\t(client-ip=212.227.17.10; helo=mout.kundenserver.de;\n\tenvelope-from=arnd@arndb.de; receiver=<UNKNOWN>)", "lists.ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de" ], "From": "Arnd Bergmann <arnd@arndb.de>", "To": "linux-pci@vger.kernel.org,\n\tBjorn Helgaas <bhelgaas@google.com>", "Subject": "[RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()", "Date": "Fri, 17 Aug 2018 12:26:37 +0200", "Message-Id": "<20180817102645.3839621-8-arnd@arndb.de>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20180817102645.3839621-1-arnd@arndb.de>", "References": "<20180817102645.3839621-1-arnd@arndb.de>", "X-Provags-ID": "V03:K1:d27yj6uZ03Y8vFzVtfOG4i3FXwc0amjneq2jCzS3uuPksZ77MJw\n\tz4AgJqMZ+dms4uVm3++DD8efqm6WoDdC/G6wfOryIsOV1RJ2ZY4ekevcPFE7ZTFqkpdKzEv\n\tv8GV2slLum4Zw9yyUZDD4tFjdvfudOKVLZwMAK0sYh5leF4mXZD6qcPYHNKEZHtlwNRN1V2\n\tbRQa6vslOKqjMiXp7VGJw==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:dQxK7tItEl4=:M58Fmg5hzmIJtGAnJoWRiX\n\tlolFQgFa9Bv2Jzomd8ZcKQFhSRZvChrCKG6kMN4eONirFrjiQvLDtv1Xquv0p8/2VpgFiYgcE\n\tvCu0/uhbhORMSrGBxJBz9GEKFGYSXOMJHltVdDKPNhxY/pu0C1LrOxCbpRECgS930TbBXtL3g\n\tZO6yChgg5Oj7V4bNhSRjm6LPDmhje4+qCpygbu1ZUEfXWdmc/g5kxL7LCFKZYvr4PJ9Tl6ary\n\tFVjhbbXqR3+3VP8ljQ3GY/od8tVN3WyDLhrEU1OPf6mgcaKFbd8oKlTUxlCC8TBCyptLH6Qdm\n\tBdOqGgMxGLALN3gKh5ptAWLsfsKYDQsEb75eovdwMEarGTjHUzi94I4LG5tK/b9sexHFELK50\n\tvhN7zaEakHOQlz1Q60WzTb8GplZ+TCR3FflwWKesT2kQ/RInMyyYAHcxQfUUnEAqth6SNIQCb\n\tv2Bm0ntVXggdTjsRQ0yMwMuZh287Is44XfttsP7ELxU92jaLQEzRvJgGG45O4xlS1PIpAnsZg\n\t95t2v0gEe2eV60wSpm/mNwHz6hOzcxtNNz2ZGWUo0oOtOioq11nuxSeMHPiVaY1F80O0nHt/t\n\t781UwKEK/tkhs7/WF94ZbLmsgRr346WW+W+KuloOyzmNrgg8GiiWHdNrJyF9nXNGFLfglJV78\n\teG562zDwpU6+HVPCDRIUAwzjUeH2gxhKMehascMDaXSFSPjKao20exZi9lZwJqyb4tiM=", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.27", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,\n\tArnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,\n\tChristoph Hellwig <hch@infradead.org>, linux-acpi@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "The acpi_pci_create_root_bus() can be fully integrated into\nacpi_pci_root_create(), improving a few things:\n\n* We can call pci_scan_root_bus_bridge(), which registers and\n scans the bridge in one step.\n* After a failure in pci_register_host_bridge(), we correctly\n clean up the resources.\n* The bridge settings (release function, flags, operations etc)\n can get set up before registering the bridge.\n* Further cleanup would be possible, removing duplication between\n pci_host_bridge and some ACPI structures.\n\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/acpi/pci_root.c | 68 +++++++++++++++--------------------------\n 1 file changed, 24 insertions(+), 44 deletions(-)", "diff": "diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c\nindex 85dbcf47015b..5f73de3b67c8 100644\n--- a/drivers/acpi/pci_root.c\n+++ b/drivers/acpi/pci_root.c\n@@ -873,34 +873,6 @@ static void acpi_pci_root_release_info(struct pci_host_bridge *bridge)\n \t__acpi_pci_root_release_info(bridge->release_data);\n }\n \n-static struct pci_bus *acpi_pci_create_root_bus(struct device *parent, int bus,\n-\t\tstruct pci_ops *ops, void *sysdata, struct list_head *resources)\n-{\n-\tint error;\n-\tstruct pci_host_bridge *bridge;\n-\n-\tbridge = pci_alloc_host_bridge(0);\n-\tif (!bridge)\n-\t\treturn NULL;\n-\n-\tbridge->dev.parent = parent;\n-\n-\tlist_splice_init(resources, &bridge->windows);\n-\tbridge->sysdata = sysdata;\n-\tbridge->busnr = bus;\n-\tbridge->ops = ops;\n-\n-\terror = pci_register_host_bridge(bridge);\n-\tif (error < 0)\n-\t\tgoto err_out;\n-\n-\treturn bridge->bus;\n-\n-err_out:\n-\tkfree(bridge);\n-\treturn NULL;\n-}\n-\n struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,\n \t\t\t\t struct acpi_pci_root_ops *ops,\n \t\t\t\t struct acpi_pci_root_info *info,\n@@ -909,8 +881,7 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,\n \tint ret, busnum = root->secondary.start;\n \tstruct acpi_device *device = root->device;\n \tint node = acpi_get_node(device->handle);\n-\tstruct pci_bus *bus;\n-\tstruct pci_host_bridge *host_bridge;\n+\tstruct pci_host_bridge *bridge;\n \n \tinfo->root = root;\n \tinfo->bridge = device;\n@@ -930,30 +901,39 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,\n \n \tpci_acpi_root_add_resources(info);\n \tpci_add_resource(&info->resources, &root->secondary);\n-\tbus = acpi_pci_create_root_bus(NULL, busnum, ops->pci_ops,\n-\t\t\t\t sysdata, &info->resources);\n-\tif (!bus)\n+\n+\tbridge = pci_alloc_host_bridge(0);\n+\tif (!bridge)\n \t\tgoto out_release_info;\n \n-\thost_bridge = to_pci_host_bridge(bus->bridge);\n+\tlist_splice_init(&info->resources, &bridge->windows);\n+\tbridge->sysdata = sysdata;\n+\tbridge->busnr = busnum;\n+\tbridge->ops = ops->pci_ops;\n+\tpci_set_host_bridge_release(bridge, acpi_pci_root_release_info,\n+\t\t\t\t info);\n+\n \tif (!(root->osc_control_set & OSC_PCI_EXPRESS_NATIVE_HP_CONTROL))\n-\t\thost_bridge->native_pcie_hotplug = 0;\n+\t\tbridge->native_pcie_hotplug = 0;\n \tif (!(root->osc_control_set & OSC_PCI_SHPC_NATIVE_HP_CONTROL))\n-\t\thost_bridge->native_shpc_hotplug = 0;\n+\t\tbridge->native_shpc_hotplug = 0;\n \tif (!(root->osc_control_set & OSC_PCI_EXPRESS_AER_CONTROL))\n-\t\thost_bridge->native_aer = 0;\n+\t\tbridge->native_aer = 0;\n \tif (!(root->osc_control_set & OSC_PCI_EXPRESS_PME_CONTROL))\n-\t\thost_bridge->native_pme = 0;\n+\t\tbridge->native_pme = 0;\n \tif (!(root->osc_control_set & OSC_PCI_EXPRESS_LTR_CONTROL))\n-\t\thost_bridge->native_ltr = 0;\n+\t\tbridge->native_ltr = 0;\n+\n+\tret = pci_scan_root_bus_bridge(bridge);\n+\tif (ret < 0)\n+\t\tgoto out_release_bridge;\n \n-\tpci_scan_child_bus(bus);\n-\tpci_set_host_bridge_release(host_bridge, acpi_pci_root_release_info,\n-\t\t\t\t info);\n \tif (node != NUMA_NO_NODE)\n-\t\tdev_printk(KERN_DEBUG, &bus->dev, \"on NUMA node %d\\n\", node);\n-\treturn bus;\n+\t\tdev_printk(KERN_DEBUG, &bridge->bus->dev, \"on NUMA node %d\\n\", node);\n+\treturn bridge->bus;\n \n+out_release_bridge:\n+\tpci_free_host_bridge(bridge);\n out_release_info:\n \t__acpi_pci_root_release_info(info);\n \treturn NULL;\n", "prefixes": [ "RFC", "07/15" ] }