Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/957183/?format=api
{ "id": 957183, "url": "http://patchwork.ozlabs.org/api/patches/957183/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1534185825-12451-5-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1534185825-12451-5-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2018-08-13T18:43:41", "name": "[next-queue,4/8] ixgbe: add VF IPsec offload enable flag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "43dc50b326b3e2bd83097d17a6d723414654e439", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1534185825-12451-5-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [ { "id": 60595, "url": "http://patchwork.ozlabs.org/api/series/60595/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=60595", "date": "2018-08-13T18:43:38", "name": "ixgbe/ixgbevf: IPsec offload support for VFs", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/60595/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/957183/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/957183/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"dQ9jjdSN\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41q4Py0T0Jz9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 14 Aug 2018 04:44:05 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id F311B86628;\n\tMon, 13 Aug 2018 18:44:03 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fZZHNn94PovP; Mon, 13 Aug 2018 18:44:01 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0B80386737;\n\tMon, 13 Aug 2018 18:44:01 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 764D31C0574\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 13 Aug 2018 18:43:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 71BEC81E09\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 13 Aug 2018 18:43:58 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id v1ABfYR5XgBF for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 13 Aug 2018 18:43:56 +0000 (UTC)", "from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id C1A7781E80\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 13 Aug 2018 18:43:56 +0000 (UTC)", "from pps.filterd (aserp2120.oracle.com [127.0.0.1])\n\tby aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw7DIdbXa037807; Mon, 13 Aug 2018 18:43:55 GMT", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp2120.oracle.com with ESMTP id 2ksqrp5hvv-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 13 Aug 2018 18:43:54 +0000", "from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w7DIhsum031321\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 13 Aug 2018 18:43:54 GMT", "from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14])\n\tby userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tw7DIhr0Z009075; Mon, 13 Aug 2018 18:43:53 GMT", "from slnelson-mint18.us.oracle.com (/10.159.144.11)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Mon, 13 Aug 2018 11:43:53 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references;\n\ts=corp-2018-07-02; \n\tbh=qkhQXQ7ZYqvUq0l2QSmVipfUzb7tZFYqyZeSLCnVeLc=;\n\tb=dQ9jjdSNE+IFD9HAJDR6Jhi11fgNCuz5aL39KtJgb0Zfu8tRDz4o4qlQzw+ZlOcxK/oT\n\t1lhQ3A3NRIska5StBY2kkXNami2OjGl0ffOjDrhbobDLXi/gA5J6lS04FTZm6skoX//H\n\tCgTXNVO1Ki5ax52V9A25zE6SlSGVPMvIwmyT0As3bTAcdztNyQAQFp3xjAn+us2zeBJJ\n\tZAM7zt6hCi5KzApIJwTFi8cGcIyZ2P5kn+gDz4zRfrMhPINOqH4grt9wrfiMOqBr4OFD\n\t1ZZr522Yq714JLJnCz78vQoK8Rx4KrDM4JaFZPegaM1caBxeDUWi/IECa/MM26SZPox+\n\tnw== ", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Mon, 13 Aug 2018 11:43:41 -0700", "Message-Id": "<1534185825-12451-5-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1534185825-12451-1-git-send-email-shannon.nelson@oracle.com>", "References": "<1534185825-12451-1-git-send-email-shannon.nelson@oracle.com>", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=8984\n\tsignatures=668707", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=0\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1807170000 definitions=main-1808130188", "Subject": "[Intel-wired-lan] [PATCH next-queue 4/8] ixgbe: add VF IPsec\n\toffload enable flag", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "steffen.klassert@secunet.com, netdev@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Add a private flag to expressly enable support for VF IPsec offload.\nThe VF will have to be \"trusted\" in order to use the hardware offload,\nbut because of the general concerns of managing VF access, we want to\nbe sure the user specifically is enabling the feature.\n\nThis is likely a candidate for becoming a netdev feature flag.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 +\n drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 9 +++++++++\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 ++-\n 3 files changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\nindex 4fc906c..89e709c 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n@@ -605,6 +605,7 @@ struct ixgbe_adapter {\n #define IXGBE_FLAG2_EEE_ENABLED\t\t\tBIT(15)\n #define IXGBE_FLAG2_RX_LEGACY\t\t\tBIT(16)\n #define IXGBE_FLAG2_IPSEC_ENABLED\t\tBIT(17)\n+#define IXGBE_FLAG2_VF_IPSEC_ENABLED\t\tBIT(18)\n \n \t/* Tx fast path data */\n \tint num_tx_queues;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex e5a8461..732b1e6 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -136,6 +136,8 @@ static const char ixgbe_gstrings_test[][ETH_GSTRING_LEN] = {\n static const char ixgbe_priv_flags_strings[][ETH_GSTRING_LEN] = {\n #define IXGBE_PRIV_FLAGS_LEGACY_RX\tBIT(0)\n \t\"legacy-rx\",\n+#define IXGBE_PRIV_FLAGS_VF_IPSEC_EN\tBIT(1)\n+\t\"vf-ipsec\",\n };\n \n #define IXGBE_PRIV_FLAGS_STR_LEN ARRAY_SIZE(ixgbe_priv_flags_strings)\n@@ -3409,6 +3411,9 @@ static u32 ixgbe_get_priv_flags(struct net_device *netdev)\n \tif (adapter->flags2 & IXGBE_FLAG2_RX_LEGACY)\n \t\tpriv_flags |= IXGBE_PRIV_FLAGS_LEGACY_RX;\n \n+\tif (adapter->flags2 & IXGBE_FLAG2_VF_IPSEC_ENABLED)\n+\t\tpriv_flags |= IXGBE_PRIV_FLAGS_VF_IPSEC_EN;\n+\n \treturn priv_flags;\n }\n \n@@ -3421,6 +3426,10 @@ static int ixgbe_set_priv_flags(struct net_device *netdev, u32 priv_flags)\n \tif (priv_flags & IXGBE_PRIV_FLAGS_LEGACY_RX)\n \t\tflags2 |= IXGBE_FLAG2_RX_LEGACY;\n \n+\tflags2 &= ~IXGBE_FLAG2_VF_IPSEC_ENABLED;\n+\tif (priv_flags & IXGBE_PRIV_FLAGS_VF_IPSEC_EN)\n+\t\tflags2 |= IXGBE_FLAG2_VF_IPSEC_ENABLED;\n+\n \tif (flags2 != adapter->flags2) {\n \t\tadapter->flags2 = flags2;\n \ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\nindex 80108e1..ecd01fa 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n@@ -880,7 +880,8 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)\n \tint err;\n \n \tsam = (struct sa_mbx_msg *)(&msgbuf[1]);\n-\tif (!adapter->vfinfo[vf].trusted) {\n+\tif (!adapter->vfinfo[vf].trusted ||\n+\t !(adapter->flags2 & IXGBE_FLAG2_VF_IPSEC_ENABLED)) {\n \t\te_warn(drv, \"VF %d attempted to add an IPsec SA\\n\", vf);\n \t\terr = -EACCES;\n \t\tgoto err_out;\n", "prefixes": [ "next-queue", "4/8" ] }