Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/956570/?format=api
{ "id": 956570, "url": "http://patchwork.ozlabs.org/api/patches/956570/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20180811152820.26817-9-xypron.glpk@gmx.de/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180811152820.26817-9-xypron.glpk@gmx.de>", "list_archive_url": null, "date": "2018-08-11T15:28:13", "name": "[U-Boot,08/15] efi_loader: don't use unlimited stack as buffer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d6ec15d7c32f3e5f97dbd07a74da335c30a103c7", "submitter": { "id": 61270, "url": "http://patchwork.ozlabs.org/api/people/61270/?format=api", "name": "Heinrich Schuchardt", "email": "xypron.glpk@gmx.de" }, "delegate": { "id": 3400, "url": "http://patchwork.ozlabs.org/api/users/3400/?format=api", "username": "agraf", "first_name": "Alexander", "last_name": "Graf", "email": "agraf@suse.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20180811152820.26817-9-xypron.glpk@gmx.de/mbox/", "series": [ { "id": 60397, "url": "http://patchwork.ozlabs.org/api/series/60397/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=60397", "date": "2018-08-11T15:28:06", "name": "efi_loader: EFI_UNICODE_COLLATION_PROTOCOL", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/60397/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/956570/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/956570/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=gmx.de" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 41nmNn3ClBz9s89\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 12 Aug 2018 01:38:33 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid F1512C21E15; Sat, 11 Aug 2018 15:31:41 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 035ADC21E47;\n\tSat, 11 Aug 2018 15:28:53 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 24A31C21CB1; Sat, 11 Aug 2018 15:28:46 +0000 (UTC)", "from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lists.denx.de (Postfix) with ESMTPS id C314FC21D56\n\tfor <u-boot@lists.denx.de>; Sat, 11 Aug 2018 15:28:45 +0000 (UTC)", "from LT02.fritz.box ([88.152.14.153]) by mail.gmx.com (mrgmx102\n\t[212.227.17.174]) with ESMTPSA (Nemesis) id 0MBq8p-1fdpV50fEV-00Aooa;\n\tSat, 11 Aug 2018 17:28:44 +0200" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=FREEMAIL_FROM\n\tautolearn=unavailable autolearn_force=no version=3.4.0", "From": "Heinrich Schuchardt <xypron.glpk@gmx.de>", "To": "Alexander Graf <agraf@suse.de>", "Date": "Sat, 11 Aug 2018 17:28:13 +0200", "Message-Id": "<20180811152820.26817-9-xypron.glpk@gmx.de>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20180811152820.26817-1-xypron.glpk@gmx.de>", "References": "<20180811152820.26817-1-xypron.glpk@gmx.de>", "X-Provags-ID": "V03:K1:y9B9mU/0ykDkhDyazFNJrv90XdfqHiLUViTqM98ijdjDYgxu3G4\n\t3Fq+1InyZNaGbeS2+gwtQQas9A2MWyMaR8JVSPjSSL3v8xfWp9m7/K2nLRT2XIB2PNejgM8\n\tglcl62p4qwMOnEBlXyMN1I1O2ujbwBdjtz7JKn+5G3OjtltMIHP0+fnXvA7GEIYeqdNw/Pj\n\teenVwUpzR+UbCu66zF97w==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:kyYqsUN/J8Y=:5M7UnYvPaSoztNlTh3/VcK\n\tAC2rSUvkrcRLt7xdpecgjAdM02vUd9woUDAeyx6xjptgBvOyoTOFQx6dZ934N3vr3brVbyQTI\n\tGId63VvkB5hgY+4ruBYuUacXNeiaxdWiaICG4x8bg1LzlD2hAjS19IHE1FKKxPJz00UBkvwi0\n\ts3sgAMP3wA/RfSdj+n2njJcEtxuRFFUM1Nj5KDKcH3664J01TU/KaoFgXAAuQ8O4L4FFvUEsF\n\t7nzF9WFKEvCYzzG4VQmxOg8DhEUSwNW+8/UF0NfgGjdorb0s9fg2DRRYNqtvWZYYxJ3H1iJAs\n\tqZ+Ae56JfrcRWfCmNYvMsqPXhuOvvANkLUIOe+fw3CHZe9HnsA29yGW9r9Jd6u787ws7aw0nA\n\tvcYHY4vuu3iXpecUxmvKN47atkYJ775DQFEeYbJoEF6EtaO55o42DLjmjkI1InA3Buo88ESOI\n\tMWmJuRBlVuwt6z6TFAKaoVAZhAIFav7zPZO1lcAr7y3+QH1wFZ68iOdU7ZMbdoVeiCSAGU1YD\n\tx2HnO6RoFgfhExBMPahtONTvF73byJ6XzvwrZu1l5MxF+65s5CnrQdEMi+rv02rR8NI030Y3n\n\t29E9gCr9eYgMDwCg92l/uSkXKeftD0c5DxvKJGNQBLuwpJPfPlGcMrEIBst70fyaBaNFJgKit\n\tk7hqOhNRCeQGbX0R+KxzQEC2Erq2OKl4/y03luRRcpWSuuKkAheQj6CQtIO/XxQg/JZHSRzNc\n\tIRLF/ZJQ5ULmwuYIXQLeEzcHOXQlnWwonehgyoncn3LWVM24L62Cm3QHzeo=", "Cc": "Heinrich Schuchardt <xypron.glpk@gmx.de>, u-boot@lists.denx.de", "Subject": "[U-Boot] [PATCH 08/15] efi_loader: don't use unlimited stack as\n\tbuffer", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "The length of a string printed to the console by the\nEFI_SIMPLE_TEXT_OUTPUT_PROTOCOL is not limited by the UEFI spec.\nHence should not allocate a buffer for it on the stack.\n\nSigned-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\n---\n lib/efi_loader/efi_console.c | 20 +++++++++++++-------\n 1 file changed, 13 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c\nindex f3d612880c..f5f3f256dd 100644\n--- a/lib/efi_loader/efi_console.c\n+++ b/lib/efi_loader/efi_console.c\n@@ -111,16 +111,21 @@ static efi_status_t EFIAPI efi_cout_output_string(\n {\n \tstruct simple_text_output_mode *con = &efi_con_mode;\n \tstruct cout_mode *mode = &efi_cout_modes[con->mode];\n-\n-\tEFI_ENTRY(\"%p, %p\", this, string);\n-\n-\tunsigned int n16 = u16_strlen(string);\n-\tchar buf[MAX_UTF8_PER_UTF16 * n16 + 1];\n+\tchar *buf, *pos;\n \tu16 *p;\n+\tefi_status_t ret = EFI_SUCCESS;\n \n-\t*utf16_to_utf8((u8 *)buf, string, n16) = '\\0';\n+\tEFI_ENTRY(\"%p, %p\", this, string);\n \n+\tbuf = malloc(utf16_utf8_strlen(string) + 1);\n+\tif (!buf) {\n+\t\tret = EFI_OUT_OF_RESOURCES;\n+\t\tgoto out;\n+\t}\n+\tpos = buf;\n+\tutf16_utf8_strcpy(&pos, string);\n \tfputs(stdout, buf);\n+\tfree(buf);\n \n \t/*\n \t * Update the cursor position.\n@@ -158,7 +163,8 @@ static efi_status_t EFIAPI efi_cout_output_string(\n \t\tcon->cursor_row = min(con->cursor_row, (s32)mode->rows - 1);\n \t}\n \n-\treturn EFI_EXIT(EFI_SUCCESS);\n+out:\n+\treturn EFI_EXIT(ret);\n }\n \n static efi_status_t EFIAPI efi_cout_test_string(\n", "prefixes": [ "U-Boot", "08/15" ] }