Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/955593/?format=api
{ "id": 955593, "url": "http://patchwork.ozlabs.org/api/patches/955593/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180809132903.22819-8-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180809132903.22819-8-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-08-09T13:28:57", "name": "[v4,07/13] ice: Use order_base_2 to calculate higher power of 2", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3e976744b5981a92d7b9a7e33f2cb36dd2df98ba", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180809132903.22819-8-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 60077, "url": "http://patchwork.ozlabs.org/api/series/60077/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=60077", "date": "2018-08-09T13:28:50", "name": "Bug fixes for ice", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/60077/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/955593/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/955593/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41mTcq2cskz9s0n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 9 Aug 2018 23:29:30 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4EFAB87A0C;\n\tThu, 9 Aug 2018 13:29:29 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7ukNnmFBMgYk; Thu, 9 Aug 2018 13:29:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3FD708790E;\n\tThu, 9 Aug 2018 13:29:27 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 59EC81C3F93\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Aug 2018 13:29:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 56F9929434\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Aug 2018 13:29:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WwEtVD8eP6IJ for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Aug 2018 13:29:24 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 779D6240C4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Aug 2018 13:29:24 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Aug 2018 06:29:24 -0700", "from kyungmin-mobl.amr.corp.intel.com (HELO\n\tavenkata-mobl4.localdomain) ([10.254.101.153])\n\tby orsmga004.jf.intel.com with ESMTP; 09 Aug 2018 06:29:22 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,215,1531810800\"; d=\"scan'208\";a=\"223273561\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 9 Aug 2018 06:28:57 -0700", "Message-Id": "<20180809132903.22819-8-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180809132903.22819-1-anirudh.venkataramanan@intel.com>", "References": "<20180809132903.22819-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v4 07/13] ice: Use order_base_2 to\n\tcalculate higher power of 2", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nCurrently, we use a combination of ilog2 and is_power_of_2() to\ncalculate the next power of 2 for the qcount. This appears to be causing\na warning on some combinations of GCC and the Linux kernel:\n\nMODPOST 1 modules\nWARNING: \"____ilog2_NaN\" [ice.ko] undefined!\n\nThis appears to because because GCC realizes that qcount could be zero\nin some circumstances and thus attempts to link against the\nintentionally undefined ___ilog2_NaN function.\n\nThe order_base_2 function is intentionally defined to return 0 when\npassed 0 as an argument, and thus will be safe to use here.\n\nThis not only fixes the warning but makes the resulting code slightly\ncleaner, and is really what we should have used originally.\n\nAlso update the comment to make it more clear that we are rounding up,\nnot just incrementing the ilog2 of qcount unconditionally.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n[Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> minor cleanup for upstream submission]\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex f3ba4f76b6cb..3eff1d2d1543 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1313,11 +1313,8 @@ static void ice_vsi_setup_q_map(struct ice_vsi *vsi, struct ice_vsi_ctx *ctxt)\n \t\tqcount = numq_tc;\n \t}\n \n-\t/* find higher power-of-2 of qcount */\n-\tpow = ilog2(qcount);\n-\n-\tif (!is_power_of_2(qcount))\n-\t\tpow++;\n+\t/* find the (rounded up) power-of-2 of qcount */\n+\tpow = order_base_2(qcount);\n \n \tfor (i = 0; i < ICE_MAX_TRAFFIC_CLASS; i++) {\n \t\tif (!(vsi->tc_cfg.ena_tc & BIT(i))) {\n", "prefixes": [ "v4", "07/13" ] }