Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/954830/?format=api
{ "id": 954830, "url": "http://patchwork.ozlabs.org/api/patches/954830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180808001123.55890-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180808001123.55890-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-08-08T00:11:23", "name": "i40e: Fix for tx timeouts when interface is brought up if DCB is enabled", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fa0f4c1f37968493f632c347aea65bc92b37e3f3", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180808001123.55890-1-alice.michael@intel.com/mbox/", "series": [ { "id": 59818, "url": "http://patchwork.ozlabs.org/api/series/59818/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=59818", "date": "2018-08-08T00:11:23", "name": "i40e: Fix for tx timeouts when interface is brought up if DCB is enabled", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/59818/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/954830/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/954830/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41lkrp1Txrz9ryt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 8 Aug 2018 18:22:17 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BE7B286A15;\n\tWed, 8 Aug 2018 08:22:15 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HKS0tDt3OdG4; Wed, 8 Aug 2018 08:22:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E5FF986A98;\n\tWed, 8 Aug 2018 08:22:13 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 120441C0D89\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 8 Aug 2018 08:22:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0CE0786172\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 8 Aug 2018 08:22:13 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id L3lwPnEnKrra for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 8 Aug 2018 08:22:12 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id E61988606C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 8 Aug 2018 08:22:11 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Aug 2018 01:22:10 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Aug 2018 01:22:10 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,456,1526367600\"; d=\"scan'208\";a=\"74736438\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 7 Aug 2018 17:11:23 -0700", "Message-Id": "<20180808001123.55890-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [PATCH] i40e: Fix for tx timeouts when interface\n\tis brought up if DCB is enabled", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "\"Szapar, Martyna\" <martyna.szapar@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: \"Szapar, Martyna\" <martyna.szapar@intel.com>\n\nIf interface is connected to switch port configured for DCB there are\nTX timeouts when bringing up interface. Problem started appearing after\nadding in i40e driver code mqprio hardware offload mode. In function\ni40e_vsi_configure_bw_alloc was added resetting BW rate which should\nbe executing when mqprio qdisc is removed but was also when there was\nno mqprio qdisc added and DCB was enabled. In this patch was added\nadditional check for DCB flag so now when DCB is enabled the correct\nDCB configs from before mqprio patch are restored.\n\nSigned-off-by: Martyna Szapar <martyna.szapar@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4300483..9c0fe8c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5127,15 +5127,17 @@ static int i40e_vsi_configure_bw_alloc(struct i40e_vsi *vsi, u8 enabled_tc,\n \t\t\t\t u8 *bw_share)\n {\n \tstruct i40e_aqc_configure_vsi_tc_bw_data bw_data;\n+\tstruct i40e_pf *pf = vsi->back;\n \ti40e_status ret;\n \tint i;\n \n-\tif (vsi->back->flags & I40E_FLAG_TC_MQPRIO)\n+\t/* There is no need to reset BW when mqprio mode is on. */\n+\tif (pf->flags & I40E_FLAG_TC_MQPRIO)\n \t\treturn 0;\n-\tif (!vsi->mqprio_qopt.qopt.hw) {\n+\tif (!vsi->mqprio_qopt.qopt.hw && !(pf->flags & I40E_FLAG_DCB_ENABLED)) {\n \t\tret = i40e_set_bw_limit(vsi, vsi->seid, 0);\n \t\tif (ret)\n-\t\t\tdev_info(&vsi->back->pdev->dev,\n+\t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t \"Failed to reset tx rate for vsi->seid %u\\n\",\n \t\t\t\t vsi->seid);\n \t\treturn ret;\n@@ -5144,12 +5146,11 @@ static int i40e_vsi_configure_bw_alloc(struct i40e_vsi *vsi, u8 enabled_tc,\n \tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++)\n \t\tbw_data.tc_bw_credits[i] = bw_share[i];\n \n-\tret = i40e_aq_config_vsi_tc_bw(&vsi->back->hw, vsi->seid, &bw_data,\n-\t\t\t\t NULL);\n+\tret = i40e_aq_config_vsi_tc_bw(&pf->hw, vsi->seid, &bw_data, NULL);\n \tif (ret) {\n-\t\tdev_info(&vsi->back->pdev->dev,\n+\t\tdev_info(&pf->pdev->dev,\n \t\t\t \"AQ command Config VSI BW allocation per TC failed = %d\\n\",\n-\t\t\t vsi->back->hw.aq.asq_last_status);\n+\t\t\t pf->hw.aq.asq_last_status);\n \t\treturn -EINVAL;\n \t}\n \n", "prefixes": [] }