Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95481/?format=api
{ "id": 95481, "url": "http://patchwork.ozlabs.org/api/patches/95481/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20110513145800.447aee1f@rex.config/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20110513145800.447aee1f@rex.config>", "list_archive_url": null, "date": "2011-05-13T13:58:00", "name": "ARM fixed-point support [4/6]: allow overriding of fixed-point helper function names", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "55a3fe3c071d37c38e8629a5efc68b704973cfe7", "submitter": { "id": 4374, "url": "http://patchwork.ozlabs.org/api/people/4374/?format=api", "name": "Julian Brown", "email": "julian@codesourcery.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20110513145800.447aee1f@rex.config/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/95481/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/95481/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-return-291806-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list gcc-patches@gcc.gnu.org" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\tby ozlabs.org (Postfix) with SMTP id 8C23FB6EF1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 13 May 2011 23:58:25 +1000 (EST)", "(qmail 4661 invoked by alias); 13 May 2011 13:58:22 -0000", "(qmail 4637 invoked by uid 22791); 13 May 2011 13:58:19 -0000", "from mail.codesourcery.com (HELO mail.codesourcery.com)\n\t(38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with\n\tESMTP; Fri, 13 May 2011 13:58:04 +0000", "(qmail 17421 invoked from network); 13 May 2011 13:58:03 -0000", "from unknown (HELO rex.config) (julian@127.0.0.2) by\n\tmail.codesourcery.com with ESMTPA; 13 May 2011 13:58:03 -0000" ], "X-SWARE-Spam-Status": "No, hits=-0.3 required=5.0\ttests=AWL, BAYES_50,\n\tT_RP_MATCHES_RCVD", "X-Spam-Check-By": "sourceware.org", "Date": "Fri, 13 May 2011 14:58:00 +0100", "From": "Julian Brown <julian@codesourcery.com>", "To": "gcc-patches@gcc.gnu.org", "Subject": "[PATCH] ARM fixed-point support [4/6]: allow overriding of\n\tfixed-point helper function names", "Message-ID": "<20110513145800.447aee1f@rex.config>", "Mime-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"MP_/NQWu3u.xzRuZHjM9xBjzK6j\"", "X-IsSubscribed": "yes", "Mailing-List": "contact gcc-patches-help@gcc.gnu.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "List-Archive": "<http://gcc.gnu.org/ml/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-help@gcc.gnu.org>", "Sender": "gcc-patches-owner@gcc.gnu.org" }, "content": "This patch allows the decoration of helper function names for\nfixed-point support to be changed from the default \"__foo\" to a\ndifferent scheme, as required by the ARM EABI (these are\n\"vendor-specific\" helpers, so should go in a particular namespace).\nThese are only the machine-independent changes: the ARM-specific bits\ncome later.\n\nTested alongside other patches in the series. OK to apply?\n\nJulian\n\nChangeLog\n\n gcc/\n * config/fixed-bit.h (fixed-bit-machine.h): Include.\n (DECORATE_FIXED_NAME): Conditionally define if undefined. Use\n throughout file to decorate function names.\n * config/fixed-bit-mach-generic.h: New.\n\n libgcc/\n * Makefile.in (FIXED_BIT_MACHINE): New rule. Include\n target-specific or generic fixed_bit_machine_header to decorate the\n names of fixed-point helper functions.\n * fixed-obj.mk ($(o)_s$(objext)): Depend on $(FIXED_BIT_MACHINE).", "diff": "commit 3a3866071a8525ef21ffd66119419a4239797f8a\nAuthor: Julian Brown <julian@henry8.codesourcery.com>\nDate: Fri May 13 05:51:54 2011 -0700\n\n Machine-independent configuration changes for ARM fixed-point support\n\ndiff --git a/gcc/config/fixed-bit-mach-generic.h b/gcc/config/fixed-bit-mach-generic.h\nnew file mode 100644\nindex 0000000..8bfbf53\n--- /dev/null\n+++ b/gcc/config/fixed-bit-mach-generic.h\n@@ -0,0 +1,23 @@\n+/* Null machine-specific override for fixed-point support routine names.\n+ Copyright (C) 2011 Free Software Foundation, Inc.\n+\n+ This file is part of GCC.\n+\n+ GCC is free software; you can redistribute it and/or modify it\n+ under the terms of the GNU General Public License as published\n+ by the Free Software Foundation; either version 3, or (at your\n+ option) any later version.\n+\n+ GCC is distributed in the hope that it will be useful, but WITHOUT\n+ ANY WARRANTY; without even the implied warranty of MERCHANTABILITY\n+ or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public\n+ License for more details.\n+\n+ Under Section 7 of GPL version 3, you are granted additional\n+ permissions described in the GCC Runtime Library Exception, version\n+ 3.1, as published by the Free Software Foundation.\n+\n+ You should have received a copy of the GNU General Public License and\n+ a copy of the GCC Runtime Library Exception along with this program;\n+ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see\n+ <http://www.gnu.org/licenses/>. */\ndiff --git a/gcc/config/fixed-bit.h b/gcc/config/fixed-bit.h\nindex 562772d..1cce4ef 100644\n--- a/gcc/config/fixed-bit.h\n+++ b/gcc/config/fixed-bit.h\n@@ -25,6 +25,13 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see\n #ifndef _FIXED_BIT_H\n #define _FIXED_BIT_H\n \n+#include \"fixed-bit-machine.h\"\n+\n+/* This macro may be overridden for a given target in fixed-bit-machine.h. */\n+#ifndef DECORATE_FIXED_NAME\n+#define DECORATE_FIXED_NAME(X) __ ## X\n+#endif\n+\n /* To use this file we need to define one of the following:\n QQ_MODE, UQQ_MODE, HQ_MODE, UHQ_MODE, SQ_MODE, USQ_MODE, DQ_MODE, UDQ_MODE,\n TQ_MODE, UTQ_MODE, HA_MODE, UHA_MODE, SA_MODE, USA_MODE, DA_MODE, UDA_MODE,\n@@ -445,35 +452,37 @@ typedef union\n #define IBITS\t\tIBITS2(MODE_NAME)\n #define I_F_BITS\t(FBITS + IBITS)\n \n-#define FIXED_OP(OP,MODE,NUM)\tOP ## MODE ## NUM\n-\n-#define FIXED_SATURATE1_TEMP(NAME)\tFIXED_OP(__saturate1,NAME,)\n-#define FIXED_SATURATE2_TEMP(NAME)\tFIXED_OP(__saturate2,NAME,)\n-#define FIXED_MULHELPER_TEMP(NAME)\tFIXED_OP(__mulhelper,NAME,)\n-#define FIXED_DIVHELPER_TEMP(NAME)\tFIXED_OP(__divhelper,NAME,)\n-#define FIXED_ASHLHELPER_TEMP(NAME)\tFIXED_OP(__ashlhelper,NAME,)\n-#define FIXED_ADD_TEMP(NAME)\tFIXED_OP(__add,NAME,3)\n-#define FIXED_SSADD_TEMP(NAME)\tFIXED_OP(__ssadd,NAME,3)\n-#define FIXED_USADD_TEMP(NAME)\tFIXED_OP(__usadd,NAME,3)\n-#define FIXED_SUB_TEMP(NAME)\tFIXED_OP(__sub,NAME,3)\n-#define FIXED_SSSUB_TEMP(NAME)\tFIXED_OP(__sssub,NAME,3)\n-#define FIXED_USSUB_TEMP(NAME)\tFIXED_OP(__ussub,NAME,3)\n-#define FIXED_MUL_TEMP(NAME)\tFIXED_OP(__mul,NAME,3)\n-#define FIXED_SSMUL_TEMP(NAME)\tFIXED_OP(__ssmul,NAME,3)\n-#define FIXED_USMUL_TEMP(NAME)\tFIXED_OP(__usmul,NAME,3)\n-#define FIXED_DIV_TEMP(NAME)\tFIXED_OP(__div,NAME,3)\n-#define FIXED_UDIV_TEMP(NAME)\tFIXED_OP(__udiv,NAME,3)\n-#define FIXED_SSDIV_TEMP(NAME)\tFIXED_OP(__ssdiv,NAME,3)\n-#define FIXED_USDIV_TEMP(NAME)\tFIXED_OP(__usdiv,NAME,3)\n-#define FIXED_NEG_TEMP(NAME)\tFIXED_OP(__neg,NAME,2)\n-#define FIXED_SSNEG_TEMP(NAME)\tFIXED_OP(__ssneg,NAME,2)\n-#define FIXED_USNEG_TEMP(NAME)\tFIXED_OP(__usneg,NAME,2)\n-#define FIXED_ASHL_TEMP(NAME)\tFIXED_OP(__ashl,NAME,3)\n-#define FIXED_ASHR_TEMP(NAME)\tFIXED_OP(__ashr,NAME,3)\n-#define FIXED_LSHR_TEMP(NAME)\tFIXED_OP(__lshr,NAME,3)\n-#define FIXED_SSASHL_TEMP(NAME)\tFIXED_OP(__ssashl,NAME,3)\n-#define FIXED_USASHL_TEMP(NAME)\tFIXED_OP(__usashl,NAME,3)\n-#define FIXED_CMP_TEMP(NAME)\tFIXED_OP(__cmp,NAME,2)\n+#define FIXED_OP3(OP,MODE,NUM)\tOP ## MODE ## NUM\n+#define FIXED_OP2(OP,MODE,NUM)\tFIXED_OP3 (OP, MODE, NUM)\n+#define FIXED_OP(OP,MODE,NUM)\tFIXED_OP2 (DECORATE_FIXED_NAME (OP), MODE, NUM)\n+\n+#define FIXED_SATURATE1_TEMP(NAME)\tFIXED_OP(saturate1,NAME,)\n+#define FIXED_SATURATE2_TEMP(NAME)\tFIXED_OP(saturate2,NAME,)\n+#define FIXED_MULHELPER_TEMP(NAME)\tFIXED_OP(mulhelper,NAME,)\n+#define FIXED_DIVHELPER_TEMP(NAME)\tFIXED_OP(divhelper,NAME,)\n+#define FIXED_ASHLHELPER_TEMP(NAME)\tFIXED_OP(ashlhelper,NAME,)\n+#define FIXED_ADD_TEMP(NAME)\tFIXED_OP(add,NAME,3)\n+#define FIXED_SSADD_TEMP(NAME)\tFIXED_OP(ssadd,NAME,3)\n+#define FIXED_USADD_TEMP(NAME)\tFIXED_OP(usadd,NAME,3)\n+#define FIXED_SUB_TEMP(NAME)\tFIXED_OP(sub,NAME,3)\n+#define FIXED_SSSUB_TEMP(NAME)\tFIXED_OP(sssub,NAME,3)\n+#define FIXED_USSUB_TEMP(NAME)\tFIXED_OP(ussub,NAME,3)\n+#define FIXED_MUL_TEMP(NAME)\tFIXED_OP(mul,NAME,3)\n+#define FIXED_SSMUL_TEMP(NAME)\tFIXED_OP(ssmul,NAME,3)\n+#define FIXED_USMUL_TEMP(NAME)\tFIXED_OP(usmul,NAME,3)\n+#define FIXED_DIV_TEMP(NAME)\tFIXED_OP(div,NAME,3)\n+#define FIXED_UDIV_TEMP(NAME)\tFIXED_OP(udiv,NAME,3)\n+#define FIXED_SSDIV_TEMP(NAME)\tFIXED_OP(ssdiv,NAME,3)\n+#define FIXED_USDIV_TEMP(NAME)\tFIXED_OP(usdiv,NAME,3)\n+#define FIXED_NEG_TEMP(NAME)\tFIXED_OP(neg,NAME,2)\n+#define FIXED_SSNEG_TEMP(NAME)\tFIXED_OP(ssneg,NAME,2)\n+#define FIXED_USNEG_TEMP(NAME)\tFIXED_OP(usneg,NAME,2)\n+#define FIXED_ASHL_TEMP(NAME)\tFIXED_OP(ashl,NAME,3)\n+#define FIXED_ASHR_TEMP(NAME)\tFIXED_OP(ashr,NAME,3)\n+#define FIXED_LSHR_TEMP(NAME)\tFIXED_OP(lshr,NAME,3)\n+#define FIXED_SSASHL_TEMP(NAME)\tFIXED_OP(ssashl,NAME,3)\n+#define FIXED_USASHL_TEMP(NAME)\tFIXED_OP(usashl,NAME,3)\n+#define FIXED_CMP_TEMP(NAME)\tFIXED_OP(cmp,NAME,2)\n \n #if defined (MODE_NAME)\n #if defined (DINT_C_TYPE)\n@@ -1146,14 +1155,22 @@ extern FIXED_C_TYPE FIXED_USASHL (FIXED_C_TYPE, word_type);\n #define TO_HAVE_PADDING_BITS\t(TO_PADDING_BITS > 0)\n #endif /* TO_TYPE == 4 */\n \n-#define FIXED_CONVERT_OP(OP,FROM,TO)\tOP ## FROM ## TO\n-#define FIXED_CONVERT_OP2(OP,FROM,TO)\tOP ## FROM ## TO ## 2\n-#define FRACT_TEMP(N1,N2)\t\tFIXED_CONVERT_OP(__fract,N1,N2)\n-#define FRACT2_TEMP(N1,N2)\t\tFIXED_CONVERT_OP2(__fract,N1,N2)\n-#define SATFRACT_TEMP(N1,N2)\t\tFIXED_CONVERT_OP(__satfract,N1,N2)\n-#define SATFRACT2_TEMP(N1,N2)\t\tFIXED_CONVERT_OP2(__satfract,N1,N2)\n-#define FRACTUNS_TEMP(N1,N2)\t\tFIXED_CONVERT_OP(__fractuns,N1,N2)\n-#define SATFRACTUNS_TEMP(N1,N2)\t\tFIXED_CONVERT_OP(__satfractuns,N1,N2)\n+#define FIXED_CONVERT_OP_B(OP,FROM,TO)\tOP ## FROM ## TO\n+#define FIXED_CONVERT_OP_A(OP,FROM,TO)\tFIXED_CONVERT_OP_B(OP, FROM, TO)\n+#define FIXED_CONVERT_OP(OP,FROM,TO) \\\n+ FIXED_CONVERT_OP_A (DECORATE_FIXED_NAME (OP), FROM, TO)\n+\n+#define FIXED_CONVERT_OP2_B(OP,FROM,TO)\tOP ## FROM ## TO ## 2\n+#define FIXED_CONVERT_OP2_A(OP,FROM,TO)\tFIXED_CONVERT_OP2_B (OP, FROM, TO)\n+#define FIXED_CONVERT_OP2(OP,FROM,TO) \\\n+ FIXED_CONVERT_OP2_A (DECORATE_FIXED_NAME (OP), FROM, TO)\n+\n+#define FRACT_TEMP(N1,N2)\t\tFIXED_CONVERT_OP(fract,N1,N2)\n+#define FRACT2_TEMP(N1,N2)\t\tFIXED_CONVERT_OP2(fract,N1,N2)\n+#define SATFRACT_TEMP(N1,N2)\t\tFIXED_CONVERT_OP(satfract,N1,N2)\n+#define SATFRACT2_TEMP(N1,N2)\t\tFIXED_CONVERT_OP2(satfract,N1,N2)\n+#define FRACTUNS_TEMP(N1,N2)\t\tFIXED_CONVERT_OP(fractuns,N1,N2)\n+#define SATFRACTUNS_TEMP(N1,N2)\t\tFIXED_CONVERT_OP(satfractuns,N1,N2)\n \n /* Define conversions from fixed-point to fixed-point. */\n #if FROM_TYPE == 4 && TO_TYPE == 4\ndiff --git a/libgcc/Makefile.in b/libgcc/Makefile.in\nindex 7e2ab93..5874267 100644\n--- a/libgcc/Makefile.in\n+++ b/libgcc/Makefile.in\n@@ -647,6 +647,16 @@ endif\n # Build fixed-point support.\n ifeq ($(fixed_point),yes)\n \n+FIXED_BIT_MACHINE := fixed-bit-machine.h\n+\n+# Use default header if a machine-specific one is not defined.\n+ifeq ($(fixed_bit_machine_header),)\n+fixed_bit_machine_header := fixed-bit-mach-generic.h\n+endif\n+\n+$(FIXED_BIT_MACHINE): $(gcc_srcdir)/config/$(fixed_bit_machine_header)\n+\tcp $(gcc_srcdir)/config/$(fixed_bit_machine_header) $(FIXED_BIT_MACHINE)\n+\n # Generate permutations of function name and mode\n fixed-labels := $(shell $(SHELL) $(srcdir)/gen-fixed.sh arith labels)\n fixed-funcs := $(shell $(SHELL) $(srcdir)/gen-fixed.sh arith funcs)\ndiff --git a/libgcc/fixed-obj.mk b/libgcc/fixed-obj.mk\nindex 3c7c2f3..1bc8220 100644\n--- a/libgcc/fixed-obj.mk\n+++ b/libgcc/fixed-obj.mk\n@@ -22,10 +22,10 @@ endif\n \n #$(info $o$(objext): -DL$($o-label) $($o-opt))\n \n-$o$(objext): %$(objext): $(gcc_srcdir)/config/fixed-bit.c\n+$o$(objext): %$(objext): $(gcc_srcdir)/config/fixed-bit.c $(FIXED_BIT_MACHINE)\n \t$(gcc_compile) -DL$($*-label) $($*-opt) -c $(gcc_srcdir)/config/fixed-bit.c $(vis_hide)\n \n ifeq ($(enable_shared),yes)\n-$(o)_s$(objext): %_s$(objext): $(gcc_srcdir)/config/fixed-bit.c\n+$(o)_s$(objext): %_s$(objext): $(gcc_srcdir)/config/fixed-bit.c $(FIXED_BIT_MACHINE)\n \t$(gcc_s_compile) -DL$($*-label) $($*-opt) -c $(gcc_srcdir)/config/fixed-bit.c\n endif\n", "prefixes": [] }