Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 95478,
    "url": "http://patchwork.ozlabs.org/api/patches/95478/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20110513145721.2fbe289b@rex.config/",
    "project": {
        "id": 17,
        "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api",
        "name": "GNU Compiler Collection",
        "link_name": "gcc",
        "list_id": "gcc-patches.gcc.gnu.org",
        "list_email": "gcc-patches@gcc.gnu.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20110513145721.2fbe289b@rex.config>",
    "list_archive_url": null,
    "date": "2011-05-13T13:57:21",
    "name": "ARM fixed-point support [1/6]: comparison optab biasing",
    "commit_ref": null,
    "pull_url": null,
    "state": "new",
    "archived": false,
    "hash": "9a148696d84ff32765b24ee38bf73d4fa9e2a8f0",
    "submitter": {
        "id": 4374,
        "url": "http://patchwork.ozlabs.org/api/people/4374/?format=api",
        "name": "Julian Brown",
        "email": "julian@codesourcery.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20110513145721.2fbe289b@rex.config/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/95478/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/95478/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<gcc-patches-return-291803-incoming=patchwork.ozlabs.org@gcc.gnu.org>",
        "X-Original-To": "incoming@patchwork.ozlabs.org",
        "Delivered-To": [
            "patchwork-incoming@bilbo.ozlabs.org",
            "mailing list gcc-patches@gcc.gnu.org"
        ],
        "Received": [
            "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\tby ozlabs.org (Postfix) with SMTP id 5D41AB6EEE\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 13 May 2011 23:57:45 +1000 (EST)",
            "(qmail 2727 invoked by alias); 13 May 2011 13:57:43 -0000",
            "(qmail 2711 invoked by uid 22791); 13 May 2011 13:57:42 -0000",
            "from mail.codesourcery.com (HELO mail.codesourcery.com)\n\t(38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with\n\tESMTP; Fri, 13 May 2011 13:57:26 +0000",
            "(qmail 17164 invoked from network); 13 May 2011 13:57:26 -0000",
            "from unknown (HELO rex.config) (julian@127.0.0.2) by\n\tmail.codesourcery.com with ESMTPA; 13 May 2011 13:57:26 -0000"
        ],
        "X-SWARE-Spam-Status": "No, hits=-1.7 required=5.0\ttests=AWL, BAYES_00,\n\tT_RP_MATCHES_RCVD",
        "X-Spam-Check-By": "sourceware.org",
        "Date": "Fri, 13 May 2011 14:57:21 +0100",
        "From": "Julian Brown <julian@codesourcery.com>",
        "To": "gcc-patches@gcc.gnu.org",
        "Subject": "[PATCH] ARM fixed-point support [1/6]: comparison optab biasing",
        "Message-ID": "<20110513145721.2fbe289b@rex.config>",
        "Mime-Version": "1.0",
        "Content-Type": "multipart/mixed; boundary=\"MP_/vqqjmOp5UPXiEHpcUQEVeRd\"",
        "X-IsSubscribed": "yes",
        "Mailing-List": "contact gcc-patches-help@gcc.gnu.org; run by ezmlm",
        "Precedence": "bulk",
        "List-Id": "<gcc-patches.gcc.gnu.org>",
        "List-Unsubscribe": "<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>",
        "List-Archive": "<http://gcc.gnu.org/ml/gcc-patches/>",
        "List-Post": "<mailto:gcc-patches@gcc.gnu.org>",
        "List-Help": "<mailto:gcc-patches-help@gcc.gnu.org>",
        "Sender": "gcc-patches-owner@gcc.gnu.org"
    },
    "content": "As per Joseph's suggestion here:\n\nhttp://gcc.gnu.org/ml/gcc-patches/2011-05/msg00846.html\n\nI am re-posting machine-independent parts of my ARM fixed-point support\npatches, with explanations as to why each part is necessary.\n\nThis is the first: on ARM, TARGET_LIB_INT_CMP_BIASED is false for\nTARGET_BPABI targets (i.e. most currently-interesting cases --\nEABI comparison helper functions return -1/0/1 for lt/eq/gt rather than\n0/1/2). However the fixed-point helper library uses biased comparisons\nunconditionally. So, this patch just makes comparisons between\nfixed-point quantities use the biasing rather than not. (Grepping\nconfig/, in practice, this will only affect ARM.)\n\nTested in a series with other fixed-point patches. OK to apply?\n\nJulian\n\nChangeLog\n\n    gcc/\n    * optabs.c (prepare_cmp_insn): Use correct biasing for fixed-point\n    comparison helpers.",
    "diff": "commit 12efebd5f56358c2d194659570ad05e089bbaaf3\nAuthor: Julian Brown <julian@henry8.codesourcery.com>\nDate:   Fri May 13 05:42:15 2011 -0700\n\n    Correct biasing for fixed-point optabs.\n\ndiff --git a/gcc/optabs.c b/gcc/optabs.c\nindex 62e123b..a1b85b8 100644\n--- a/gcc/optabs.c\n+++ b/gcc/optabs.c\n@@ -3930,11 +3930,13 @@ prepare_cmp_insn (rtx x, rtx y, enum rtx_code comparison, rtx size,\n \t result against 1 in the biased case, and zero in the unbiased\n \t case. For unsigned comparisons always compare against 1 after\n \t biasing the unbiased result by adding 1. This gives us a way to\n-\t represent LTU. */\n+\t represent LTU.\n+\t The comparisons in the fixed-point helper library are always\n+\t biased.  */\n       x = result;\n       y = const1_rtx;\n \n-      if (!TARGET_LIB_INT_CMP_BIASED)\n+      if (!TARGET_LIB_INT_CMP_BIASED && !ALL_FIXED_POINT_MODE_P (mode))\n \t{\n \t  if (unsignedp)\n \t    x = plus_constant (result, 1);\n",
    "prefixes": []
}