Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/954052/?format=api
{ "id": 954052, "url": "http://patchwork.ozlabs.org/api/patches/954052/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-60-git-send-email-aleksandar.markovic@rt-rk.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1533574847-19294-60-git-send-email-aleksandar.markovic@rt-rk.com>", "list_archive_url": null, "date": "2018-08-06T17:00:26", "name": "[v7,59/80] gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "20d399c6c14af1d77fb034c60018bf1d5e400043", "submitter": { "id": 68635, "url": "http://patchwork.ozlabs.org/api/people/68635/?format=api", "name": "Aleksandar Markovic", "email": "aleksandar.markovic@rt-rk.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-60-git-send-email-aleksandar.markovic@rt-rk.com/mbox/", "series": [ { "id": 59520, "url": "http://patchwork.ozlabs.org/api/series/59520/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=59520", "date": "2018-08-06T16:59:27", "name": "Add nanoMIPS support to QEMU", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/59520/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/954052/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/954052/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=rt-rk.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41klPv3Gsbz9rvt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 7 Aug 2018 03:44:03 +1000 (AEST)", "from localhost ([::1]:35399 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1fmjY1-0006BM-3C\n\tfor incoming@patchwork.ozlabs.org; Mon, 06 Aug 2018 13:44:01 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:41591)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmjGa-0007id-Ax\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:26:01 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmjGY-0002Cz-BG\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:26:00 -0400", "from mx2.rt-rk.com ([89.216.37.149]:45778 helo=mail.rt-rk.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <aleksandar.markovic@rt-rk.com>)\n\tid 1fmjGY-0002Be-3e\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:25:58 -0400", "from localhost (localhost [127.0.0.1])\n\tby mail.rt-rk.com (Postfix) with ESMTP id BA6E21A2149;\n\tMon, 6 Aug 2018 19:25:56 +0200 (CEST)", "from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local\n\t[10.10.13.43])\n\tby mail.rt-rk.com (Postfix) with ESMTPSA id 965681A2036;\n\tMon, 6 Aug 2018 19:25:56 +0200 (CEST)" ], "X-Virus-Scanned": "amavisd-new at rt-rk.com", "From": "Aleksandar Markovic <aleksandar.markovic@rt-rk.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 6 Aug 2018 19:00:26 +0200", "Message-Id": "<1533574847-19294-60-git-send-email-aleksandar.markovic@rt-rk.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "References": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "89.216.37.149", "Subject": "[Qemu-devel] [PATCH v7 59/80] gdbstub: Disable handling of nanoMIPS\n\tISA bit in the MIPS gdbstub", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, thuth@redhat.com, pburton@wavecomp.com,\n\tsmarkovic@wavecomp.com, riku.voipio@iki.fi,\n\trichard.henderson@linaro.org, laurent@vivier.eu,\n\tarmbru@redhat.com, arikalo@wavecomp.com,\n\tphilippe.mathieu.daude@gmail.com, amarkovic@wavecomp.com,\n\tpjovanovic@wavecomp.com, aurelien@aurel32.net", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: James Hogan <james.hogan@mips.com>\n\nnanoMIPS has no ISA bit in the PC, so remove the handling of the low bit\nof the PC in the MIPS gdbstub for nanoMIPS. This prevents the PC being\nread as e.g. 0xbfc00001, and prevents writing to the PC clearing\nMIPS_HFLAG_M16.\n\nSigned-off-by: James Hogan <james.hogan@mips.com>\nSigned-off-by: Yongbok Kim <yongbok.kim@mips.com>\nSigned-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>\nSigned-off-by: Stefan Markovic <smarkovic@wavecomp.com>\n---\n target/mips/gdbstub.c | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/target/mips/gdbstub.c b/target/mips/gdbstub.c\nindex 18e0e6d..559b69f 100644\n--- a/target/mips/gdbstub.c\n+++ b/target/mips/gdbstub.c\n@@ -60,7 +60,8 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)\n return gdb_get_regl(mem_buf, (int32_t)env->CP0_Cause);\n case 37:\n return gdb_get_regl(mem_buf, env->active_tc.PC |\n- !!(env->hflags & MIPS_HFLAG_M16));\n+ (!(env->insn_flags & ISA_NANOMIPS32) &&\n+ env->hflags & MIPS_HFLAG_M16));\n case 72:\n return gdb_get_regl(mem_buf, 0); /* fp */\n case 89:\n@@ -131,10 +132,12 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n break;\n case 37:\n env->active_tc.PC = tmp & ~(target_ulong)1;\n- if (tmp & 1) {\n- env->hflags |= MIPS_HFLAG_M16;\n- } else {\n- env->hflags &= ~(MIPS_HFLAG_M16);\n+ if (!(env->insn_flags & ISA_NANOMIPS32)) {\n+ if (tmp & 1) {\n+ env->hflags |= MIPS_HFLAG_M16;\n+ } else {\n+ env->hflags &= ~(MIPS_HFLAG_M16);\n+ }\n }\n break;\n case 72: /* fp, ignored */\n", "prefixes": [ "v7", "59/80" ] }