Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/954035/?format=api
{ "id": 954035, "url": "http://patchwork.ozlabs.org/api/patches/954035/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-26-git-send-email-aleksandar.markovic@rt-rk.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1533574847-19294-26-git-send-email-aleksandar.markovic@rt-rk.com>", "list_archive_url": null, "date": "2018-08-06T16:59:52", "name": "[v7,25/80] target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b1b0e5df1c964661b89f3d35aae9319bf21f37e2", "submitter": { "id": 68635, "url": "http://patchwork.ozlabs.org/api/people/68635/?format=api", "name": "Aleksandar Markovic", "email": "aleksandar.markovic@rt-rk.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-26-git-send-email-aleksandar.markovic@rt-rk.com/mbox/", "series": [ { "id": 59520, "url": "http://patchwork.ozlabs.org/api/series/59520/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=59520", "date": "2018-08-06T16:59:27", "name": "Add nanoMIPS support to QEMU", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/59520/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/954035/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/954035/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=rt-rk.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41klBR4zz8z9ryt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 7 Aug 2018 03:34:07 +1000 (AEST)", "from localhost ([::1]:35336 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1fmjOP-0005iH-7u\n\tfor incoming@patchwork.ozlabs.org; Mon, 06 Aug 2018 13:34:05 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:57443)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmj29-00026i-GD\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:11:06 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmj26-0003Qd-OB\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:11:05 -0400", "from mx2.rt-rk.com ([89.216.37.149]:47340 helo=mail.rt-rk.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <aleksandar.markovic@rt-rk.com>)\n\tid 1fmj26-0003Nt-0k\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:11:02 -0400", "from localhost (localhost [127.0.0.1])\n\tby mail.rt-rk.com (Postfix) with ESMTP id CA9071A209A;\n\tMon, 6 Aug 2018 19:11:00 +0200 (CEST)", "from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local\n\t[10.10.13.43])\n\tby mail.rt-rk.com (Postfix) with ESMTPSA id A6D741A2039;\n\tMon, 6 Aug 2018 19:11:00 +0200 (CEST)" ], "X-Virus-Scanned": "amavisd-new at rt-rk.com", "From": "Aleksandar Markovic <aleksandar.markovic@rt-rk.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 6 Aug 2018 18:59:52 +0200", "Message-Id": "<1533574847-19294-26-git-send-email-aleksandar.markovic@rt-rk.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "References": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "89.216.37.149", "Subject": "[Qemu-devel] [PATCH v7 25/80] target/mips: Add emulation of\n\tnanoMIPS 16-bit save and restore instructions", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, thuth@redhat.com, pburton@wavecomp.com,\n\tsmarkovic@wavecomp.com, riku.voipio@iki.fi,\n\trichard.henderson@linaro.org, laurent@vivier.eu,\n\tarmbru@redhat.com, arikalo@wavecomp.com,\n\tphilippe.mathieu.daude@gmail.com, amarkovic@wavecomp.com,\n\tpjovanovic@wavecomp.com, aurelien@aurel32.net", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Matthew Fortune <matthew.fortune@mips.com>\n\nAdd emulation of SAVE16 and RESTORE.JRC16 instructions. Routines\ngen_save(), gen_restore(), and gen_adjust_sp() are provided to support\nthis feature.\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Yongbok Kim <yongbok.kim@mips.com>\nSigned-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>\nSigned-off-by: Stefan Markovic <smarkovic@wavecomp.com>\n---\n target/mips/translate.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 71 insertions(+)", "diff": "diff --git a/target/mips/translate.c b/target/mips/translate.c\nindex 93c197a..a688af4 100644\n--- a/target/mips/translate.c\n+++ b/target/mips/translate.c\n@@ -16593,6 +16593,62 @@ static inline int decode_gpr_gpr4_zero(int r)\n #define NANOMIPS_EXTRACT_RS5(op) (op & 0x1f)\n \n \n+static void gen_adjust_sp(DisasContext *ctx, int u)\n+{\n+ gen_op_addr_addi(ctx, cpu_gpr[29], cpu_gpr[29], u);\n+}\n+\n+static void gen_save(DisasContext *ctx, uint8_t rt, uint8_t count,\n+ uint8_t gp, uint16_t u)\n+{\n+ int counter = 0;\n+ TCGv va = tcg_temp_new();\n+ TCGv t0 = tcg_temp_new();\n+\n+ while (counter != count) {\n+ bool use_gp = gp && (counter == count - 1);\n+ int this_rt = use_gp ? 28 : (rt & 0x10) | ((rt + counter) & 0x1f);\n+ int this_offset = -((counter + 1) << 2);\n+ gen_base_offset_addr(ctx, va, 29, this_offset);\n+ gen_load_gpr(t0, this_rt);\n+ tcg_gen_qemu_st_tl(t0, va, ctx->mem_idx,\n+ (MO_TEUL | ctx->default_tcg_memop_mask));\n+ counter++;\n+ }\n+\n+ /* adjust stack pointer */\n+ gen_adjust_sp(ctx, -u);\n+\n+ tcg_temp_free(t0);\n+ tcg_temp_free(va);\n+}\n+\n+static void gen_restore(DisasContext *ctx, uint8_t rt, uint8_t count,\n+ uint8_t gp, uint16_t u)\n+{\n+ int counter = 0;\n+ TCGv va = tcg_temp_new();\n+ TCGv t0 = tcg_temp_new();\n+\n+ while (counter != count) {\n+ bool use_gp = gp && (counter == count - 1);\n+ int this_rt = use_gp ? 28 : (rt & 0x10) | ((rt + counter) & 0x1f);\n+ int this_offset = u - ((counter + 1) << 2);\n+ gen_base_offset_addr(ctx, va, 29, this_offset);\n+ tcg_gen_qemu_ld_tl(t0, va, ctx->mem_idx, MO_TESL |\n+ ctx->default_tcg_memop_mask);\n+ tcg_gen_ext32s_tl(t0, t0);\n+ gen_store_gpr(t0, this_rt);\n+ counter++;\n+ }\n+\n+ /* adjust stack pointer */\n+ gen_adjust_sp(ctx, u);\n+\n+ tcg_temp_free(t0);\n+ tcg_temp_free(va);\n+}\n+\n static void gen_pool16c_nanomips_insn(DisasContext *ctx)\n {\n int rt = decode_gpr_gpr3(NANOMIPS_EXTRACT_RD(ctx->opcode));\n@@ -16912,6 +16968,21 @@ static int decode_nanomips_opc(CPUMIPSState *env, DisasContext *ctx)\n }\n break;\n case NM_P16_SR:\n+ {\n+ int count = extract32(ctx->opcode, 0, 4);\n+ int u = extract32(ctx->opcode, 4, 4) << 4;\n+\n+ rt = 30 + extract32(ctx->opcode, 9, 1);\n+ switch (extract32(ctx->opcode, 8, 1)) {\n+ case NM_SAVE16:\n+ gen_save(ctx, rt, count, 0, u);\n+ break;\n+ case NM_RESTORE_JRC16:\n+ gen_restore(ctx, rt, count, 0, u);\n+ gen_compute_branch(ctx, OPC_JR, 2, 31, 0, 0, 0);\n+ break;\n+ }\n+ }\n break;\n case NM_MOVEP:\n break;\n", "prefixes": [ "v7", "25/80" ] }