Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/954014/?format=api
{ "id": 954014, "url": "http://patchwork.ozlabs.org/api/patches/954014/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-10-git-send-email-aleksandar.markovic@rt-rk.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1533574847-19294-10-git-send-email-aleksandar.markovic@rt-rk.com>", "list_archive_url": null, "date": "2018-08-06T16:59:36", "name": "[v7,09/80] target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c26b72b4ed3ab1be45df7d119c3278529a449aa6", "submitter": { "id": 68635, "url": "http://patchwork.ozlabs.org/api/people/68635/?format=api", "name": "Aleksandar Markovic", "email": "aleksandar.markovic@rt-rk.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-10-git-send-email-aleksandar.markovic@rt-rk.com/mbox/", "series": [ { "id": 59520, "url": "http://patchwork.ozlabs.org/api/series/59520/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=59520", "date": "2018-08-06T16:59:27", "name": "Add nanoMIPS support to QEMU", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/59520/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/954014/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/954014/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=rt-rk.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41kknf5cWXz9ryt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 7 Aug 2018 03:16:06 +1000 (AEST)", "from localhost ([::1]:35236 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1fmj6x-0006Nx-JF\n\tfor incoming@patchwork.ozlabs.org; Mon, 06 Aug 2018 13:16:03 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:53614)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmiwB-0004oD-5K\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:04:56 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmiwA-0006PN-5i\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:04:55 -0400", "from mx2.rt-rk.com ([89.216.37.149]:43357 helo=mail.rt-rk.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <aleksandar.markovic@rt-rk.com>)\n\tid 1fmiw9-0006OI-T0\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:04:54 -0400", "from localhost (localhost [127.0.0.1])\n\tby mail.rt-rk.com (Postfix) with ESMTP id 25D551A20C6;\n\tMon, 6 Aug 2018 19:04:51 +0200 (CEST)", "from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local\n\t[10.10.13.43])\n\tby mail.rt-rk.com (Postfix) with ESMTPSA id 03F141A209A;\n\tMon, 6 Aug 2018 19:04:51 +0200 (CEST)" ], "X-Virus-Scanned": "amavisd-new at rt-rk.com", "From": "Aleksandar Markovic <aleksandar.markovic@rt-rk.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 6 Aug 2018 18:59:36 +0200", "Message-Id": "<1533574847-19294-10-git-send-email-aleksandar.markovic@rt-rk.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "References": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "89.216.37.149", "Subject": "[Qemu-devel] [PATCH v7 09/80] target/mips: Check ELPA flag only in\n\tsome cases of MFHC0 and MTHC0", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, thuth@redhat.com, pburton@wavecomp.com,\n\tsmarkovic@wavecomp.com, riku.voipio@iki.fi,\n\trichard.henderson@linaro.org, laurent@vivier.eu,\n\tarmbru@redhat.com, arikalo@wavecomp.com,\n\tphilippe.mathieu.daude@gmail.com, amarkovic@wavecomp.com,\n\tpjovanovic@wavecomp.com, aurelien@aurel32.net", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Yongbok Kim <yongbok.kim@mips.com>\n\nMFHC0 and MTHC0 used to handle EntryLo0 and EntryLo1 registers only,\nand placing ELPA flag checks before switch statement were technically\ncorrect. However, after adding handling more registers, these checks\nshould be moved to act only in cases of handling EntryLo0 and\nEntryLo1.\n\nReviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Yongbok Kim <yongbok.kim@mips.com>\nSigned-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>\n---\n target/mips/translate.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/mips/translate.c b/target/mips/translate.c\nindex 841c0c8..bc1f21f 100644\n--- a/target/mips/translate.c\n+++ b/target/mips/translate.c\n@@ -4896,12 +4896,11 @@ static void gen_mfhc0(DisasContext *ctx, TCGv arg, int reg, int sel)\n {\n const char *rn = \"invalid\";\n \n- CP0_CHECK(ctx->hflags & MIPS_HFLAG_ELPA);\n-\n switch (reg) {\n case 2:\n switch (sel) {\n case 0:\n+ CP0_CHECK(ctx->hflags & MIPS_HFLAG_ELPA);\n gen_mfhc0_entrylo(arg, offsetof(CPUMIPSState, CP0_EntryLo0));\n rn = \"EntryLo0\";\n break;\n@@ -4912,6 +4911,7 @@ static void gen_mfhc0(DisasContext *ctx, TCGv arg, int reg, int sel)\n case 3:\n switch (sel) {\n case 0:\n+ CP0_CHECK(ctx->hflags & MIPS_HFLAG_ELPA);\n gen_mfhc0_entrylo(arg, offsetof(CPUMIPSState, CP0_EntryLo1));\n rn = \"EntryLo1\";\n break;\n@@ -4964,12 +4964,11 @@ static void gen_mthc0(DisasContext *ctx, TCGv arg, int reg, int sel)\n const char *rn = \"invalid\";\n uint64_t mask = ctx->PAMask >> 36;\n \n- CP0_CHECK(ctx->hflags & MIPS_HFLAG_ELPA);\n-\n switch (reg) {\n case 2:\n switch (sel) {\n case 0:\n+ CP0_CHECK(ctx->hflags & MIPS_HFLAG_ELPA);\n tcg_gen_andi_tl(arg, arg, mask);\n gen_mthc0_entrylo(arg, offsetof(CPUMIPSState, CP0_EntryLo0));\n rn = \"EntryLo0\";\n@@ -4981,6 +4980,7 @@ static void gen_mthc0(DisasContext *ctx, TCGv arg, int reg, int sel)\n case 3:\n switch (sel) {\n case 0:\n+ CP0_CHECK(ctx->hflags & MIPS_HFLAG_ELPA);\n tcg_gen_andi_tl(arg, arg, mask);\n gen_mthc0_entrylo(arg, offsetof(CPUMIPSState, CP0_EntryLo1));\n rn = \"EntryLo1\";\n", "prefixes": [ "v7", "09/80" ] }