Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/953997/?format=api
{ "id": 953997, "url": "http://patchwork.ozlabs.org/api/patches/953997/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-4-git-send-email-aleksandar.markovic@rt-rk.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1533574847-19294-4-git-send-email-aleksandar.markovic@rt-rk.com>", "list_archive_url": null, "date": "2018-08-06T16:59:30", "name": "[v7,03/80] target/mips: Mark switch fallthroughs with interpretable comments", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "34007dda39353ef243c33dec69c2061f22f8e02f", "submitter": { "id": 68635, "url": "http://patchwork.ozlabs.org/api/people/68635/?format=api", "name": "Aleksandar Markovic", "email": "aleksandar.markovic@rt-rk.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-4-git-send-email-aleksandar.markovic@rt-rk.com/mbox/", "series": [ { "id": 59520, "url": "http://patchwork.ozlabs.org/api/series/59520/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=59520", "date": "2018-08-06T16:59:27", "name": "Add nanoMIPS support to QEMU", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/59520/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/953997/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/953997/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=rt-rk.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41kkYt5K0Qz9ryt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 7 Aug 2018 03:05:54 +1000 (AEST)", "from localhost ([::1]:35178 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1fmix6-0004wA-8n\n\tfor incoming@patchwork.ozlabs.org; Mon, 06 Aug 2018 13:05:52 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:52399)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmitX-0002Hd-7j\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:02:12 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmitU-0004Uz-JQ\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:02:11 -0400", "from mx2.rt-rk.com ([89.216.37.149]:42772 helo=mail.rt-rk.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <aleksandar.markovic@rt-rk.com>)\n\tid 1fmitU-0004SB-CO\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:02:08 -0400", "from localhost (localhost [127.0.0.1])\n\tby mail.rt-rk.com (Postfix) with ESMTP id D59731A20C6;\n\tMon, 6 Aug 2018 19:02:06 +0200 (CEST)", "from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local\n\t[10.10.13.43])\n\tby mail.rt-rk.com (Postfix) with ESMTPSA id B3B7F1A209A;\n\tMon, 6 Aug 2018 19:02:06 +0200 (CEST)" ], "X-Virus-Scanned": "amavisd-new at rt-rk.com", "From": "Aleksandar Markovic <aleksandar.markovic@rt-rk.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 6 Aug 2018 18:59:30 +0200", "Message-Id": "<1533574847-19294-4-git-send-email-aleksandar.markovic@rt-rk.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "References": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "89.216.37.149", "Subject": "[Qemu-devel] [PATCH v7 03/80] target/mips: Mark switch fallthroughs\n\twith interpretable comments", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, thuth@redhat.com, pburton@wavecomp.com,\n\tsmarkovic@wavecomp.com, riku.voipio@iki.fi,\n\trichard.henderson@linaro.org, laurent@vivier.eu,\n\tarmbru@redhat.com, arikalo@wavecomp.com,\n\tphilippe.mathieu.daude@gmail.com, amarkovic@wavecomp.com,\n\tpjovanovic@wavecomp.com, aurelien@aurel32.net", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Aleksandar Markovic <amarkovic@wavecomp.com>\n\nMark switch fallthroughs with comments, in cases fallthroughs\nare intentional.\n\nThe comments \"/* fall through */\" are interpreted by compilers and\nother tools, and they will not issue warnings in such cases. For gcc,\nthe warning is turnend on by -Wimplicit-fallthrough. With this patch,\nthere will be no such warnings in target/mips directory. If such\nwarning appears in future, it should be checked if it is intentional,\nand, if yes, marked with a comment similar to those from this patch.\n\nThe comment must be just before next \"case\", otherwise gcc won't\nunderstand it.\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>\nSigned-off-by: Stefan Markovic <smarkovic@wavecomp.com>\n---\n target/mips/translate.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/target/mips/translate.c b/target/mips/translate.c\nindex 051dda5..e32fd5f 100644\n--- a/target/mips/translate.c\n+++ b/target/mips/translate.c\n@@ -14255,8 +14255,8 @@ static void decode_micromips32_opc(CPUMIPSState *env, DisasContext *ctx)\n case SDP:\n check_insn(ctx, ISA_MIPS3);\n check_mips_64(ctx);\n- /* Fallthrough */\n #endif\n+ /* fall through */\n case LWP:\n case SWP:\n gen_ldst_pair(ctx, minor, rt, rs, SIMM(ctx->opcode, 0, 12));\n@@ -14266,8 +14266,8 @@ static void decode_micromips32_opc(CPUMIPSState *env, DisasContext *ctx)\n case SDM:\n check_insn(ctx, ISA_MIPS3);\n check_mips_64(ctx);\n- /* Fallthrough */\n #endif\n+ /* fall through */\n case LWM32:\n case SWM32:\n gen_ldst_multiple(ctx, minor, rt, rs, SIMM(ctx->opcode, 0, 12));\n@@ -20023,6 +20023,7 @@ static void decode_opc(CPUMIPSState *env, DisasContext *ctx)\n case OPC_MTHC1:\n check_cp1_enabled(ctx);\n check_insn(ctx, ISA_MIPS32R2);\n+ /* fall through */\n case OPC_MFC1:\n case OPC_CFC1:\n case OPC_MTC1:\n", "prefixes": [ "v7", "03/80" ] }