Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/953996/?format=api
{ "id": 953996, "url": "http://patchwork.ozlabs.org/api/patches/953996/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-9-git-send-email-aleksandar.markovic@rt-rk.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1533574847-19294-9-git-send-email-aleksandar.markovic@rt-rk.com>", "list_archive_url": null, "date": "2018-08-06T16:59:35", "name": "[v7,08/80] target/mips: Don't update BadVAddr register in Debug Mode", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c9a144b27ac362e8f74cb512ef03cc11daaee7e6", "submitter": { "id": 68635, "url": "http://patchwork.ozlabs.org/api/people/68635/?format=api", "name": "Aleksandar Markovic", "email": "aleksandar.markovic@rt-rk.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1533574847-19294-9-git-send-email-aleksandar.markovic@rt-rk.com/mbox/", "series": [ { "id": 59520, "url": "http://patchwork.ozlabs.org/api/series/59520/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=59520", "date": "2018-08-06T16:59:27", "name": "Add nanoMIPS support to QEMU", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/59520/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/953996/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/953996/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=rt-rk.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41kkYc1WJJz9s0R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 7 Aug 2018 03:05:40 +1000 (AEST)", "from localhost ([::1]:35175 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1fmiwr-0004m0-RA\n\tfor incoming@patchwork.ozlabs.org; Mon, 06 Aug 2018 13:05:37 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:53489)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmivc-0003nq-1I\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:04:24 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1fmivZ-0006At-BS\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:04:20 -0400", "from mx2.rt-rk.com ([89.216.37.149]:43244 helo=mail.rt-rk.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <aleksandar.markovic@rt-rk.com>)\n\tid 1fmivY-0006AE-W6\n\tfor qemu-devel@nongnu.org; Mon, 06 Aug 2018 13:04:17 -0400", "from localhost (localhost [127.0.0.1])\n\tby mail.rt-rk.com (Postfix) with ESMTP id AB59D1A20C6;\n\tMon, 6 Aug 2018 19:04:15 +0200 (CEST)", "from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local\n\t[10.10.13.43])\n\tby mail.rt-rk.com (Postfix) with ESMTPSA id 88DA91A209A;\n\tMon, 6 Aug 2018 19:04:15 +0200 (CEST)" ], "X-Virus-Scanned": "amavisd-new at rt-rk.com", "From": "Aleksandar Markovic <aleksandar.markovic@rt-rk.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 6 Aug 2018 18:59:35 +0200", "Message-Id": "<1533574847-19294-9-git-send-email-aleksandar.markovic@rt-rk.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "References": "<1533574847-19294-1-git-send-email-aleksandar.markovic@rt-rk.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "89.216.37.149", "Subject": "[Qemu-devel] [PATCH v7 08/80] target/mips: Don't update BadVAddr\n\tregister in Debug Mode", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, thuth@redhat.com, pburton@wavecomp.com,\n\tsmarkovic@wavecomp.com, riku.voipio@iki.fi,\n\trichard.henderson@linaro.org, laurent@vivier.eu,\n\tarmbru@redhat.com, arikalo@wavecomp.com,\n\tphilippe.mathieu.daude@gmail.com, amarkovic@wavecomp.com,\n\tpjovanovic@wavecomp.com, aurelien@aurel32.net", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Yongbok Kim <yongbok.kim@mips.com>\n\nBadVAddr should not be updated if (env->hflags & MIPS_HFLAG_DM) is\nset.\n\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Yongbok Kim <yongbok.kim@mips.com>\nSigned-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>\n---\n target/mips/helper.c | 4 +++-\n target/mips/op_helper.c | 12 +++++++++---\n 2 files changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/mips/helper.c b/target/mips/helper.c\nindex 8cf91ce..e215af9 100644\n--- a/target/mips/helper.c\n+++ b/target/mips/helper.c\n@@ -502,7 +502,9 @@ static void raise_mmu_exception(CPUMIPSState *env, target_ulong address,\n break;\n }\n /* Raise exception */\n- env->CP0_BadVAddr = address;\n+ if (!(env->hflags & MIPS_HFLAG_DM)) {\n+ env->CP0_BadVAddr = address;\n+ }\n env->CP0_Context = (env->CP0_Context & ~0x007fffff) |\n ((address >> 9) & 0x007ffff0);\n env->CP0_EntryHi = (env->CP0_EntryHi & env->CP0_EntryHi_ASID_mask) |\ndiff --git a/target/mips/op_helper.c b/target/mips/op_helper.c\nindex 41d3634..0b2663b 100644\n--- a/target/mips/op_helper.c\n+++ b/target/mips/op_helper.c\n@@ -271,7 +271,9 @@ static inline hwaddr do_translate_address(CPUMIPSState *env,\n target_ulong helper_##name(CPUMIPSState *env, target_ulong arg, int mem_idx) \\\n { \\\n if (arg & almask) { \\\n- env->CP0_BadVAddr = arg; \\\n+ if (!(env->hflags & MIPS_HFLAG_DM)) { \\\n+ env->CP0_BadVAddr = arg; \\\n+ } \\\n do_raise_exception(env, EXCP_AdEL, GETPC()); \\\n } \\\n env->lladdr = do_translate_address(env, arg, 0, GETPC()); \\\n@@ -291,7 +293,9 @@ target_ulong helper_##name(CPUMIPSState *env, target_ulong arg1, \\\n target_long tmp; \\\n \\\n if (arg2 & almask) { \\\n- env->CP0_BadVAddr = arg2; \\\n+ if (!(env->hflags & MIPS_HFLAG_DM)) { \\\n+ env->CP0_BadVAddr = arg2; \\\n+ } \\\n do_raise_exception(env, EXCP_AdES, GETPC()); \\\n } \\\n if (do_translate_address(env, arg2, 1, GETPC()) == env->lladdr) { \\\n@@ -2437,7 +2441,9 @@ void mips_cpu_do_unaligned_access(CPUState *cs, vaddr addr,\n int error_code = 0;\n int excp;\n \n- env->CP0_BadVAddr = addr;\n+ if (!(env->hflags & MIPS_HFLAG_DM)) {\n+ env->CP0_BadVAddr = addr;\n+ }\n \n if (access_type == MMU_DATA_STORE) {\n excp = EXCP_AdES;\n", "prefixes": [ "v7", "08/80" ] }