Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/952648/?format=api
{ "id": 952648, "url": "http://patchwork.ozlabs.org/api/patches/952648/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180802004036.89363-10-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180802004036.89363-10-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-08-02T00:40:33", "name": "[next,S94,10/13] i40e: Reinitialize interrupt scheme when going out of recovery mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7a434500fd22ec5e5d892050697148f82444a6a0", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180802004036.89363-10-alice.michael@intel.com/mbox/", "series": [ { "id": 58958, "url": "http://patchwork.ozlabs.org/api/series/58958/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=58958", "date": "2018-08-02T00:40:26", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/58958/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/952648/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/952648/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41h3nd5Rzlz9s2g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 2 Aug 2018 18:51:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 621CA87C89;\n\tThu, 2 Aug 2018 08:51:48 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SVPgKN3H9X2B; Thu, 2 Aug 2018 08:51:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E651187CAC;\n\tThu, 2 Aug 2018 08:51:43 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 606C21CF339\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Aug 2018 08:51:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2930E87C83\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Aug 2018 08:51:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ds2001049fWy for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Aug 2018 08:51:18 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 45C1687C94\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Aug 2018 08:51:18 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Aug 2018 01:51:18 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga002.fm.intel.com with ESMTP; 02 Aug 2018 01:51:18 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,434,1526367600\"; d=\"scan'208\";a=\"72695399\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 1 Aug 2018 17:40:33 -0700", "Message-Id": "<20180802004036.89363-10-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180802004036.89363-1-alice.michael@intel.com>", "References": "<20180802004036.89363-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S94 10/13] i40e: Reinitialize\n\tinterrupt scheme when going out of recovery mode", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Patryk Małek <patryk.malek@intel.com>\n\nWhen we go out of recovery mode (after a reset is triggerred) we have\nto free IRQ, clear and reinitialize the interrupt scheme to restore\nfull interrupt functionality.\n\nThis patch fixes a kernel panic in the event of driver being unloaded\nafter performing a recovery with nvmupdate - which was caused by calling\npci_disable_msi() while an interrupt was still registered in the system.\n\nSigned-off-by: Patryk Małek <patryk.malek@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 24 +++++++++++++++++++++---\n 1 file changed, 21 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex ca701e0..3b1740d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -45,6 +45,7 @@ static void i40e_prep_for_reset(struct i40e_pf *pf, bool lock_acquired);\n static int i40e_reset(struct i40e_pf *pf);\n static void i40e_rebuild(struct i40e_pf *pf, bool reinit, bool lock_acquired);\n static int i40e_setup_misc_vector_for_recovery_mode(struct i40e_pf *pf);\n+static int i40e_restore_interrupt_scheme(struct i40e_pf *pf);\n static bool i40e_check_recovery_mode(struct i40e_pf *pf);\n static int i40e_init_recovery_mode(struct i40e_pf *pf, struct i40e_hw *hw);\n static void i40e_fdir_sb_setup(struct i40e_pf *pf);\n@@ -9375,15 +9376,32 @@ static void i40e_rebuild(struct i40e_pf *pf, bool reinit, bool lock_acquired)\n \t\ti40e_verify_eeprom(pf);\n \t}\n \n+\t/* if we are going out of or into recovery mode we have to act\n+\t * accordingly with regard to resources initialization\n+\t * and deinitialization\n+\t */\n \tif (test_bit(__I40E_RECOVERY_MODE, pf->state) ||\n \t old_recovery_mode_bit) {\n \t\tif (i40e_get_capabilities(pf,\n \t\t\t\t\t i40e_aqc_opc_list_func_capabilities))\n \t\t\tgoto end_unlock;\n \n-\t\t/* reinit the misc interrupt */\n-\t\tif (i40e_setup_misc_vector_for_recovery_mode(pf))\n-\t\t\tgoto end_unlock;\n+\t\tif (test_bit(__I40E_RECOVERY_MODE, pf->state)) {\n+\t\t\t/* we're staying in recovery mode so we'll reinitialize\n+\t\t\t * misc vector here\n+\t\t\t */\n+\t\t\tif (i40e_setup_misc_vector_for_recovery_mode(pf))\n+\t\t\t\tgoto end_unlock;\n+\t\t} else {\n+\t\t\t/* we're going out of recovery mode so we'll free\n+\t\t\t * the IRQ allocated specifically for recovery mode\n+\t\t\t * and restore the interrupt scheme\n+\t\t\t */\n+\t\t\tfree_irq(pf->pdev->irq, pf);\n+\t\t\ti40e_clear_interrupt_scheme(pf);\n+\t\t\tif (i40e_restore_interrupt_scheme(pf))\n+\t\t\t\tgoto end_unlock;\n+\t\t}\n \n \t\t/* tell the firmware that we're starting */\n \t\ti40e_send_version(pf);\n", "prefixes": [ "next", "S94", "10/13" ] }