Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/951905/?format=api
{ "id": 951905, "url": "http://patchwork.ozlabs.org/api/patches/951905/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180801034729.3864-14-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180801034729.3864-14-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-08-01T03:47:29", "name": "[v3,13/13] ice: Change struct members from bool to u8", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "20c51c1857d3f5244e492c8f4b590d2f19b3ad04", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180801034729.3864-14-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 58671, "url": "http://patchwork.ozlabs.org/api/series/58671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=58671", "date": "2018-08-01T03:47:18", "name": "Bug fixes for ice", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/58671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/951905/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/951905/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41gK5T3YLFz9rxx\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 1 Aug 2018 13:47:57 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1D21A867AA;\n\tWed, 1 Aug 2018 03:47:56 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id F3ES0wOjIefj; Wed, 1 Aug 2018 03:47:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AD4FC86553;\n\tWed, 1 Aug 2018 03:47:54 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6EA891C0A9B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6C80B87C68\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7yqpnwGOJ8Q4 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:50 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 8C30387C45\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:50 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Jul 2018 20:47:50 -0700", "from lnahar-mobl.amr.corp.intel.com (HELO\n\tavenkata-mobl4.localdomain) ([10.252.134.1])\n\tby orsmga004.jf.intel.com with ESMTP; 31 Jul 2018 20:47:49 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,430,1526367600\"; d=\"scan'208\";a=\"220769267\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 31 Jul 2018 20:47:29 -0700", "Message-Id": "<20180801034729.3864-14-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180801034729.3864-1-anirudh.venkataramanan@intel.com>", "References": "<20180801034729.3864-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v3 13/13] ice: Change struct members from\n\tbool to u8", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bruce Allan <bruce.w.allan@intel.com>\n\nRecent versions of checkpatch have a new warning based on a documented\npreference of Linus to not use bool in structures due to wasted space and\nthe size of bool is implementation dependent. For more information, see\nthe email thread at https://lkml.org/lkml/2017/11/21/384.\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice.h | 8 ++++----\n drivers/net/ethernet/intel/ice/ice_switch.h | 6 +++---\n drivers/net/ethernet/intel/ice/ice_txrx.h | 2 +-\n drivers/net/ethernet/intel/ice/ice_type.h | 16 ++++++++--------\n 4 files changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h\nindex ed071ea75f20..868f4a1d0f72 100644\n--- a/drivers/net/ethernet/intel/ice/ice.h\n+++ b/drivers/net/ethernet/intel/ice/ice.h\n@@ -196,9 +196,9 @@ struct ice_vsi {\n \tstruct list_head tmp_sync_list;\t\t/* MAC filters to be synced */\n \tstruct list_head tmp_unsync_list;\t/* MAC filters to be unsynced */\n \n-\tbool irqs_ready;\n-\tbool current_isup;\t\t /* Sync 'link up' logging */\n-\tbool stat_offsets_loaded;\n+\tu8 irqs_ready;\n+\tu8 current_isup;\t\t /* Sync 'link up' logging */\n+\tu8 stat_offsets_loaded;\n \n \t/* queue information */\n \tu8 tx_mapping_mode;\t\t /* ICE_MAP_MODE_[CONTIG|SCATTER] */\n@@ -269,7 +269,7 @@ struct ice_pf {\n \tstruct ice_hw_port_stats stats;\n \tstruct ice_hw_port_stats stats_prev;\n \tstruct ice_hw hw;\n-\tbool stat_prev_loaded;\t/* has previous stats been loaded */\n+\tu8 stat_prev_loaded;\t/* has previous stats been loaded */\n \tchar int_name[ICE_INT_NAME_STR_LEN];\n };\n \ndiff --git a/drivers/net/ethernet/intel/ice/ice_switch.h b/drivers/net/ethernet/intel/ice/ice_switch.h\nindex 6f4a0d159dbf..9b8ec128ee31 100644\n--- a/drivers/net/ethernet/intel/ice/ice_switch.h\n+++ b/drivers/net/ethernet/intel/ice/ice_switch.h\n@@ -17,7 +17,7 @@ struct ice_vsi_ctx {\n \tu16 vsis_unallocated;\n \tu16 flags;\n \tstruct ice_aqc_vsi_props info;\n-\tbool alloc_from_pool;\n+\tu8 alloc_from_pool;\n };\n \n enum ice_sw_fwd_act_type {\n@@ -94,8 +94,8 @@ struct ice_fltr_info {\n \tu8 qgrp_size;\n \n \t/* Rule creations populate these indicators basing on the switch type */\n-\tbool lb_en;\t/* Indicate if packet can be looped back */\n-\tbool lan_en;\t/* Indicate if packet can be forwarded to the uplink */\n+\tu8 lb_en;\t/* Indicate if packet can be looped back */\n+\tu8 lan_en;\t/* Indicate if packet can be forwarded to the uplink */\n };\n \n /* Bookkeeping structure to hold bitmap of VSIs corresponding to VSI list id */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_txrx.h b/drivers/net/ethernet/intel/ice/ice_txrx.h\nindex 567067b650c4..31bc998fe200 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx.h\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx.h\n@@ -143,7 +143,7 @@ struct ice_ring {\n \tu16 next_to_use;\n \tu16 next_to_clean;\n \n-\tbool ring_active;\t\t/* is ring online or not */\n+\tu8 ring_active;\t\t\t/* is ring online or not */\n \n \t/* stats structs */\n \tstruct ice_q_stats\tstats;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h\nindex 99c8a9a71b5e..97c366e0ca59 100644\n--- a/drivers/net/ethernet/intel/ice/ice_type.h\n+++ b/drivers/net/ethernet/intel/ice/ice_type.h\n@@ -83,7 +83,7 @@ struct ice_link_status {\n \tu64 phy_type_low;\n \tu16 max_frame_size;\n \tu16 link_speed;\n-\tbool lse_ena;\t/* Link Status Event notification */\n+\tu8 lse_ena;\t/* Link Status Event notification */\n \tu8 link_info;\n \tu8 an_info;\n \tu8 ext_info;\n@@ -101,7 +101,7 @@ struct ice_phy_info {\n \tstruct ice_link_status link_info_old;\n \tu64 phy_type_low;\n \tenum ice_media_type media_type;\n-\tbool get_link_info;\n+\tu8 get_link_info;\n };\n \n /* Common HW capabilities for SW use */\n@@ -167,7 +167,7 @@ struct ice_nvm_info {\n \tu32 oem_ver; /* OEM version info */\n \tu16 sr_words; /* Shadow RAM size in words */\n \tu16 ver; /* NVM package version */\n-\tbool blank_nvm_mode; /* is NVM empty (no FW present) */\n+\tu8 blank_nvm_mode; /* is NVM empty (no FW present) */\n };\n \n /* Max number of port to queue branches w.r.t topology */\n@@ -181,7 +181,7 @@ struct ice_sched_node {\n \tstruct ice_aqc_txsched_elem_data info;\n \tu32 agg_id;\t\t\t/* aggregator group id */\n \tu16 vsi_id;\n-\tbool in_use;\t\t\t/* suspended or in use */\n+\tu8 in_use;\t\t\t/* suspended or in use */\n \tu8 tx_sched_layer;\t\t/* Logical Layer (1-9) */\n \tu8 num_children;\n \tu8 tc_num;\n@@ -218,7 +218,7 @@ struct ice_sched_vsi_info {\n struct ice_sched_tx_policy {\n \tu16 max_num_vsis;\n \tu8 max_num_lan_qs_per_tc[ICE_MAX_TRAFFIC_CLASS];\n-\tbool rdma_ena;\n+\tu8 rdma_ena;\n };\n \n struct ice_port_info {\n@@ -243,7 +243,7 @@ struct ice_port_info {\n \tstruct list_head agg_list;\t/* lists all aggregator */\n \tu8 lport;\n #define ICE_LPORT_MASK\t\t0xff\n-\tbool is_vf;\n+\tu8 is_vf;\n };\n \n struct ice_switch_info {\n@@ -287,7 +287,7 @@ struct ice_hw {\n \tu8 max_cgds;\n \tu8 sw_entry_point_layer;\n \n-\tbool evb_veb;\t\t/* true for VEB, false for VEPA */\n+\tu8 evb_veb;\t\t/* true for VEB, false for VEPA */\n \tstruct ice_bus_info bus;\n \tstruct ice_nvm_info nvm;\n \tstruct ice_hw_dev_caps dev_caps;\t/* device capabilities */\n@@ -318,7 +318,7 @@ struct ice_hw {\n \tu8 itr_gran_100;\n \tu8 itr_gran_50;\n \tu8 itr_gran_25;\n-\tbool ucast_shared;\t/* true if VSIs can share unicast addr */\n+\tu8 ucast_shared;\t/* true if VSIs can share unicast addr */\n \n };\n \n", "prefixes": [ "v3", "13/13" ] }