Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/951899/?format=api
{ "id": 951899, "url": "http://patchwork.ozlabs.org/api/patches/951899/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180801034729.3864-8-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180801034729.3864-8-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-08-01T03:47:23", "name": "[v3,07/13] ice: Use order_base_2 to calculate higher power of 2", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3e976744b5981a92d7b9a7e33f2cb36dd2df98ba", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180801034729.3864-8-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 58671, "url": "http://patchwork.ozlabs.org/api/series/58671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=58671", "date": "2018-08-01T03:47:18", "name": "Bug fixes for ice", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/58671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/951899/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/951899/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41gK5H21p8z9s4V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 1 Aug 2018 13:47:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E2E9825B04;\n\tWed, 1 Aug 2018 03:47:45 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yqFftowBP83m; Wed, 1 Aug 2018 03:47:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3544725BF8;\n\tWed, 1 Aug 2018 03:47:45 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1DA851C0A9B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1B6B387C68\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id I-kbbYgzEgeJ for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:43 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 7F38D87C46\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:43 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Jul 2018 20:47:43 -0700", "from lnahar-mobl.amr.corp.intel.com (HELO\n\tavenkata-mobl4.localdomain) ([10.252.134.1])\n\tby orsmga004.jf.intel.com with ESMTP; 31 Jul 2018 20:47:42 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,430,1526367600\"; d=\"scan'208\";a=\"220769248\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 31 Jul 2018 20:47:23 -0700", "Message-Id": "<20180801034729.3864-8-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180801034729.3864-1-anirudh.venkataramanan@intel.com>", "References": "<20180801034729.3864-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v3 07/13] ice: Use order_base_2 to\n\tcalculate higher power of 2", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nCurrently, we use a combination of ilog2 and is_power_of_2() to\ncalculate the next power of 2 for the qcount. This appears to be causing\na warning on some combinations of GCC and the Linux kernel:\n\nMODPOST 1 modules\nWARNING: \"____ilog2_NaN\" [ice.ko] undefined!\n\nThis appears to because because GCC realizes that qcount could be zero\nin some circumstances and thus attempts to link against the\nintentionally undefined ___ilog2_NaN function.\n\nThe order_base_2 function is intentionally defined to return 0 when\npassed 0 as an argument, and thus will be safe to use here.\n\nThis not only fixes the warning but makes the resulting code slightly\ncleaner, and is really what we should have used originally.\n\nAlso update the comment to make it more clear that we are rounding up,\nnot just incrementing the ilog2 of qcount unconditionally.\n\nWithout this patch, we get warnings when building against the upstream\nkernel.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n[Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> minor cleanup for upstream submission]\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex a1524cbb15b1..d4f1f92faf65 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1313,11 +1313,8 @@ static void ice_vsi_setup_q_map(struct ice_vsi *vsi, struct ice_vsi_ctx *ctxt)\n \t\tqcount = numq_tc;\n \t}\n \n-\t/* find higher power-of-2 of qcount */\n-\tpow = ilog2(qcount);\n-\n-\tif (!is_power_of_2(qcount))\n-\t\tpow++;\n+\t/* find the (rounded up) power-of-2 of qcount */\n+\tpow = order_base_2(qcount);\n \n \tfor (i = 0; i < ICE_MAX_TRAFFIC_CLASS; i++) {\n \t\tif (!(vsi->tc_cfg.ena_tc & BIT(i))) {\n", "prefixes": [ "v3", "07/13" ] }