Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/951897/?format=api
{ "id": 951897, "url": "http://patchwork.ozlabs.org/api/patches/951897/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180801034729.3864-6-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180801034729.3864-6-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-08-01T03:47:21", "name": "[v3,05/13] ice: Clean control queues only when they are initialized", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ad4fbfae6a3a52c76b1ca9da04d5f98f028d5044", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180801034729.3864-6-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 58671, "url": "http://patchwork.ozlabs.org/api/series/58671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=58671", "date": "2018-08-01T03:47:18", "name": "Bug fixes for ice", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/58671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/951897/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/951897/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41gK5H0Typz9rxx\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 1 Aug 2018 13:47:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 37F8F867A6;\n\tWed, 1 Aug 2018 03:47:45 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CuKfgvjjFRnh; Wed, 1 Aug 2018 03:47:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BBD8086519;\n\tWed, 1 Aug 2018 03:47:44 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7D81D1C0A9B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7B1F787C45\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:41 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LtcbCKNTjUDc for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:41 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 12D4287C41\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Aug 2018 03:47:41 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Jul 2018 20:47:40 -0700", "from lnahar-mobl.amr.corp.intel.com (HELO\n\tavenkata-mobl4.localdomain) ([10.252.134.1])\n\tby orsmga004.jf.intel.com with ESMTP; 31 Jul 2018 20:47:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,430,1526367600\"; d=\"scan'208\";a=\"220769244\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 31 Jul 2018 20:47:21 -0700", "Message-Id": "<20180801034729.3864-6-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180801034729.3864-1-anirudh.venkataramanan@intel.com>", "References": "<20180801034729.3864-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v3 05/13] ice: Clean control queues only\n\twhen they are initialized", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Preethi Banala <preethi.banala@intel.com>\n\nClean control queues only when they are initialized. One of the ways to\nvalidate if the basic initialization is done is by checking value of\ncq->sq.head and cq->rq.head variables that specify the register address.\nThis patch adds a check to avoid NULL pointer dereference crash when tried\nto shutdown uninitialized control queue.\n\nSigned-off-by: Preethi Banala <preethi.banala@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_controlq.c | 24 ++++++++++++-------\n 1 file changed, 16 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_controlq.c b/drivers/net/ethernet/intel/ice/ice_controlq.c\nindex 7c511f144ed6..c064416080e7 100644\n--- a/drivers/net/ethernet/intel/ice/ice_controlq.c\n+++ b/drivers/net/ethernet/intel/ice/ice_controlq.c\n@@ -597,10 +597,14 @@ static enum ice_status ice_init_check_adminq(struct ice_hw *hw)\n \treturn 0;\n \n init_ctrlq_free_rq:\n-\tice_shutdown_rq(hw, cq);\n-\tice_shutdown_sq(hw, cq);\n-\tmutex_destroy(&cq->sq_lock);\n-\tmutex_destroy(&cq->rq_lock);\n+\tif (cq->rq.head) {\n+\t\tice_shutdown_rq(hw, cq);\n+\t\tmutex_destroy(&cq->rq_lock);\n+\t}\n+\tif (cq->sq.head) {\n+\t\tice_shutdown_sq(hw, cq);\n+\t\tmutex_destroy(&cq->sq_lock);\n+\t}\n \treturn status;\n }\n \n@@ -706,10 +710,14 @@ static void ice_shutdown_ctrlq(struct ice_hw *hw, enum ice_ctl_q q_type)\n \t\treturn;\n \t}\n \n-\tice_shutdown_sq(hw, cq);\n-\tice_shutdown_rq(hw, cq);\n-\tmutex_destroy(&cq->sq_lock);\n-\tmutex_destroy(&cq->rq_lock);\n+\tif (cq->sq.head) {\n+\t\tice_shutdown_sq(hw, cq);\n+\t\tmutex_destroy(&cq->sq_lock);\n+\t}\n+\tif (cq->rq.head) {\n+\t\tice_shutdown_rq(hw, cq);\n+\t\tmutex_destroy(&cq->rq_lock);\n+\t}\n }\n \n /**\n", "prefixes": [ "v3", "05/13" ] }