Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/951746/?format=api
{ "id": 951746, "url": "http://patchwork.ozlabs.org/api/patches/951746/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180731104148.11896-8-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180731104148.11896-8-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-07-31T10:41:45", "name": "[next,S93,08/11] i40e: fix warning about shadowed ring parameter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4ec46e1ec3afbd0a99120ce942ba88e3f5f02e4a", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180731104148.11896-8-alice.michael@intel.com/mbox/", "series": [ { "id": 58617, "url": "http://patchwork.ozlabs.org/api/series/58617/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=58617", "date": "2018-07-31T10:41:48", "name": "[next,S93,01/11] i40e: add helper function for copying strings from stat arrays", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/58617/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/951746/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/951746/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41g5Cl3n2Kz9s0R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 1 Aug 2018 04:52:35 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 21AA985BBA;\n\tTue, 31 Jul 2018 18:52:34 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iB+F35Y7JGHz; Tue, 31 Jul 2018 18:52:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 01DE585E54;\n\tTue, 31 Jul 2018 18:52:30 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 353CE1C3E95\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 31 Jul 2018 18:52:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 317E285C04\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 31 Jul 2018 18:52:29 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id w0XjFAVNQ6w2 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 31 Jul 2018 18:52:28 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id CABDE85B62\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 31 Jul 2018 18:52:28 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Jul 2018 11:52:27 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga008.jf.intel.com with ESMTP; 31 Jul 2018 11:52:27 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,428,1526367600\"; d=\"scan'208\";a=\"61310085\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 31 Jul 2018 03:41:45 -0700", "Message-Id": "<20180731104148.11896-8-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180731104148.11896-1-alice.michael@intel.com>", "References": "<20180731104148.11896-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S93 08/11] i40e: fix warning about\n\tshadowed ring parameter", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nIn commit 147e81ec7568 (\"i40e: Test memory before ethtool alloc succeeds\")\ncode was added to handle ring allocation on systems with low memory.\n\nIt shadowed the ring parameter pointer by introducing a local ring\npointer inside the for loop. Most of the code in the loop already just\naccessed the ring via &rx_rings[i]. Since most of the code already does\nthis, just remove the local variable.\n\nIf someone considers it worth keeping a local around, they should use it\nfor the whole section instead of just a couple of accesses.\n\nThis fixes a warning when -Wshadow is enabled\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 12d279a..cd23d1e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1589,7 +1589,6 @@ static int i40e_set_ringparam(struct net_device *netdev,\n \t\t}\n \n \t\tfor (i = 0; i < vsi->num_queue_pairs; i++) {\n-\t\t\tstruct i40e_ring *ring;\n \t\t\tu16 unused;\n \n \t\t\t/* clone ring and setup updated count */\n@@ -1613,9 +1612,8 @@ static int i40e_set_ringparam(struct net_device *netdev,\n \t\t\t/* now allocate the Rx buffers to make sure the OS\n \t\t\t * has enough memory, any failure here means abort\n \t\t\t */\n-\t\t\tring = &rx_rings[i];\n-\t\t\tunused = I40E_DESC_UNUSED(ring);\n-\t\t\terr = i40e_alloc_rx_buffers(ring, unused);\n+\t\t\tunused = I40E_DESC_UNUSED(&rx_rings[i]);\n+\t\t\terr = i40e_alloc_rx_buffers(&rx_rings[i], unused);\n rx_unwind:\n \t\t\tif (err) {\n \t\t\t\tdo {\n", "prefixes": [ "next", "S93", "08/11" ] }