Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/950034/?format=api
{ "id": 950034, "url": "http://patchwork.ozlabs.org/api/patches/950034/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180727080738.3301-1-baijiaju1990@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180727080738.3301-1-baijiaju1990@gmail.com>", "list_archive_url": null, "date": "2018-07-27T08:07:38", "name": "net: intel: igb: Replace mdelay() with msleep() in igb_integrated_phy_loopback()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c2548f08b6243431dc070efa8e973ba94f9c52e3", "submitter": { "id": 73020, "url": "http://patchwork.ozlabs.org/api/people/73020/?format=api", "name": "Jia-Ju Bai", "email": "baijiaju1990@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180727080738.3301-1-baijiaju1990@gmail.com/mbox/", "series": [ { "id": 57904, "url": "http://patchwork.ozlabs.org/api/series/57904/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=57904", "date": "2018-07-27T08:07:38", "name": "net: intel: igb: Replace mdelay() with msleep() in igb_integrated_phy_loopback()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/57904/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/950034/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/950034/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BRKwQmiI\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41cM5d73Lbz9s0R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 27 Jul 2018 18:07:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8BF488799A;\n\tFri, 27 Jul 2018 08:07:48 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id j6FcecK31JXs; Fri, 27 Jul 2018 08:07:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1C9C187A11;\n\tFri, 27 Jul 2018 08:07:48 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 308901C2AD7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 08:07:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2D59B88CFB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 08:07:47 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id r9mNzPWbaKam for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 08:07:46 +0000 (UTC)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C900C88CF2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 08:07:46 +0000 (UTC)", "by mail-pg1-f196.google.com with SMTP id s7-v6so2785394pgv.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 01:07:46 -0700 (PDT)", "from localhost.localdomain ([2402:f000:1:4414:6c14:7712:e625:1be4])\n\tby smtp.gmail.com with ESMTPSA id\n\tl27-v6sm6302873pfi.180.2018.07.27.01.07.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 27 Jul 2018 01:07:46 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=qzVHO/6sRR1GOrx8CgUKWp1sL45+HfcyKN9jRLMtR+Y=;\n\tb=BRKwQmiIpymZ+OesLXnursMQJlKSI0gJC1SFJRjNiNiSpDvFOGLw/wAhbJTSazeXcS\n\tfCaYjRznAW00hZ/6yjvdoCCzNkHa6V1C9vN4uzoaYProX72rF3yIG+81pRxWeVeSmYF4\n\tPiDuwYPflwbvzAYQ4Q9x5lkPDR61iI/KAIGs9WMt6X/P8Asbpw0DN0gEOPkBXoC6wx27\n\t4fFsHLzyglOoDyhKd3njiau0bTzdNMwIE4dXdXM9Gp729PfizshmFXC+UDmJuZ8/CuCn\n\t2pzmGjXnvKhdNciGcfeRpCIl242v5j372tbS8M7aEzrbBitX6FusSZ8s9XB1H8F/BE3S\n\t+ldg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=qzVHO/6sRR1GOrx8CgUKWp1sL45+HfcyKN9jRLMtR+Y=;\n\tb=Bzz2+GPWKuiqithS0rOim02ldqxGgnjYf3IZ+JRYFvU76b56JEl0kfpi9zLBjQwm5Y\n\tKW05B9tT0+eWqMvc7WixoLa8bX5hUBj+E/10Vtc9eIrdV4sSzR1hQmUOb5nVKmO+N8Sy\n\txy34H7ZpHuw14++NX7rR4ncgIEKTCf63z/d+U52RxCTE1aqhOIwVxBwtveKrHJyWEeI6\n\tAA9PBmTVzDB8AYXZOggJpjSFIt+zfQOdiRB5YrKijYG+oziRABaKnIqhc9iAz9G8lKPA\n\ttdCnFe0B1Vzq8VdB7q9MDte5q6ybAUix8vSYnPT+dn2j6BQv1N03ZARxJhvgBTkSc442\n\tfxmw==", "X-Gm-Message-State": "AOUpUlFP/EZZuYfM7tErsHKcV+LEbVH7NFsbFjgMyohGhXl8956mY0EB\n\tlrLSRWvg0Z7pGDtYzn3+auA=", "X-Google-Smtp-Source": "AAOMgpd2T4kwj3lkyyl5TGoXT7oyljRiAzOA6aQkeWvFaabIhFY72fLT5t4K4hPIqopSR4FWdBfiYg==", "X-Received": "by 2002:a63:e116:: with SMTP id\n\tz22-v6mr4904421pgh.89.1532678866556; \n\tFri, 27 Jul 2018 01:07:46 -0700 (PDT)", "From": "Jia-Ju Bai <baijiaju1990@gmail.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Fri, 27 Jul 2018 16:07:38 +0800", "Message-Id": "<20180727080738.3301-1-baijiaju1990@gmail.com>", "X-Mailer": "git-send-email 2.17.0", "Subject": "[Intel-wired-lan] [PATCH] net: intel: igb: Replace mdelay() with\n\tmsleep() in igb_integrated_phy_loopback()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Jia-Ju Bai <baijiaju1990@gmail.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "igb_integrated_phy_loopback() is never called in atomic context.\nIt calls mdelay() to busily wait, which is not necessary.\nmdelay() can be replaced with msleep().\n\nThis is found by a static analysis tool named DCNS written by myself.\n\nSigned-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>\n---\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex e77ba0d5866d..4e64c9a6f1b6 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -1670,7 +1670,7 @@ static int igb_integrated_phy_loopback(struct igb_adapter *adapter)\n \tif (hw->phy.type == e1000_phy_m88)\n \t\tigb_phy_disable_receiver(adapter);\n \n-\tmdelay(500);\n+\tmsleep(500);\n \treturn 0;\n }\n \n", "prefixes": [] }