Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/950033/?format=api
{ "id": 950033, "url": "http://patchwork.ozlabs.org/api/patches/950033/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180727080453.3198-1-baijiaju1990@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180727080453.3198-1-baijiaju1990@gmail.com>", "list_archive_url": null, "date": "2018-07-27T08:04:53", "name": "[1/2] net: intel: igb: Replace GFP_ATOMIC with GFP_KERNEL in igb_sw_init()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2c639d64ac355c110afcb64245e95185fb771b9b", "submitter": { "id": 73020, "url": "http://patchwork.ozlabs.org/api/people/73020/?format=api", "name": "Jia-Ju Bai", "email": "baijiaju1990@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180727080453.3198-1-baijiaju1990@gmail.com/mbox/", "series": [ { "id": 57903, "url": "http://patchwork.ozlabs.org/api/series/57903/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=57903", "date": "2018-07-27T08:04:53", "name": "[1/2] net: intel: igb: Replace GFP_ATOMIC with GFP_KERNEL in igb_sw_init()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/57903/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/950033/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/950033/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"obFskZWg\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41cM2X2TNbz9s0n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 27 Jul 2018 18:05:06 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0626C88722;\n\tFri, 27 Jul 2018 08:05:04 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JWvLaKz7vzNl; Fri, 27 Jul 2018 08:05:03 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 64FAD88713;\n\tFri, 27 Jul 2018 08:05:03 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id BEB6F1C2AD7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 08:05:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B833488CFF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 08:05:01 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FqW2XI4SzXEb for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 08:05:01 +0000 (UTC)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 6CE0388CF2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 08:05:01 +0000 (UTC)", "by mail-pf1-f194.google.com with SMTP id k21-v6so1472328pff.11\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 27 Jul 2018 01:05:01 -0700 (PDT)", "from localhost.localdomain ([2402:f000:1:4414:6c14:7712:e625:1be4])\n\tby smtp.gmail.com with ESMTPSA id\n\tx24-v6sm5254978pfh.67.2018.07.27.01.04.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 27 Jul 2018 01:05:00 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=xO8+QcS/sypcgqi50Iq0IApJl+12RbGbr6B6n84+oh0=;\n\tb=obFskZWgZgCKI3cJfcA9T3XrCEHvk43AGXpzEifmIAo9m+LW/nh2EYtegacwAFn8d1\n\tptGd2WthkQ0HHiDEADfW26grTyVTRyrRIpttEbWpj2VqdCIXMc8geiyEVJALKwqsUMOh\n\tpwObEXu2+3NBamSXuj27EM3Uihq8mfc3qoaFfSz5Nx+AugEm4QneCjfGwVRcAusPWO28\n\txxF1qtibxWW6wEFapG7KDqX4egfprvfOx1sNZDOS5xAqit+HfkaY9KLGVq6ADOVsU/3S\n\tzr62ZJfFUJUuX3OBbdajbc7JaMbrlSdRJyYobSHGNEzrldt6dOzg4PdqWzimt/Ps7ST8\n\tptPg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=xO8+QcS/sypcgqi50Iq0IApJl+12RbGbr6B6n84+oh0=;\n\tb=EV+rOcd90jztAdteXoNVRc1C+MWBWO/X4cmuKPIpMDj8js4kEGgWHpS+kWy53pTgsl\n\tsOA39nSxPyMbu8OZgX3/gON3i+VKk7zfNklAUh0RviMSPJwQAxAGM6kDdLwoGhvhCm14\n\tCHqX6M8JWwSDqzQV2uxKqlATisekpuQmK3QkshIEnX8FSP70x2yWPExv0jiMA7MGyTMI\n\tJ8ChM0JR03+++8Ib5B3kTuO4vfCmacJpj4iL7bE+0s0l6WKe/qoqz85SawW4ohN8XTCo\n\tV734t74jR3HJY0w4gQ6ZdO8S2IKhLNPnXsL3FYamqkcR2SWC39k7yxPTS4idqap9AGeO\n\t8hfA==", "X-Gm-Message-State": "AOUpUlG6T9O9gGW9h8Z398vsB+RZS6TWdJuelQ8Lr/biv2Hw6K5WoclV\n\tuyNXke6Iu4PzNDfjFQo5mMg=", "X-Google-Smtp-Source": "AAOMgpc1njOMZg0VfBtiDGC4BHqFU87rrLqr6EIVtUtxbIL0hSq1NLGWhOvIb5P+MCJcfCFqKWQg3w==", "X-Received": "by 2002:a62:229a:: with SMTP id\n\tp26-v6mr5590454pfj.53.1532678701099; \n\tFri, 27 Jul 2018 01:05:01 -0700 (PDT)", "From": "Jia-Ju Bai <baijiaju1990@gmail.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Fri, 27 Jul 2018 16:04:53 +0800", "Message-Id": "<20180727080453.3198-1-baijiaju1990@gmail.com>", "X-Mailer": "git-send-email 2.17.0", "Subject": "[Intel-wired-lan] [PATCH 1/2] net: intel: igb: Replace GFP_ATOMIC\n\twith GFP_KERNEL in igb_sw_init()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Jia-Ju Bai <baijiaju1990@gmail.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "igb_sw_init() is never called in atomic context.\nIt calls kzalloc() and kcalloc() with GFP_ATOMIC, which is not necessary.\nGFP_ATOMIC can be replaced with GFP_KERNEL.\n\nThis is found by a static analysis tool named DCNS written by myself.\n\nSigned-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex cce7ada89255..5332a1b608e6 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -3534,7 +3534,7 @@ static int igb_sw_init(struct igb_adapter *adapter)\n \tadapter->flags |= IGB_FLAG_HAS_MSIX;\n \n \tadapter->mac_table = kzalloc(sizeof(struct igb_mac_addr) *\n-\t\t\t\t hw->mac.rar_entry_count, GFP_ATOMIC);\n+\t\t\t\t hw->mac.rar_entry_count, GFP_KERNEL);\n \tif (!adapter->mac_table)\n \t\treturn -ENOMEM;\n \n@@ -3544,7 +3544,7 @@ static int igb_sw_init(struct igb_adapter *adapter)\n \n \t/* Setup and initialize a copy of the hw vlan table array */\n \tadapter->shadow_vfta = kcalloc(E1000_VLAN_FILTER_TBL_SIZE, sizeof(u32),\n-\t\t\t\t GFP_ATOMIC);\n+\t\t\t\t GFP_KERNEL);\n \tif (!adapter->shadow_vfta)\n \t\treturn -ENOMEM;\n \n", "prefixes": [ "1/2" ] }