Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/947893/?format=api
{ "id": 947893, "url": "http://patchwork.ozlabs.org/api/patches/947893/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180723173752.19676-2-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180723173752.19676-2-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-07-23T17:37:40", "name": "[01/13] ice: Fix static analyser warning", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "d8c4699179c592b9a1e540a686747a728d918b64", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180723173752.19676-2-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 57101, "url": "http://patchwork.ozlabs.org/api/series/57101/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=57101", "date": "2018-07-23T17:37:39", "name": "Bug fixes for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/57101/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/947893/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/947893/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41Z7xX6pm7z9s7X\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 24 Jul 2018 03:38:08 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 682DB248DF;\n\tMon, 23 Jul 2018 17:38:07 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WPwk9MGusuAd; Mon, 23 Jul 2018 17:38:03 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E57DA24BB3;\n\tMon, 23 Jul 2018 17:38:03 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BBEDE1C05B5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 17:38:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B9B808732C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 17:38:02 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id t4lwWmWqLAuo for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 17:38:02 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 49EBC87326\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 17:38:02 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jul 2018 10:38:00 -0700", "from shasta.jf.intel.com ([10.166.241.10])\n\tby fmsmga001.fm.intel.com with ESMTP; 23 Jul 2018 10:37:52 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,394,1526367600\"; d=\"scan'208\";a=\"74790713\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 23 Jul 2018 10:37:40 -0700", "Message-Id": "<20180723173752.19676-2-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20180723173752.19676-1-anirudh.venkataramanan@intel.com>", "References": "<20180723173752.19676-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 01/13] ice: Fix static analyser warning", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch fixes one of the smatch (a static analysis tool) warnings\nreported by Dan Carpenter. ICE_LG_ACT_GENERIC_OFFSET_M is the right mask\nto use but it appears that ICE_LG_ACT_GENERIC_VALUE_M was used instead,\nwhich resulted in the following smatch warning:\n\nice_add_marker_act() warn: odd binop '0x380000 & 0x7fff8'\n\nAdditionally, use a new define ICE_LG_ACT_GENERIC_OFF_RX_DESC_PROF_IDX\ninstead of magic number '7'.\n\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 1 +\n drivers/net/ethernet/intel/ice/ice_switch.c | 3 ++-\n 2 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\nindex 7541ec2270b3..6d3e11659ba5 100644\n--- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n+++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n@@ -594,6 +594,7 @@ struct ice_sw_rule_lg_act {\n #define ICE_LG_ACT_GENERIC_OFFSET_M\t(0x7 << ICE_LG_ACT_GENERIC_OFFSET_S)\n #define ICE_LG_ACT_GENERIC_PRIORITY_S\t22\n #define ICE_LG_ACT_GENERIC_PRIORITY_M\t(0x7 << ICE_LG_ACT_GENERIC_PRIORITY_S)\n+#define ICE_LG_ACT_GENERIC_OFF_RX_DESC_PROF_IDX\t7\n \n \t/* Action = 7 - Set Stat count */\n #define ICE_LG_ACT_STAT_COUNT\t\t0x7\ndiff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c\nindex 723d15f1e90b..750d2051a976 100644\n--- a/drivers/net/ethernet/intel/ice/ice_switch.c\n+++ b/drivers/net/ethernet/intel/ice/ice_switch.c\n@@ -645,7 +645,8 @@ ice_add_marker_act(struct ice_hw *hw, struct ice_fltr_mgmt_list_entry *m_ent,\n \tact |= (1 << ICE_LG_ACT_GENERIC_VALUE_S) & ICE_LG_ACT_GENERIC_VALUE_M;\n \tlg_act->pdata.lg_act.act[1] = cpu_to_le32(act);\n \n-\tact = (7 << ICE_LG_ACT_GENERIC_OFFSET_S) & ICE_LG_ACT_GENERIC_VALUE_M;\n+\tact = (ICE_LG_ACT_GENERIC_OFF_RX_DESC_PROF_IDX <<\n+\t ICE_LG_ACT_GENERIC_OFFSET_S) & ICE_LG_ACT_GENERIC_OFFSET_M;\n \n \t/* Third action Marker value */\n \tact |= ICE_LG_ACT_GENERIC;\n", "prefixes": [ "01/13" ] }