Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/947887/?format=api
{ "id": 947887, "url": "http://patchwork.ozlabs.org/api/patches/947887/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180723173752.19676-9-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180723173752.19676-9-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-07-23T17:37:47", "name": "[08/13] ice: Don't explicitly set port_vlan_bits to 0", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "41bb071177cba3113aae00657c03055c9d109e87", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180723173752.19676-9-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 57101, "url": "http://patchwork.ozlabs.org/api/series/57101/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=57101", "date": "2018-07-23T17:37:39", "name": "Bug fixes for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/57101/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/947887/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/947887/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41Z7xT747Xz9s3q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 24 Jul 2018 03:38:05 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2F3F587326;\n\tMon, 23 Jul 2018 17:38:04 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fzySQQZzOzb6; Mon, 23 Jul 2018 17:38:03 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EE09B87335;\n\tMon, 23 Jul 2018 17:38:02 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 256801CF309\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 17:38:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 21F5624BE9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 17:38:02 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Q36qSIxI4vz2 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 17:38:01 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 7247E24B96\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 17:38:01 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jul 2018 10:38:00 -0700", "from shasta.jf.intel.com ([10.166.241.10])\n\tby fmsmga001.fm.intel.com with ESMTP; 23 Jul 2018 10:37:52 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,394,1526367600\"; d=\"scan'208\";a=\"74790720\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 23 Jul 2018 10:37:47 -0700", "Message-Id": "<20180723173752.19676-9-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20180723173752.19676-1-anirudh.venkataramanan@intel.com>", "References": "<20180723173752.19676-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 08/13] ice: Don't explicitly set\n\tport_vlan_bits to 0", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nThis patch fixes the following smatch warning originally reported by\nDan Carpenter:\nice_set_dflt_vsi_ctx() warn: odd binop '0x0 & 0x18'\n\nIn ice_set_dflt_vsi_ctx() we are currently doing logic that is intended\nto explicitly clear bits 3 and 4 for port_vlan_flags. Clearing these\nbits results in legacy behavior (showing VLAN, DEI, and UP) in the\ndescriptors. The issue was this was reporting the Smatch error shown\nbelow. To fix this remove this logic because the port_vlan_flags field\nis set to 0 initially by memset so by default we have the correct legacy\nbehavior for bits 3 and 4. A comment was added above where we set\nport_vlan_flags in ice_set_dflt_vsi_ctx() to note that this is the\ndesired behavior.\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\n[Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> cleaned up commit message]\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex feeca75912ec..586c6e615a98 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1367,14 +1367,13 @@ static void ice_set_dflt_vsi_ctx(struct ice_vsi_ctx *ctxt)\n \tctxt->info.sw_flags = ICE_AQ_VSI_SW_FLAG_SRC_PRUNE;\n \t/* Traffic from VSI can be sent to LAN */\n \tctxt->info.sw_flags2 = ICE_AQ_VSI_SW_FLAG_LAN_ENA;\n-\t/* Allow all packets untagged/tagged */\n+\t/* By default bits 3 and 4 in port_vlan_flags are 0's which results in\n+\t * legacy behavior (show VLAN, DEI, and UP) in descriptor. Also, allow\n+\t * all packets untagged/tagged.\n+\t */\n \tctxt->info.port_vlan_flags = ((ICE_AQ_VSI_PVLAN_MODE_ALL &\n \t\t\t\t ICE_AQ_VSI_PVLAN_MODE_M) >>\n \t\t\t\t ICE_AQ_VSI_PVLAN_MODE_S);\n-\t/* Show VLAN/UP from packets in Rx descriptors */\n-\tctxt->info.port_vlan_flags |= ((ICE_AQ_VSI_PVLAN_EMOD_STR_BOTH &\n-\t\t\t\t\tICE_AQ_VSI_PVLAN_EMOD_M) >>\n-\t\t\t\t ICE_AQ_VSI_PVLAN_EMOD_S);\n \t/* Have 1:1 UP mapping for both ingress/egress tables */\n \ttable |= ICE_UP_TABLE_TRANSLATE(0, 0);\n \ttable |= ICE_UP_TABLE_TRANSLATE(1, 1);\n", "prefixes": [ "08/13" ] }