Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/947847/?format=api
{ "id": 947847, "url": "http://patchwork.ozlabs.org/api/patches/947847/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180723160130.8911-2-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180723160130.8911-2-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2018-07-23T16:01:30", "name": "e1000: ensure to free old tx/rx rings in set_ringparam()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1089100c046ada2e68b2c73b5803429575484d7b", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180723160130.8911-2-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 57077, "url": "http://patchwork.ozlabs.org/api/series/57077/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=57077", "date": "2018-07-23T16:01:30", "name": "e1000: ensure to free old tx/rx rings in set_ringparam()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/57077/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/947847/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/947847/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41Z5lb1NY7z9s4Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 24 Jul 2018 01:59:22 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7642A245B3;\n\tMon, 23 Jul 2018 15:59:21 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id os0ThkTufYWe; Mon, 23 Jul 2018 15:59:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 22BB224583;\n\tMon, 23 Jul 2018 15:59:20 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8FF4A1C1011\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 15:59:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8E116227AB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 15:59:17 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ql67chiU8g99 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 15:59:16 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id F2FA724543\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Jul 2018 15:59:15 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jul 2018 08:59:15 -0700", "from jtkirshe-nuc.jf.intel.com ([134.134.177.59])\n\tby FMSMGA003.fm.intel.com with ESMTP; 23 Jul 2018 08:59:15 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,393,1526367600\"; d=\"scan'208\";a=\"66839990\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 23 Jul 2018 09:01:30 -0700", "Message-Id": "<20180723160130.8911-2-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180723160130.8911-1-jeffrey.t.kirsher@intel.com>", "References": "<20180723160130.8911-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] e1000: ensure to free old tx/rx rings in\n\tset_ringparam()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Bo Chen <chenbo@pdx.edu>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bo Chen <chenbo@pdx.edu>\n\nIn 'e1000_set_ringparam()', the tx_ring and rx_ring are updated with new value\nand the old tx/rx rings are freed only when the device is up. There are resource\nleaks on old tx/rx rings when the device is not up. This bug is reported by COD,\na tool for testing kernel module binaries I am building.\n\nThis patch fixes the bug by always calling 'kfree()' on old tx/rx rings in\n'e1000_set_ringparam()'.\n\nSigned-off-by: Bo Chen <chenbo@pdx.edu>\nReviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\nindex bdb3f8e65ed4..27b006b60f8b 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n@@ -624,14 +624,14 @@ static int e1000_set_ringparam(struct net_device *netdev,\n \t\tadapter->tx_ring = tx_old;\n \t\te1000_free_all_rx_resources(adapter);\n \t\te1000_free_all_tx_resources(adapter);\n-\t\tkfree(tx_old);\n-\t\tkfree(rx_old);\n \t\tadapter->rx_ring = rxdr;\n \t\tadapter->tx_ring = txdr;\n \t\terr = e1000_up(adapter);\n \t\tif (err)\n \t\t\tgoto err_setup;\n \t}\n+\tkfree(tx_old);\n+\tkfree(rx_old);\n \n \tclear_bit(__E1000_RESETTING, &adapter->flags);\n \treturn 0;\n", "prefixes": [] }