Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/947246/?format=api
{ "id": 947246, "url": "http://patchwork.ozlabs.org/api/patches/947246/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180720222929.3568.39183.stgit@ahduyck-green-test.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180720222929.3568.39183.stgit@ahduyck-green-test.jf.intel.com>", "list_archive_url": null, "date": "2018-07-20T22:29:29", "name": "[jkirsher/next-queue,1/2] ixgbe: Reorder Tx/Rx shutdown to reduce time needed to stop device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4f4a2202208a5c99b01b965f2810d9a25480b598", "submitter": { "id": 251, "url": "http://patchwork.ozlabs.org/api/people/251/?format=api", "name": "Duyck, Alexander H", "email": "alexander.h.duyck@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180720222929.3568.39183.stgit@ahduyck-green-test.jf.intel.com/mbox/", "series": [ { "id": 56816, "url": "http://patchwork.ozlabs.org/api/series/56816/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=56816", "date": "2018-07-20T22:29:29", "name": "[jkirsher/next-queue,1/2] ixgbe: Reorder Tx/Rx shutdown to reduce time needed to stop device", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/56816/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/947246/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/947246/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41XQlL0Bmxz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 21 Jul 2018 08:38:21 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 343C6E4861;\n\tFri, 20 Jul 2018 22:38:20 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lx6btcdNbgNn; Fri, 20 Jul 2018 22:38:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 979C9E485B;\n\tFri, 20 Jul 2018 22:38:19 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6D8721C0945\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Jul 2018 22:38:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6985E30E48\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Jul 2018 22:38:18 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SpoIAts+Ly1G for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Jul 2018 22:38:17 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id CF95530E4B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Jul 2018 22:38:17 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jul 2018 15:38:17 -0700", "from ahduyck-green-test.jf.intel.com ([10.166.244.158])\n\tby orsmga006.jf.intel.com with ESMTP; 20 Jul 2018 15:38:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,381,1526367600\"; d=\"scan'208\";a=\"59409082\"", "From": "Alexander Duyck <alexander.h.duyck@intel.com>", "To": "lihong.yang@intel.com, todd.fujinaka@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 20 Jul 2018 18:29:29 -0400", "Message-ID": "<20180720222929.3568.39183.stgit@ahduyck-green-test.jf.intel.com>", "In-Reply-To": "<20180720222647.3568.34992.stgit@ahduyck-green-test.jf.intel.com>", "References": "<20180720222647.3568.34992.stgit@ahduyck-green-test.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH 1/2] ixgbe: Reorder\n\tTx/Rx shutdown to reduce time needed to stop device", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This change is meant to help reduce the time needed to shutdown the\ntransmit and receive paths for the device. Specifically what we now do\nafter this patch is disable the transmit path first at the netdev level,\nand then work on disabling the Rx. This way while we are waiting on the Rx\nqueues to be disabled the Tx queues have an opportunity to drain out.\n\nIn addition I have droped the 10ms timeout that was left in the ixgbe_down\nfunction that seems to have been carried through from back in e1000 as far\nas I can tell. We shouldn't need it since we don't actually disable the Tx\nuntil much later and we have additional logic in place for verifying the Tx\nqueues have been disabled.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 372174c..7eef089 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -5814,6 +5814,13 @@ void ixgbe_down(struct ixgbe_adapter *adapter)\n \tif (test_and_set_bit(__IXGBE_DOWN, &adapter->state))\n \t\treturn; /* do nothing if already down */\n \n+\t/* Shut off incoming Tx traffic */\n+\tnetif_tx_stop_all_queues(netdev);\n+\n+\t/* call carrier off first to avoid false dev_watchdog timeouts */\n+\tnetif_carrier_off(netdev);\n+\tnetif_tx_disable(netdev);\n+\n \t/* disable receives */\n \thw->mac.ops.disable_rx(hw);\n \n@@ -5822,16 +5829,9 @@ void ixgbe_down(struct ixgbe_adapter *adapter)\n \t\t/* this call also flushes the previous write */\n \t\tixgbe_disable_rx_queue(adapter, adapter->rx_ring[i]);\n \n-\tusleep_range(10000, 20000);\n-\n \t/* synchronize_sched() needed for pending XDP buffers to drain */\n \tif (adapter->xdp_ring[0])\n \t\tsynchronize_sched();\n-\tnetif_tx_stop_all_queues(netdev);\n-\n-\t/* call carrier off first to avoid false dev_watchdog timeouts */\n-\tnetif_carrier_off(netdev);\n-\tnetif_tx_disable(netdev);\n \n \tixgbe_irq_disable(adapter);\n \n", "prefixes": [ "jkirsher/next-queue", "1/2" ] }