Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/946224/?format=api
{ "id": 946224, "url": "http://patchwork.ozlabs.org/api/patches/946224/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180719112522.GA16521@gklab-81-211.igk.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180719112522.GA16521@gklab-81-211.igk.intel.com>", "list_archive_url": null, "date": "2018-07-19T11:25:22", "name": "i40e: Remove duplicated prepare call in i40e_shutdown", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dd0056a94a0d46d8496189190407ba1a8d6ab47e", "submitter": { "id": 74105, "url": "http://patchwork.ozlabs.org/api/people/74105/?format=api", "name": "Nemov, Sergey", "email": "sergey.nemov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180719112522.GA16521@gklab-81-211.igk.intel.com/mbox/", "series": [ { "id": 56438, "url": "http://patchwork.ozlabs.org/api/series/56438/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=56438", "date": "2018-07-19T11:25:22", "name": "i40e: Remove duplicated prepare call in i40e_shutdown", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/56438/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/946224/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/946224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41WWsj1SM9z9s1R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 19 Jul 2018 21:25:43 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D661489EA3;\n\tThu, 19 Jul 2018 11:25:41 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id v9YDCHKwY6mL; Thu, 19 Jul 2018 11:25:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DC1AC89E96;\n\tThu, 19 Jul 2018 11:25:39 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 514ED1C0927\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Jul 2018 11:25:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4D4C530933\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Jul 2018 11:25:38 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VCxFi-YZ1gYn for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Jul 2018 11:25:37 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 7CF983092F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Jul 2018 11:25:37 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jul 2018 04:25:36 -0700", "from gklab-104-006.igk.intel.com (HELO gklab-81-211.igk.intel.com)\n\t([172.28.178.52])\n\tby orsmga001.jf.intel.com with ESMTP; 19 Jul 2018 04:25:23 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "UNSCANNABLE", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.51,374,1526367600\"; d=\"scan'208,223\";\n\ta=\"74076671\"", "Date": "Thu, 19 Jul 2018 13:25:22 +0200", "From": "Sergey Nemov <sergey.nemov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Message-ID": "<20180719112522.GA16521@gklab-81-211.igk.intel.com>", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"r5Pyd7+fXNt84Ff3\"", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.21 (2010-09-15)", "Subject": "[Intel-wired-lan] [PATCH] i40e: Remove duplicated prepare call in\n\ti40e_shutdown", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Function call to i40e_prep_for_reset() is duplicated in\ni40e_shutdown routine and gets called before\ni40e_enable_mc_magic_wake() which blocks it from being executed\ncorrectly on system reboot or shutdown because adminq is already\ndisabled by first i40e_prep_for_reset() call.\n\nTwo register write calls are also duplicated.\n\nSigned-off-by: Sergey Nemov <sergey.nemov@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex b5daa5c..71c69df 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -14355,12 +14355,6 @@ static void i40e_shutdown(struct pci_dev *pdev)\n \n \tset_bit(__I40E_SUSPENDED, pf->state);\n \tset_bit(__I40E_DOWN, pf->state);\n-\trtnl_lock();\n-\ti40e_prep_for_reset(pf, true);\n-\trtnl_unlock();\n-\n-\twr32(hw, I40E_PFPM_APM, (pf->wol_en ? I40E_PFPM_APM_APME_MASK : 0));\n-\twr32(hw, I40E_PFPM_WUFC, (pf->wol_en ? I40E_PFPM_WUFC_MAG_MASK : 0));\n \n \tdel_timer_sync(&pf->service_timer);\n \tcancel_work_sync(&pf->service_task);\n", "prefixes": [] }