Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 942,
    "url": "http://patchwork.ozlabs.org/api/patches/942/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/200809222110.m8MLAHl1029870@imap1.linux-foundation.org/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<200809222110.m8MLAHl1029870@imap1.linux-foundation.org>",
    "list_archive_url": null,
    "date": "2008-09-22T21:10:17",
    "name": "[for,2.6.27?,03/10] drivers/net/atl1e/: don't take the mdio_lock in atl1e_probe",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "94922c2f6e458f9e6599f80d07a1de8f1ab3943d",
    "submitter": {
        "id": 107,
        "url": "http://patchwork.ozlabs.org/api/people/107/?format=api",
        "name": "Andrew Morton",
        "email": "akpm@linux-foundation.org"
    },
    "delegate": {
        "id": 36,
        "url": "http://patchwork.ozlabs.org/api/users/36/?format=api",
        "username": "jgarzik",
        "first_name": "Jeff",
        "last_name": "Garzik",
        "email": "jgarzik@pobox.com"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/200809222110.m8MLAHl1029870@imap1.linux-foundation.org/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/942/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/942/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 37241DDF14\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 07:12:14 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751481AbYIVVMF (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 22 Sep 2008 17:12:05 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1753225AbYIVVMD\n\t(ORCPT <rfc822; netdev-outgoing>); Mon, 22 Sep 2008 17:12:03 -0400",
            "from smtp1.linux-foundation.org ([140.211.169.13]:60312 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751424AbYIVVMB (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 22 Sep 2008 17:12:01 -0400",
            "from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8MLAIEq014570\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tMon, 22 Sep 2008 14:10:19 -0700",
            "from localhost.localdomain (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id\n\tm8MLAHl1029870; Mon, 22 Sep 2008 14:10:17 -0700"
        ],
        "Message-Id": "<200809222110.m8MLAHl1029870@imap1.linux-foundation.org>",
        "Subject": "[patch for 2.6.27? 03/10] drivers/net/atl1e/: don't take the\n\tmdio_lock in atl1e_probe",
        "To": "jeff@garzik.org",
        "Cc": "netdev@vger.kernel.org, akpm@linux-foundation.org, matthew@wil.cx,\n\tjie.yang@atheros.com, willy@linux.intel.com",
        "From": "akpm@linux-foundation.org",
        "Date": "Mon, 22 Sep 2008 14:10:17 -0700",
        "X-Spam-Status": "No, hits=-3.358 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED",
        "X-Spam-Checker-Version": "SpamAssassin 3.2.4-osdl_revision__1.47__",
        "X-MIMEDefang-Filter": "lf$Revision: 1.188 $",
        "X-Scanned-By": "MIMEDefang 2.63 on 140.211.169.13",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Matthew Wilcox <matthew@wil.cx>\n\nLockdep warns about the mdio_lock taken with interrupts enabled then later\ntaken from interrupt context.  Initially, I considered changing these to\nspin_lock_irq/spin_unlock_irq, but then I looked at atl1e_phy_init() and\nsaw that it calls msleep().  Sleeping while holding a spinlock is not\nallowed either.\n\nIn the probe path, we haven't registered the interrupt handler, so it\ncan't poke at this card yet.  It's before we call register_netdev(), so I\ndon't think any other threads can reach this card either.  If I'm right,\nwe don't need a spinlock at all.\n\nSigned-off-by: Matthew Wilcox <willy@linux.intel.com>\nAcked-by: Jie Yang <jie.yang@atheros.com>\nCc: Jeff Garzik <jeff@garzik.org>\nSigned-off-by: Andrew Morton <akpm@linux-foundation.org>\n---\n\n drivers/net/atl1e/atl1e_main.c |    2 --\n 1 file changed, 2 deletions(-)",
    "diff": "diff -puN drivers/net/atl1e/atl1e_main.c~drivers-net-atl1e-dont-take-the-mdio_lock-in-atl1e_probe drivers/net/atl1e/atl1e_main.c\n--- a/drivers/net/atl1e/atl1e_main.c~drivers-net-atl1e-dont-take-the-mdio_lock-in-atl1e_probe\n+++ a/drivers/net/atl1e/atl1e_main.c\n@@ -2390,9 +2390,7 @@ static int __devinit atl1e_probe(struct \n \t}\n \n \t/* Init GPHY as early as possible due to power saving issue  */\n-\tspin_lock(&adapter->mdio_lock);\n \tatl1e_phy_init(&adapter->hw);\n-\tspin_unlock(&adapter->mdio_lock);\n \t/* reset the controller to\n \t * put the device in a known good starting state */\n \terr = atl1e_reset_hw(&adapter->hw);\n",
    "prefixes": [
        "for",
        "2.6.27?",
        "03/10"
    ]
}