Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/940/?format=api
{ "id": 940, "url": "http://patchwork.ozlabs.org/api/patches/940/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/200809222110.m8MLAFYm029864@imap1.linux-foundation.org/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<200809222110.m8MLAFYm029864@imap1.linux-foundation.org>", "list_archive_url": null, "date": "2008-09-22T21:10:15", "name": "[for,2.6.27?,01/10] e100: adapt to the reworked PCI PM", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": true, "hash": "735ea03bfd5e75a8c7b1e7780099187b2f077ef4", "submitter": { "id": 107, "url": "http://patchwork.ozlabs.org/api/people/107/?format=api", "name": "Andrew Morton", "email": "akpm@linux-foundation.org" }, "delegate": { "id": 36, "url": "http://patchwork.ozlabs.org/api/users/36/?format=api", "username": "jgarzik", "first_name": "Jeff", "last_name": "Garzik", "email": "jgarzik@pobox.com" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/200809222110.m8MLAFYm029864@imap1.linux-foundation.org/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/940/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/940/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 17A2DDDF0A\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 07:11:43 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753501AbYIVVLb (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 22 Sep 2008 17:11:31 -0400", "(majordomo@vger.kernel.org) by vger.kernel.org id S1753382AbYIVVLb\n\t(ORCPT <rfc822; netdev-outgoing>); Mon, 22 Sep 2008 17:11:31 -0400", "from smtp1.linux-foundation.org ([140.211.169.13]:40055 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753192AbYIVVLa (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 22 Sep 2008 17:11:30 -0400", "from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8MLAGwE014562\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tMon, 22 Sep 2008 14:10:17 -0700", "from localhost.localdomain (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id\n\tm8MLAFYm029864; Mon, 22 Sep 2008 14:10:15 -0700" ], "Message-Id": "<200809222110.m8MLAFYm029864@imap1.linux-foundation.org>", "Subject": "[patch for 2.6.27? 01/10] e100: adapt to the reworked PCI PM", "To": "jeff@garzik.org", "Cc": "netdev@vger.kernel.org, akpm@linux-foundation.org, rjw@sisk.pl,\n\telendil@planet.nl, jbarnes@virtuousgeek.org, jeffrey.t.kirsher@intel.com", "From": "akpm@linux-foundation.org", "Date": "Mon, 22 Sep 2008 14:10:15 -0700", "X-Spam-Status": "No, hits=-3.358 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED", "X-Spam-Checker-Version": "SpamAssassin 3.2.4-osdl_revision__1.47__", "X-MIMEDefang-Filter": "lf$Revision: 1.188 $", "X-Scanned-By": "MIMEDefang 2.63 on 140.211.169.13", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: \"Rafael J. Wysocki\" <rjw@sisk.pl>\n\nAdapt the e100 driver to the reworked PCI PM\n\n* Use device_set_wakeup_enable() and friends as needed\n* Use pci_pme_active() to clear PME_Status and disable PME#\n* Use the observation that it is sufficient to call pci_enable_wake()\n once, unless it fails\n\nSigned-off-by: Rafael J. Wysocki <rjw@sisk.pl>\nTested-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nAcked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nCc: Jesse Barnes <jbarnes@virtuousgeek.org>\nCc: Jeff Garzik <jeff@garzik.org>\nCc: Frans Pop <elendil@planet.nl>\nSigned-off-by: Andrew Morton <akpm@linux-foundation.org>\n---\n\n drivers/net/e100.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff -puN drivers/net/e100.c~e100-adapt-to-the-reworked-pci-pm drivers/net/e100.c\n--- a/drivers/net/e100.c~e100-adapt-to-the-reworked-pci-pm\n+++ a/drivers/net/e100.c\n@@ -2211,7 +2211,8 @@ static int e100_set_wol(struct net_devic\n {\n \tstruct nic *nic = netdev_priv(netdev);\n \n-\tif(wol->wolopts != WAKE_MAGIC && wol->wolopts != 0)\n+\tif ((wol->wolopts && wol->wolopts != WAKE_MAGIC) ||\n+\t !device_can_wakeup(&nic->pdev->dev))\n \t\treturn -EOPNOTSUPP;\n \n \tif(wol->wolopts)\n@@ -2219,6 +2220,8 @@ static int e100_set_wol(struct net_devic\n \telse\n \t\tnic->flags &= ~wol_magic;\n \n+\tdevice_set_wakeup_enable(&nic->pdev->dev, wol->wolopts);\n+\n \te100_exec_cb(nic, NULL, e100_configure);\n \n \treturn 0;\n@@ -2623,8 +2626,10 @@ static int __devinit e100_probe(struct p\n \n \t/* Wol magic packet can be enabled from eeprom */\n \tif((nic->mac >= mac_82558_D101_A4) &&\n-\t (nic->eeprom[eeprom_id] & eeprom_id_wol))\n+\t (nic->eeprom[eeprom_id] & eeprom_id_wol)) {\n \t\tnic->flags |= wol_magic;\n+\t\tdevice_set_wakeup_enable(&pdev->dev, true);\n+\t}\n \n \t/* ack any pending wake events, disable PME */\n \tpci_pme_active(pdev, false);\n@@ -2683,11 +2688,10 @@ static int e100_suspend(struct pci_dev *\n \tpci_save_state(pdev);\n \n \tif ((nic->flags & wol_magic) | e100_asf(nic)) {\n-\t\tpci_enable_wake(pdev, PCI_D3hot, 1);\n-\t\tpci_enable_wake(pdev, PCI_D3cold, 1);\n+\t\tif (pci_enable_wake(pdev, PCI_D3cold, true))\n+\t\t\tpci_enable_wake(pdev, PCI_D3hot, true);\n \t} else {\n-\t\tpci_enable_wake(pdev, PCI_D3hot, 0);\n-\t\tpci_enable_wake(pdev, PCI_D3cold, 0);\n+\t\tpci_enable_wake(pdev, PCI_D3hot, false);\n \t}\n \n \tpci_disable_device(pdev);\n", "prefixes": [ "for", "2.6.27?", "01/10" ] }