Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/934767/?format=api
{ "id": 934767, "url": "http://patchwork.ozlabs.org/api/patches/934767/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/7d2fa77261c64a218250d6c0f6dad6aa@infodas.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<7d2fa77261c64a218250d6c0f6dad6aa@infodas.de>", "list_archive_url": null, "date": "2018-06-26T10:12:18", "name": "igb: Remove superfluous reset to PHY and page 0 selection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2f102cfbaf20c0aea6530e83d52ad3f8a1af0a35", "submitter": { "id": 74374, "url": "http://patchwork.ozlabs.org/api/people/74374/?format=api", "name": "Grönke, Christian", "email": "C.Groenke@infodas.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/7d2fa77261c64a218250d6c0f6dad6aa@infodas.de/mbox/", "series": [ { "id": 52117, "url": "http://patchwork.ozlabs.org/api/series/52117/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=52117", "date": "2018-06-26T10:12:18", "name": "igb: Remove superfluous reset to PHY and page 0 selection", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/52117/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/934767/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/934767/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=infodas.de" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41FMKx2sdcz9rxs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Jun 2018 20:12:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5F37F26FDB;\n\tTue, 26 Jun 2018 10:12:35 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CsGjewxhbzaA; Tue, 26 Jun 2018 10:12:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0B52A26FDD;\n\tTue, 26 Jun 2018 10:12:29 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id DEBD71C2046\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 26 Jun 2018 10:12:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DB028861EE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 26 Jun 2018 10:12:27 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Kkt9lNoExDwe for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 26 Jun 2018 10:12:24 +0000 (UTC)", "from mailgw1.infodas.de (mailgw1.infodas.de [194.77.194.163])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 9B0E685DF2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 26 Jun 2018 10:12:23 +0000 (UTC)", "from mailgw1.infodas.de (10.1.25.54) by\n\tmailgw-int.infodas-dmz.intern with Infodas vecoMail 3.4.006.00536\n\tid 30007561021057; Tue, 26 Jun 2018 12:06:01 +0200", "from mailsrv.infodas.de (192.168.119.1) by mailgw1.infodas.de with\n\tInfodas vecoMail 3.4.006.00536\n\tid 30007554004987; Tue, 26 Jun 2018 12:05:54 +0200", "from AS001EX.ifd.infodas.de (192.168.100.13) by\n\tAS001EX.ifd.infodas.de (192.168.100.13) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1034.26; Tue, 26 Jun 2018 12:12:18 +0200", "from AS001EX.ifd.infodas.de ([fe80::1009:82f4:6b93:afe0]) by\n\tAS001EX.ifd.infodas.de ([fe80::1009:82f4:6b93:afe0%12]) with mapi id\n\t15.01.1034.026; Tue, 26 Jun 2018 12:12:18 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "X-Originator": "C.Groenke@infodas.de", "From": "=?iso-8859-1?q?Gr=F6nke=2C_Christian?= <C.Groenke@infodas.de>", "To": "\"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>", "Thread-Topic": "[PATCH] igb: Remove superfluous reset to PHY and page 0\n\tselection", "Thread-Index": "AdQNNfaT5A3dCWPrTXWahVSk5uLZfg==", "Date": "Tue, 26 Jun 2018 10:12:18 +0000", "Message-ID": "<7d2fa77261c64a218250d6c0f6dad6aa@infodas.de>", "Accept-Language": "de-DE, en-US", "Content-Language": "de-DE", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[192.168.100.76]", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] igb: Remove superfluous reset to PHY and\n\tpage 0 selection", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Chris J Arges <christopherarges@gmail.com>", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch reverts two previous applied patches to fix an issue\nthat appeared when using SGMII based SFP modules. In the current\nstate the driver will try to reset the PHY before obtaining the\nphy_addr of the SGMII attached PHY. That leads to an error in\ne1000_write_phy_reg_sgmii_82575. Causing the initialization to\nfail:\n\n igb: Intel(R) Gigabit Ethernet Network Driver - version 5.4.0-k\n igb: Copyright (c) 2007-2014 Intel Corporation.\n igb: probe of ????:??:??.? failed with error -3\n\nThe patches being reverted are:\n\n commit 182785335447957409282ca745aa5bc3968facee\n Author: Aaron Sierra <asierra@xes-inc.com>\n Date: Tue Nov 29 10:03:56 2016 -0600\n\n igb: reset the PHY before reading the PHY ID\n\n commit 440aeca4b9858248d8f16d724d9fa87a4f65fa33\n Author: Matwey V Kornilov <matwey@sai.msu.ru>\n Date: Thu Nov 24 13:32:48 2016 +0300\n\n igb: Explicitly select page 0 at initialization\n\nThe first reverted patch directly causes the problem mentioned above.\nIn case of SGMII the phy_addr is not known at this point and will\nonly be obtained by 'igb_get_phy_id_82575' further down in the code.\nThe second removed patch selects forces selection of page 0 in the\nPHY. Something that the reset tries to address as well.\n\nAs pointed out by Alexander Duzck, the patch below fixes the same\nissue but in the proper location:\n\n commit 4e684f59d760a2c7c716bb60190783546e2d08a1\n Author: Chris J Arges <christopherarges@gmail.com>\n Date: Wed Nov 2 09:13:42 2016 -0500\n\n igb: Workaround for igb i210 firmware issue\n\nReverts: 440aeca4b9858248d8f16d724d9fa87a4f65fa33.\nReverts: 182785335447957409282ca745aa5bc3968facee.\n\nSigned-off-by: Christian Grönke <c.groenke@infodas.de>\n---\n e1000_82575.c | 12 ------------\n 1 file changed, 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c\nindex b13b42e..a795c07 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_82575.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_82575.c\n@@ -225,19 +225,7 @@ static s32 igb_init_phy_params_82575(struct e1000_hw *hw)\n \thw->bus.func = (rd32(E1000_STATUS) & E1000_STATUS_FUNC_MASK) >>\n \t\t\tE1000_STATUS_FUNC_SHIFT;\n \n-\t/* Make sure the PHY is in a good state. Several people have reported\n-\t * firmware leaving the PHY's page select register set to something\n-\t * other than the default of zero, which causes the PHY ID read to\n-\t * access something other than the intended register.\n-\t */\n-\tret_val = hw->phy.ops.reset(hw);\n-\tif (ret_val) {\n-\t\thw_dbg(\"Error resetting the PHY.\\n\");\n-\t\tgoto out;\n-\t}\n-\n \t/* Set phy->phy_addr and phy->id. */\n-\tigb_write_phy_reg_82580(hw, I347AT4_PAGE_SELECT, 0);\n \tret_val = igb_get_phy_id_82575(hw);\n \tif (ret_val)\n \t\treturn ret_val;\n", "prefixes": [] }