Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/928755/?format=api
{ "id": 928755, "url": "http://patchwork.ozlabs.org/api/patches/928755/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1528877310-2574-1-git-send-email-makita.toshiaki@lab.ntt.co.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1528877310-2574-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>", "list_archive_url": null, "date": "2018-06-13T08:08:30", "name": "[net-queue] i40e: Fix incorrect skb reserved size on rx", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "38bfb38b7851997a5fd0855c33490990bf3521cb", "submitter": { "id": 22461, "url": "http://patchwork.ozlabs.org/api/people/22461/?format=api", "name": "Toshiaki Makita", "email": "makita.toshiaki@lab.ntt.co.jp" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1528877310-2574-1-git-send-email-makita.toshiaki@lab.ntt.co.jp/mbox/", "series": [ { "id": 49893, "url": "http://patchwork.ozlabs.org/api/series/49893/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=49893", "date": "2018-06-13T08:08:30", "name": "[net-queue] i40e: Fix incorrect skb reserved size on rx", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/49893/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/928755/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/928755/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=lab.ntt.co.jp" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 415KnJ0G9Nz9s4n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Jun 2018 18:34:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E92698A701;\n\tWed, 13 Jun 2018 08:34:57 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gw63NrlqOSRq; Wed, 13 Jun 2018 08:34:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 223518A6D5;\n\tWed, 13 Jun 2018 08:34:57 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 159591C2716\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Jun 2018 08:34:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 126688A9C6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Jun 2018 08:34:56 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id d3MqbHKcfP8y for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Jun 2018 08:34:54 +0000 (UTC)", "from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 870FC8A9CA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Jun 2018 08:34:54 +0000 (UTC)", "from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154])\n\tby tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w5D8AP0b014545;\n\tWed, 13 Jun 2018 17:10:25 +0900", "from vc2.ecl.ntt.co.jp (localhost [127.0.0.1])\n\tby vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 82CFB638F66;\n\tWed, 13 Jun 2018 17:10:25 +0900 (JST)", "from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp\n\t[129.60.87.134])\n\tby vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 76B56638E33;\n\tWed, 13 Jun 2018 17:10:25 +0900 (JST)", "from makita-ubuntu.m.ecl.ntt.co.jp (unknown [129.60.241.229])\n\tby jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 6F2B4400AEE;\n\tWed, 13 Jun 2018 17:10:25 +0900 (JST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:24:03 by SQLgrey-1.7.6", "From": "Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>", "Date": "Wed, 13 Jun 2018 17:08:30 +0900", "Message-Id": "<1528877310-2574-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>", "X-Mailer": "git-send-email 2.7.4", "X-CC-Mail-RelayStamp": "1", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "X-TM-AS-MML": "disable", "Subject": "[Intel-wired-lan] [PATCH net-queue] i40e: Fix incorrect skb\n\treserved size on rx", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n\tDaniel Borkmann <daniel@iogearbox.net>,\n\tToshiaki Makita <makita.toshiaki@lab.ntt.co.jp>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "i40e_build_skb() reserves I40E_SKB_PAD + (xdp->data -\nxdp->data_hard_start) but obviously I40E_SKB_PAD is unnecessary here\nand mac_header/data feilds in skb becomes incorrect, and breaks normal\nskb receive path as well as XDP receive path.\n\nFixes: cc5b114dcf98 (\"bpf, i40e: add meta data support\")\nSigned-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 8ffb7454e67c..6d59f51f1730 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -2124,7 +2124,7 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,\n \t\treturn NULL;\n \n \t/* update pointers within the skb to store the data */\n-\tskb_reserve(skb, I40E_SKB_PAD + (xdp->data - xdp->data_hard_start));\n+\tskb_reserve(skb, xdp->data - xdp->data_hard_start);\n \t__skb_put(skb, xdp->data_end - xdp->data);\n \tif (metasize)\n \t\tskb_metadata_set(skb, metasize);\n", "prefixes": [ "net-queue" ] }