Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/928368/?format=api
{ "id": 928368, "url": "http://patchwork.ozlabs.org/api/patches/928368/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180612151830.86792.69449.stgit@ahduyck-green-test.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180612151830.86792.69449.stgit@ahduyck-green-test.jf.intel.com>", "list_archive_url": null, "date": "2018-06-12T15:18:30", "name": "[jkirsher/next-queue,v2,1/7] net-sysfs: Drop support for XPS and traffic_class on single queue device", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "861d2599dcba7cc32c7c828a8f8378257b60c3b4", "submitter": { "id": 251, "url": "http://patchwork.ozlabs.org/api/people/251/?format=api", "name": "Duyck, Alexander H", "email": "alexander.h.duyck@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180612151830.86792.69449.stgit@ahduyck-green-test.jf.intel.com/mbox/", "series": [ { "id": 49759, "url": "http://patchwork.ozlabs.org/api/series/49759/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=49759", "date": "2018-06-12T15:18:25", "name": "Add support for L2 Fwd Offload w/o ndo_select_queue", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/49759/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/928368/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/928368/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 414tz60lb8z9s1R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Jun 2018 01:26:57 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 61120306BC;\n\tTue, 12 Jun 2018 15:26:56 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6OaC9Eyp2bZN; Tue, 12 Jun 2018 15:26:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id F2ECF30581;\n\tTue, 12 Jun 2018 15:26:53 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0159E1C0D68\n\tfor <intel-wired-lan@osuosl.org>;\n\tTue, 12 Jun 2018 15:26:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4C08D89ABE\n\tfor <intel-wired-lan@osuosl.org>;\n\tTue, 12 Jun 2018 15:26:38 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eKF943s2uTky for <intel-wired-lan@osuosl.org>;\n\tTue, 12 Jun 2018 15:26:37 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id A83AF89A54\n\tfor <intel-wired-lan@osuosl.org>;\n\tTue, 12 Jun 2018 15:26:37 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jun 2018 08:26:36 -0700", "from ahduyck-green-test.jf.intel.com ([10.166.244.179])\n\tby orsmga007.jf.intel.com with ESMTP; 12 Jun 2018 08:26:36 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,215,1526367600\"; d=\"scan'208\";a=\"48397760\"", "From": "Alexander Duyck <alexander.h.duyck@intel.com>", "To": "intel-wired-lan@osuosl.org, jeffrey.t.kirsher@intel.com,\n\tnetdev@vger.kernel.org", "Date": "Tue, 12 Jun 2018 11:18:30 -0400", "Message-ID": "<20180612151830.86792.69449.stgit@ahduyck-green-test.jf.intel.com>", "In-Reply-To": "<20180612151322.86792.97587.stgit@ahduyck-green-test.jf.intel.com>", "References": "<20180612151322.86792.97587.stgit@ahduyck-green-test.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH v2 1/7] net-sysfs:\n\tDrop support for XPS and traffic_class on single queue device", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch makes it so that we do not report the traffic class or allow XPS\nconfiguration on single queue devices. This is mostly to avoid unnecessary\ncomplexity with changes I have planned that will allow us to reuse\nthe unused tc_to_txq and XPS configuration on a single queue device to\nallow it to make use of a subset of queues on an underlying device.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n net/core/net-sysfs.c | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c\nindex bb7e80f..335c6a4 100644\n--- a/net/core/net-sysfs.c\n+++ b/net/core/net-sysfs.c\n@@ -1047,9 +1047,14 @@ static ssize_t traffic_class_show(struct netdev_queue *queue,\n \t\t\t\t char *buf)\n {\n \tstruct net_device *dev = queue->dev;\n-\tint index = get_netdev_queue_index(queue);\n-\tint tc = netdev_txq_to_tc(dev, index);\n+\tint index;\n+\tint tc;\n \n+\tif (!netif_is_multiqueue(dev))\n+\t\treturn -ENOENT;\n+\n+\tindex = get_netdev_queue_index(queue);\n+\ttc = netdev_txq_to_tc(dev, index);\n \tif (tc < 0)\n \t\treturn -EINVAL;\n \n@@ -1214,6 +1219,9 @@ static ssize_t xps_cpus_show(struct netdev_queue *queue,\n \tcpumask_var_t mask;\n \tunsigned long index;\n \n+\tif (!netif_is_multiqueue(dev))\n+\t\treturn -ENOENT;\n+\n \tindex = get_netdev_queue_index(queue);\n \n \tif (dev->num_tc) {\n@@ -1260,6 +1268,9 @@ static ssize_t xps_cpus_store(struct netdev_queue *queue,\n \tcpumask_var_t mask;\n \tint err;\n \n+\tif (!netif_is_multiqueue(dev))\n+\t\treturn -ENOENT;\n+\n \tif (!capable(CAP_NET_ADMIN))\n \t\treturn -EPERM;\n \n", "prefixes": [ "jkirsher/next-queue", "v2", "1/7" ] }