Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/925522/?format=api
{ "id": 925522, "url": "http://patchwork.ozlabs.org/api/patches/925522/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180605151108.3359.9455.stgit@ahduyck-green-test.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180605151108.3359.9455.stgit@ahduyck-green-test.jf.intel.com>", "list_archive_url": null, "date": "2018-06-05T15:11:08", "name": "[net-queue,1/2] ixgbe: Avoid loopback and fix boolean logic in ipsec_stop_data", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b6e0cdea6b398fe67c3b9fd446083ed2ff066f76", "submitter": { "id": 251, "url": "http://patchwork.ozlabs.org/api/people/251/?format=api", "name": "Duyck, Alexander H", "email": "alexander.h.duyck@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180605151108.3359.9455.stgit@ahduyck-green-test.jf.intel.com/mbox/", "series": [ { "id": 48643, "url": "http://patchwork.ozlabs.org/api/series/48643/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=48643", "date": "2018-06-05T15:11:03", "name": "More fixes for ipsec", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/48643/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/925522/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/925522/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 410b7L0nWvz9s08\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 6 Jun 2018 01:19:09 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9C08588DF2;\n\tTue, 5 Jun 2018 15:19:08 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 85Wh4Oq0hJCj; Tue, 5 Jun 2018 15:19:06 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B3B1688DF4;\n\tTue, 5 Jun 2018 15:19:06 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7F0831C2797\n\tfor <intel-wired-lan@osuosl.org>;\n\tTue, 5 Jun 2018 15:19:05 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7C9AE8A9CF\n\tfor <intel-wired-lan@osuosl.org>;\n\tTue, 5 Jun 2018 15:19:05 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vJn+q8VnbXg5 for <intel-wired-lan@osuosl.org>;\n\tTue, 5 Jun 2018 15:19:02 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 04CE68A9B9\n\tfor <intel-wired-lan@osuosl.org>;\n\tTue, 5 Jun 2018 15:19:01 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jun 2018 08:19:01 -0700", "from ahduyck-green-test.jf.intel.com ([10.166.244.179])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Jun 2018 08:19:00 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,479,1520924400\"; d=\"scan'208\";a=\"54006625\"", "From": "Alexander Duyck <alexander.h.duyck@intel.com>", "To": "shannon.nelson@oracle.com, intel-wired-lan@osuosl.org", "Date": "Tue, 05 Jun 2018 11:11:08 -0400", "Message-ID": "<20180605151108.3359.9455.stgit@ahduyck-green-test.jf.intel.com>", "In-Reply-To": "<20180605150520.3359.94409.stgit@ahduyck-green-test.jf.intel.com>", "References": "<20180605150520.3359.94409.stgit@ahduyck-green-test.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-queue PATCH 1/2] ixgbe: Avoid loopback and\n\tfix boolean logic in ipsec_stop_data", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch fixes two issues. First we add an early test for the Tx and Rx\nsecurity block ready bits. By doing this we can avoid the need for waits or\nloopback in the event that the security block is already flushed out.\nSecondly we fix the boolean logic that was testing for the Tx OR Rx ready\nbits being set and change it so that we only exit if the Tx AND Rx ready\nbits are both set.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\nindex 38d8cf7..7b23fb0 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n@@ -158,7 +158,16 @@ static void ixgbe_ipsec_stop_data(struct ixgbe_adapter *adapter)\n \treg |= IXGBE_SECRXCTRL_RX_DIS;\n \tIXGBE_WRITE_REG(hw, IXGBE_SECRXCTRL, reg);\n \n-\tIXGBE_WRITE_FLUSH(hw);\n+\t/* If both Tx and Rx are ready there are no packets\n+\t * that we need to flush so the loopback configuration\n+\t * below is not necessary.\n+\t */\n+\tt_rdy = IXGBE_READ_REG(hw, IXGBE_SECTXSTAT) &\n+\t\tIXGBE_SECTXSTAT_SECTX_RDY;\n+\tr_rdy = IXGBE_READ_REG(hw, IXGBE_SECRXSTAT) &\n+\t\tIXGBE_SECRXSTAT_SECRX_RDY;\n+\tif (t_rdy && r_rdy)\n+\t\treturn;\n \n \t/* If the tx fifo doesn't have link, but still has data,\n \t * we can't clear the tx sec block. Set the MAC loopback\n@@ -185,7 +194,7 @@ static void ixgbe_ipsec_stop_data(struct ixgbe_adapter *adapter)\n \t\t\tIXGBE_SECTXSTAT_SECTX_RDY;\n \t\tr_rdy = IXGBE_READ_REG(hw, IXGBE_SECRXSTAT) &\n \t\t\tIXGBE_SECRXSTAT_SECRX_RDY;\n-\t} while (!t_rdy && !r_rdy && limit--);\n+\t} while (!(t_rdy && r_rdy) && limit--);\n \n \t/* undo loopback if we played with it earlier */\n \tif (!link) {\n", "prefixes": [ "net-queue", "1/2" ] }