Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/925152/?format=api
{ "id": 925152, "url": "http://patchwork.ozlabs.org/api/patches/925152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180604162312.79628.37984.stgit@ahduyck-green-test.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180604162312.79628.37984.stgit@ahduyck-green-test.jf.intel.com>", "list_archive_url": null, "date": "2018-06-04T16:24:24", "name": "[net-queue] ixgbe: Move ipsec init function to before reset call", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "4f7f3c710bae316c8e7de034c4a3a79343458133", "submitter": { "id": 251, "url": "http://patchwork.ozlabs.org/api/people/251/?format=api", "name": "Duyck, Alexander H", "email": "alexander.h.duyck@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180604162312.79628.37984.stgit@ahduyck-green-test.jf.intel.com/mbox/", "series": [ { "id": 48446, "url": "http://patchwork.ozlabs.org/api/series/48446/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=48446", "date": "2018-06-04T16:24:24", "name": "[net-queue] ixgbe: Move ipsec init function to before reset call", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/48446/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/925152/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/925152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4100pd3cb1z9s08\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Jun 2018 02:32:41 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9A6AC89CBF;\n\tMon, 4 Jun 2018 16:32:39 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wQF8XsqSk9Au; Mon, 4 Jun 2018 16:32:38 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 27CAC89A59;\n\tMon, 4 Jun 2018 16:32:38 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9259F1C25C5\n\tfor <intel-wired-lan@osuosl.org>;\n\tMon, 4 Jun 2018 16:32:36 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8E5A7873DC\n\tfor <intel-wired-lan@osuosl.org>;\n\tMon, 4 Jun 2018 16:32:36 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bVPewmR6HoxD for <intel-wired-lan@osuosl.org>;\n\tMon, 4 Jun 2018 16:32:35 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id BBF29873C9\n\tfor <intel-wired-lan@osuosl.org>;\n\tMon, 4 Jun 2018 16:32:35 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Jun 2018 09:32:34 -0700", "from ahduyck-green-test.jf.intel.com ([10.166.244.179])\n\tby fmsmga002.fm.intel.com with ESMTP; 04 Jun 2018 09:32:34 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,476,1520924400\"; d=\"scan'208\";a=\"53614818\"", "From": "Alexander Duyck <alexander.h.duyck@intel.com>", "To": "intel-wired-lan@osuosl.org, andre@tomt.net", "Date": "Mon, 04 Jun 2018 12:24:24 -0400", "Message-ID": "<20180604162312.79628.37984.stgit@ahduyck-green-test.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-queue PATCH] ixgbe: Move ipsec init function\n\tto before reset call", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch moves the ipsec init function in ixgbe_sw_init. This way it is a\nbit more consistent with the placement of similar initialization functions\nand is placed before the reset_hw call which should allow us to clean up\nany link issues that may be introduced by the fact that we force the link\nup if somehow the device had ipsec still enabled before the driver was\nloaded.\n\nFixes: 49a94d74d948 (\"ixgbe: add ipsec engine start and stop routines\")\nReported-by: Andre Tomt <andre@tomt.net>\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n\nI haven't had a chance to test this myself yet since I don't have a system\nthat is reproducing this issue. I am including Andre in the \"To:\" line in\nthe hopes that perhaps he can test this to see if it resolves the issue.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex c42498d..78e7516 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -6128,6 +6128,7 @@ static int ixgbe_sw_init(struct ixgbe_adapter *adapter,\n #ifdef CONFIG_IXGBE_DCB\n \tixgbe_init_dcb(adapter);\n #endif\n+\tixgbe_init_ipsec_offload(adapter);\n \n \t/* default flow control settings */\n \thw->fc.requested_mode = ixgbe_fc_full;\n@@ -10537,8 +10538,6 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\t\t\t\t NETIF_F_FCOE_MTU;\n \t}\n #endif /* IXGBE_FCOE */\n-\tixgbe_init_ipsec_offload(adapter);\n-\n \tif (adapter->flags2 & IXGBE_FLAG2_RSC_CAPABLE)\n \t\tnetdev->hw_features |= NETIF_F_LRO;\n \tif (adapter->flags2 & IXGBE_FLAG2_RSC_ENABLED)\n", "prefixes": [ "net-queue" ] }