Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/923085/?format=api
{ "id": 923085, "url": "http://patchwork.ozlabs.org/api/patches/923085/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180530231423.28864-1-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180530231423.28864-1-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2018-05-30T23:14:23", "name": "ixgbe: Do not allow LRO or MTU change with XDP", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "85aebf6af7a75d17e10713e1a7f399f6bdd1fa94", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180530231423.28864-1-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 47638, "url": "http://patchwork.ozlabs.org/api/series/47638/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=47638", "date": "2018-05-30T23:14:23", "name": "ixgbe: Do not allow LRO or MTU change with XDP", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/47638/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/923085/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/923085/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40x66j09J5z9s0W\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 May 2018 09:21:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CE3B8265AD;\n\tWed, 30 May 2018 23:21:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Jrv5Y+0h3v6T; Wed, 30 May 2018 23:21:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0463F26578;\n\tWed, 30 May 2018 23:21:29 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 526E51C27D6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 30 May 2018 23:21:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4F15881EBC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 30 May 2018 23:21:27 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Pvnm1Jl7bhDg for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 30 May 2018 23:21:26 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 8E84E81C93\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 30 May 2018 23:21:26 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 May 2018 16:21:25 -0700", "from unknown (HELO anguy11-linux.jf.intel.com) ([10.166.241.52])\n\tby orsmga007.jf.intel.com with ESMTP; 30 May 2018 16:21:25 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,461,1520924400\"; d=\"scan'208\";a=\"45214693\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 30 May 2018 16:14:23 -0700", "Message-Id": "<20180530231423.28864-1-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.13.6", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Do not allow LRO or MTU change\n\twith XDP", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "XDP does not support jumbo frames or LRO. These checks are being made\noutside the driver when an XDP program is loaded, however, there is\nnothing preventing these from changing after an XDP program is loaded.\nAdd the checks so that while an XDP program is loaded, do not allow MTU\nto be changed or LRO to be enabled.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex b47a19de22e8..0a0822de2ab7 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -6453,6 +6453,11 @@ static int ixgbe_change_mtu(struct net_device *netdev, int new_mtu)\n {\n \tstruct ixgbe_adapter *adapter = netdev_priv(netdev);\n \n+\tif (adapter->xdp_prog) {\n+\t\te_warn(probe, \"MTU cannot be changed while XDP program is loaded\\n\");\n+\t\treturn -EPERM;\n+\t}\n+\n \t/*\n \t * For 82599EB we cannot allow legacy VFs to enable their receive\n \t * paths when MTU greater than 1500 is configured. So display a\n@@ -9396,6 +9401,11 @@ static netdev_features_t ixgbe_fix_features(struct net_device *netdev,\n \tif (!(adapter->flags2 & IXGBE_FLAG2_RSC_CAPABLE))\n \t\tfeatures &= ~NETIF_F_LRO;\n \n+\tif (adapter->xdp_prog && (features & NETIF_F_LRO)) {\n+\t\te_dev_err(\"LRO is not supported with XDP\\n\");\n+\t\tfeatures &= ~NETIF_F_LRO;\n+\t}\n+\n \treturn features;\n }\n \n", "prefixes": [] }