Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/922878/?format=api
{ "id": 922878, "url": "http://patchwork.ozlabs.org/api/patches/922878/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180530160512.37220-1-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180530160512.37220-1-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2018-05-30T16:05:12", "name": "ixgbe: fix possible race in reset subtask", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "83626eb7862c0da84fc4eab3a25031f573ec9345", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180530160512.37220-1-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 47551, "url": "http://patchwork.ozlabs.org/api/series/47551/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=47551", "date": "2018-05-30T16:05:12", "name": "ixgbe: fix possible race in reset subtask", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/47551/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/922878/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/922878/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40wwbX49PXz9s1d\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 May 2018 02:12:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5F77723CE6;\n\tWed, 30 May 2018 16:12:22 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tjMbQzGZOKbC; Wed, 30 May 2018 16:12:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id AEABE22831;\n\tWed, 30 May 2018 16:12:21 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 746AB1C055C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 30 May 2018 16:12:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7096E8657F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 30 May 2018 16:12:20 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 46GeVZKcAYCy for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 30 May 2018 16:12:19 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 0307A8657A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 30 May 2018 16:12:18 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 May 2018 09:12:18 -0700", "from unknown (HELO anguy11-linux.jf.intel.com) ([10.166.241.52])\n\tby fmsmga005.fm.intel.com with ESMTP; 30 May 2018 09:12:18 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,461,1520924400\"; d=\"scan'208\";a=\"232997910\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 30 May 2018 09:05:12 -0700", "Message-Id": "<20180530160512.37220-1-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.13.6", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: fix possible race in reset subtask", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Similar to ixgbevf, the same possibility for race exists. Extend the RTNL\nlock in ixgbe_reset_subtask() to protect the state bits; this is to make\nsure that we get the most up-to-date values for the bits and avoid a\npossible race when going down.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 78926ab35a4e..b47a19de22e8 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -7576,17 +7576,19 @@ static void ixgbe_reset_subtask(struct ixgbe_adapter *adapter)\n \tif (!test_and_clear_bit(__IXGBE_RESET_REQUESTED, &adapter->state))\n \t\treturn;\n \n+\trtnl_lock();\n \t/* If we're already down, removing or resetting, just bail */\n \tif (test_bit(__IXGBE_DOWN, &adapter->state) ||\n \t test_bit(__IXGBE_REMOVING, &adapter->state) ||\n-\t test_bit(__IXGBE_RESETTING, &adapter->state))\n+\t test_bit(__IXGBE_RESETTING, &adapter->state)) {\n+\t\trtnl_unlock();\n \t\treturn;\n+\t}\n \n \tixgbe_dump(adapter);\n \tnetdev_err(adapter->netdev, \"Reset adapter\\n\");\n \tadapter->tx_timeout_count++;\n \n-\trtnl_lock();\n \tixgbe_reinit_locked(adapter);\n \trtnl_unlock();\n }\n", "prefixes": [] }