Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/920224/?format=api
{ "id": 920224, "url": "http://patchwork.ozlabs.org/api/patches/920224/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180525041321.140516-1-venkateshs@google.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180525041321.140516-1-venkateshs@google.com>", "list_archive_url": null, "date": "2018-05-25T04:13:21", "name": "igb: Use dma_wmb() instead of wmb() before doorbell writes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "358eb334c54be9032fab1ab8b1f0b79011467c07", "submitter": { "id": 67810, "url": "http://patchwork.ozlabs.org/api/people/67810/?format=api", "name": "Venkatesh Srinivas", "email": "venkateshs@google.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180525041321.140516-1-venkateshs@google.com/mbox/", "series": [ { "id": 46542, "url": "http://patchwork.ozlabs.org/api/series/46542/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=46542", "date": "2018-05-25T04:13:21", "name": "igb: Use dma_wmb() instead of wmb() before doorbell writes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/46542/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/920224/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/920224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=reject dis=none)\n\theader.from=google.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"WHiUY9RT\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40sYTV3V5jz9s15\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 25 May 2018 14:40:29 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4F59825E17;\n\tFri, 25 May 2018 04:40:27 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2TfQgiIzMaql; Fri, 25 May 2018 04:40:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id B1473256D8;\n\tFri, 25 May 2018 04:40:26 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 781861C2197\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 May 2018 04:40:24 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7476D256D8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 May 2018 04:40:24 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Nz711LT-MuC4 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 May 2018 04:40:23 +0000 (UTC)", "from mail-yb0-f202.google.com (mail-yb0-f202.google.com\n\t[209.85.213.202])\n\tby silver.osuosl.org (Postfix) with ESMTPS id BB3A5254B3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 May 2018 04:40:23 +0000 (UTC)", "by mail-yb0-f202.google.com with SMTP id t12-v6so1943924ybg.5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 24 May 2018 21:40:23 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:20:38 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:date:message-id:subject:from:to:cc;\n\tbh=Mvo6ldG41DI9E6c0vlknrTBzVZCKgfFajLa0oeIEN4w=;\n\tb=WHiUY9RT8zy/uo5yr6nfg4L4E+8UPHE25ewbi8JdpKeXJgkTogF/kiEycR9AAnZFHE\n\tpb7RiHfQk66tbt86T6sUnES41aVb2/1z3/rJoMdvl/gJbTj3npX8gz4bfFwadr/AQILr\n\tfIW8daRJk1C3huUjgovNF+eIt2P9elBWjTyHaXKmrvcRJr88O0OjnC06sEIzZKfKi+No\n\tqerZNTe+/tpPlRp8+spIqowomM9UwHPabm2EXNwdsrlekYn+RXXdUGsRvzeqxbG/q8+L\n\tao2UQHtybLOK+dI2neGP5C/2n0bdXEQEpZ1ThvRmsZbXyzNWwdLpK4Ia1Bicj+8tXoSi\n\tsSKA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc; \n\tbh=Mvo6ldG41DI9E6c0vlknrTBzVZCKgfFajLa0oeIEN4w=;\n\tb=GA5cNodoQo8LKJK3WZZ1lSTunl8IY555tE55+4y8ShyceqVygnD9BxMX26kwRtGp6j\n\tYM+sRcQHeeqQF/1SOmAsa9zpWS+CuLyPufM8Ar7e403chQVvZ+PNwJAP7SE0flw5DdxJ\n\tsNkA6sAbIqR+7ReIeacwzF9L2zWla3h9i8dsSeHjxcZXQYHxfCWdr9ZPT6D+jkSTmmQd\n\to+pofck+w5PmAlp5/2w9rSiIKcTZIxyZ1ai3oaETt4LrP+yzjnMGP3AlKUvMcOuXUeAe\n\twrdykstD3sOx/hru9+5wTFwSWwtGIFk/Nj9MgSeHB9qPzNgLSdbQINfVIWHTGZ6fRGgH\n\t3kfQ==", "X-Gm-Message-State": "ALKqPwfYzjeR6IvzdpWfbl5H8+UB9sZTmM48nIdo3DsuENdASFHPUG4h\n\tRISuO0UZOFQTNF0b4w15b55gP2vMma5L3GxD", "X-Google-Smtp-Source": "ADUXVKIUvV/QIV8Pylqlaed3NCeNmIjU2sgY+FJ+DiZ8pNJ4FyEgx0H6yDLQp12xUc7MfAMIhJnvZaSmgjJk0DKe", "MIME-Version": "1.0", "X-Received": "by 2002:a5b:542:: with SMTP id r2-v6mr181445ybp.28.1527221612614;\n\tThu, 24 May 2018 21:13:32 -0700 (PDT)", "Date": "Fri, 25 May 2018 00:13:21 -0400", "Message-Id": "<20180525041321.140516-1-venkateshs@google.com>", "X-Mailer": "git-send-email 2.17.0.921.gf22659ad46-goog", "From": "Venkatesh Srinivas <venkateshs@google.com>", "To": "jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, \n\tvsrinivas@ops101.org, venkateshs@google.com", "Subject": "[Intel-wired-lan] [PATCH] igb: Use dma_wmb() instead of wmb()\n\tbefore doorbell writes", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "vsrinivas@ops101.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "igb writes to doorbells to post transmit and receive descriptors;\nafter writing descriptors to memory but before writing to doorbells,\nuse dma_wmb() rather than wmb(). wmb() is more heavyweight than\nnecessary before doorbell writes.\n\nOn x86, this avoids SFENCEs before doorbell writes in both the\ntx and rx refill paths.\n\nSigned-off-by: Venkatesh Srinivas <venkateshs@google.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex cce7ada89255..8aea50867a5d 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -5674,7 +5674,7 @@ static int igb_tx_map(struct igb_ring *tx_ring,\n \t * We also need this memory barrier to make certain all of the\n \t * status bits have been updated before next_to_watch is written.\n \t */\n-\twmb();\n+\tdma_wmb();\n \n \t/* set next_to_watch value indicating a packet is present */\n \tfirst->next_to_watch = tx_desc;\n@@ -8093,7 +8093,7 @@ void igb_alloc_rx_buffers(struct igb_ring *rx_ring, u16 cleaned_count)\n \t\t * applicable for weak-ordered memory model archs,\n \t\t * such as IA-64).\n \t\t */\n-\t\twmb();\n+\t\tdma_wmb();\n \t\twritel(i, rx_ring->tail);\n \t}\n }\n", "prefixes": [] }