Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/918418/?format=api
{ "id": 918418, "url": "http://patchwork.ozlabs.org/api/patches/918418/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180522161846.2844.21726.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180522161846.2844.21726.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2018-05-22T16:18:46", "name": "ixgbevf: fix possible race in the reset subtask", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "557ac64a34e62a83ceb9f3eed02251c2592559ef", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180522161846.2844.21726.stgit@localhost6.localdomain6/mbox/", "series": [ { "id": 45907, "url": "http://patchwork.ozlabs.org/api/series/45907/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=45907", "date": "2018-05-22T16:18:46", "name": "ixgbevf: fix possible race in the reset subtask", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/45907/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/918418/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/918418/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40r0tg3qmQz9s3G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 May 2018 02:08:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DA0EC8799B;\n\tTue, 22 May 2018 16:08:25 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aMds-3oZ2kZP; Tue, 22 May 2018 16:08:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B4BAD876FE;\n\tTue, 22 May 2018 16:08:24 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6DA471C01DA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 May 2018 16:08:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 69F2526B6C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 May 2018 16:08:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 31ewIGBJZlEk for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 May 2018 16:08:22 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3E0AF23F1F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 22 May 2018 16:08:22 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 May 2018 09:08:21 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.100])\n\tby orsmga002.jf.intel.com with ESMTP; 22 May 2018 09:08:21 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,430,1520924400\"; d=\"scan'208\";a=\"60784115\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 22 May 2018 09:18:46 -0700", "Message-ID": "<20180522161846.2844.21726.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbevf: fix possible race in the reset\n\tsubtask", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Extend the RTNL lock in ixgbevf_reset_subtask() to protect the state bits\ncheck in addition to the call to ixgbevf_reinit_locked().\n\nThis is to make sure that we get the most up-to-date values for the bits\nand avoid a possible race when going down.\n\nSuggested-by: Zhiping du <zhipingdu@tencent.com>\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 0830411..1e0c5ae 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -3119,15 +3119,17 @@ static void ixgbevf_reset_subtask(struct ixgbevf_adapter *adapter)\n \tif (!test_and_clear_bit(__IXGBEVF_RESET_REQUESTED, &adapter->state))\n \t\treturn;\n \n+\trtnl_lock();\n \t/* If we're already down or resetting, just bail */\n \tif (test_bit(__IXGBEVF_DOWN, &adapter->state) ||\n \t test_bit(__IXGBEVF_REMOVING, &adapter->state) ||\n-\t test_bit(__IXGBEVF_RESETTING, &adapter->state))\n+\t test_bit(__IXGBEVF_RESETTING, &adapter->state)) {\n+\t\trtnl_unlock();\n \t\treturn;\n+\t}\n \n \tadapter->tx_timeout_count++;\n \n-\trtnl_lock();\n \tixgbevf_reinit_locked(adapter);\n \trtnl_unlock();\n }\n", "prefixes": [] }