Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/916169/?format=api
{ "id": 916169, "url": "http://patchwork.ozlabs.org/api/patches/916169/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180518095840.GA17330@gklab-81-211.igk.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180518095840.GA17330@gklab-81-211.igk.intel.com>", "list_archive_url": null, "date": "2018-05-18T09:58:40", "name": "igb: Wait 10ms just once after TX queues reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "595b9b7380437d2e7663ddd7c354513478811f1c", "submitter": { "id": 74105, "url": "http://patchwork.ozlabs.org/api/people/74105/?format=api", "name": "Nemov, Sergey", "email": "sergey.nemov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180518095840.GA17330@gklab-81-211.igk.intel.com/mbox/", "series": [ { "id": 45185, "url": "http://patchwork.ozlabs.org/api/series/45185/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=45185", "date": "2018-05-18T09:58:40", "name": "igb: Wait 10ms just once after TX queues reset", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/45185/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/916169/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/916169/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40nNt25vTQz9s28\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 18 May 2018 19:58:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B6B058794F;\n\tFri, 18 May 2018 09:58:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1MOFB_wB7XqZ; Fri, 18 May 2018 09:58:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8AA3A86CB7;\n\tFri, 18 May 2018 09:58:46 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1869B1BFB24\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 May 2018 09:58:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1119E2E336\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 May 2018 09:58:45 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tkf39wdnefzZ for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 May 2018 09:58:44 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 2D34B2E32E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 18 May 2018 09:58:42 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 May 2018 02:58:41 -0700", "from gklab-81-211.igk.intel.com ([172.28.178.52])\n\tby fmsmga001.fm.intel.com with ESMTP; 18 May 2018 02:58:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "UNSCANNABLE", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.49,414,1520924400\"; d=\"scan'208,223\";\n\ta=\"56398239\"", "Date": "Fri, 18 May 2018 11:58:40 +0200", "From": "Sergey Nemov <sergey.nemov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Message-ID": "<20180518095840.GA17330@gklab-81-211.igk.intel.com>", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"2oS5YaxWCcQjTEyO\"", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.21 (2010-09-15)", "Subject": "[Intel-wired-lan] [PATCH] igb: Wait 10ms just once after TX queues\n\treset", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Move 10ms sleep out of function resetting TX queue.\nReset all the TX queues in one turn and\nwait for all of them just once.\n\nUse usleep_range() instead of mdelay() in order not to\naffect transmission on other interfaces.\n\nSigned-off-by: Sergey Nemov <sergey.nemov@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 715bb32..db05927 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -3808,11 +3808,6 @@ void igb_configure_tx_ring(struct igb_adapter *adapter,\n \tu64 tdba = ring->dma;\n \tint reg_idx = ring->reg_idx;\n \n-\t/* disable the queue */\n-\twr32(E1000_TXDCTL(reg_idx), 0);\n-\twrfl();\n-\tmdelay(10);\n-\n \twr32(E1000_TDLEN(reg_idx),\n \t ring->count * sizeof(union e1000_adv_tx_desc));\n \twr32(E1000_TDBAL(reg_idx),\n@@ -3843,8 +3838,16 @@ void igb_configure_tx_ring(struct igb_adapter *adapter,\n **/\n static void igb_configure_tx(struct igb_adapter *adapter)\n {\n+\tstruct e1000_hw *hw = &adapter->hw;\n \tint i;\n \n+\t/* disable the queues */\n+\tfor (i = 0; i < adapter->num_tx_queues; i++)\n+\t\twr32(E1000_TXDCTL(adapter->tx_ring[i]->reg_idx), 0);\n+\n+\twrfl();\n+\tusleep_range(10000, 20000);\n+\n \tfor (i = 0; i < adapter->num_tx_queues; i++)\n \t\tigb_configure_tx_ring(adapter, adapter->tx_ring[i]);\n }\n", "prefixes": [] }