Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/915565/?format=api
{ "id": 915565, "url": "http://patchwork.ozlabs.org/api/patches/915565/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180517080840.30192-9-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180517080840.30192-9-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-05-17T08:08:40", "name": "[next,S92,9/9] i40e: use the more traditional 'i' loop variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4826305c0f2215fe9cbffc3ffef1c38fe33d6894", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180517080840.30192-9-alice.michael@intel.com/mbox/", "series": [ { "id": 45017, "url": "http://patchwork.ozlabs.org/api/series/45017/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=45017", "date": "2018-05-17T08:08:34", "name": "[next,S92,1/9] i40e: free skb after clearing lock in ptp_stop", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/45017/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/915565/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/915565/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40mxKy2gZ2z9s4V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 18 May 2018 02:17:58 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 077F32C302;\n\tThu, 17 May 2018 16:17:57 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MGJjMS81S3c2; Thu, 17 May 2018 16:17:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6AFA82D34D;\n\tThu, 17 May 2018 16:17:51 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 131691C2C4E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 May 2018 16:17:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 100FF87B5C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 May 2018 16:17:50 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 02HjB13chqcB for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 May 2018 16:17:49 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id C207988291\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 May 2018 16:17:48 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 May 2018 09:17:48 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga006.jf.intel.com with ESMTP; 17 May 2018 09:17:47 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,411,1520924400\"; d=\"scan'208\";a=\"42632769\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 17 May 2018 01:08:40 -0700", "Message-Id": "<20180517080840.30192-9-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180517080840.30192-1-alice.michael@intel.com>", "References": "<20180517080840.30192-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S92 9/9] i40e: use the more\n\ttraditional 'i' loop variable", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nSince we no longer use i as an array index for the data variable,\nreplace the use of 'j' with 'i' so that we match the general loop\nvariable name.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 56 +++++++++++++-------------\n 1 file changed, 28 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 487a9a4..194cc23 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1606,26 +1606,26 @@ static void i40e_get_ethtool_stats(struct net_device *netdev,\n \tstruct i40e_ring *tx_ring, *rx_ring;\n \tstruct i40e_vsi *vsi = np->vsi;\n \tstruct i40e_pf *pf = vsi->back;\n-\tunsigned int j;\n+\tunsigned int i;\n \tchar *p;\n \tstruct rtnl_link_stats64 *net_stats = i40e_get_vsi_stats_struct(vsi);\n \tunsigned int start;\n \n \ti40e_update_stats(vsi);\n \n-\tfor (j = 0; j < I40E_NETDEV_STATS_LEN; j++) {\n-\t\tp = (char *)net_stats + i40e_gstrings_net_stats[j].stat_offset;\n-\t\t*(data++) = (i40e_gstrings_net_stats[j].sizeof_stat ==\n+\tfor (i = 0; i < I40E_NETDEV_STATS_LEN; i++) {\n+\t\tp = (char *)net_stats + i40e_gstrings_net_stats[i].stat_offset;\n+\t\t*(data++) = (i40e_gstrings_net_stats[i].sizeof_stat ==\n \t\t\tsizeof(u64)) ? *(u64 *)p : *(u32 *)p;\n \t}\n-\tfor (j = 0; j < I40E_MISC_STATS_LEN; j++) {\n-\t\tp = (char *)vsi + i40e_gstrings_misc_stats[j].stat_offset;\n-\t\t*(data++) = (i40e_gstrings_misc_stats[j].sizeof_stat ==\n+\tfor (i = 0; i < I40E_MISC_STATS_LEN; i++) {\n+\t\tp = (char *)vsi + i40e_gstrings_misc_stats[i].stat_offset;\n+\t\t*(data++) = (i40e_gstrings_misc_stats[i].sizeof_stat ==\n \t\t\t sizeof(u64)) ? *(u64 *)p : *(u32 *)p;\n \t}\n \trcu_read_lock();\n-\tfor (j = 0; j < I40E_MAX_NUM_QUEUES(netdev) ; j++) {\n-\t\ttx_ring = READ_ONCE(vsi->tx_rings[j]);\n+\tfor (i = 0; i < I40E_MAX_NUM_QUEUES(netdev) ; i++) {\n+\t\ttx_ring = READ_ONCE(vsi->tx_rings[i]);\n \n \t\tif (!tx_ring) {\n \t\t\t/* Bump the stat counter to skip these stats, and make\n@@ -1663,36 +1663,36 @@ static void i40e_get_ethtool_stats(struct net_device *netdev,\n \t (pf->flags & I40E_FLAG_VEB_STATS_ENABLED)) {\n \t\tstruct i40e_veb *veb = pf->veb[pf->lan_veb];\n \n-\t\tfor (j = 0; j < I40E_VEB_STATS_LEN; j++) {\n+\t\tfor (i = 0; i < I40E_VEB_STATS_LEN; i++) {\n \t\t\tp = (char *)veb;\n-\t\t\tp += i40e_gstrings_veb_stats[j].stat_offset;\n-\t\t\t*(data++) = (i40e_gstrings_veb_stats[j].sizeof_stat ==\n+\t\t\tp += i40e_gstrings_veb_stats[i].stat_offset;\n+\t\t\t*(data++) = (i40e_gstrings_veb_stats[i].sizeof_stat ==\n \t\t\t\t sizeof(u64)) ? *(u64 *)p : *(u32 *)p;\n \t\t}\n-\t\tfor (j = 0; j < I40E_MAX_TRAFFIC_CLASS; j++) {\n-\t\t\t*(data++) = veb->tc_stats.tc_tx_packets[j];\n-\t\t\t*(data++) = veb->tc_stats.tc_tx_bytes[j];\n-\t\t\t*(data++) = veb->tc_stats.tc_rx_packets[j];\n-\t\t\t*(data++) = veb->tc_stats.tc_rx_bytes[j];\n+\t\tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n+\t\t\t*(data++) = veb->tc_stats.tc_tx_packets[i];\n+\t\t\t*(data++) = veb->tc_stats.tc_tx_bytes[i];\n+\t\t\t*(data++) = veb->tc_stats.tc_rx_packets[i];\n+\t\t\t*(data++) = veb->tc_stats.tc_rx_bytes[i];\n \t\t}\n \t} else {\n \t\tdata += I40E_VEB_STATS_TOTAL;\n \t}\n-\tfor (j = 0; j < I40E_GLOBAL_STATS_LEN; j++) {\n-\t\tp = (char *)pf + i40e_gstrings_stats[j].stat_offset;\n-\t\t*(data++) = (i40e_gstrings_stats[j].sizeof_stat ==\n+\tfor (i = 0; i < I40E_GLOBAL_STATS_LEN; i++) {\n+\t\tp = (char *)pf + i40e_gstrings_stats[i].stat_offset;\n+\t\t*(data++) = (i40e_gstrings_stats[i].sizeof_stat ==\n \t\t\t sizeof(u64)) ? *(u64 *)p : *(u32 *)p;\n \t}\n-\tfor (j = 0; j < I40E_MAX_USER_PRIORITY; j++) {\n-\t\t*(data++) = pf->stats.priority_xon_tx[j];\n-\t\t*(data++) = pf->stats.priority_xoff_tx[j];\n+\tfor (i = 0; i < I40E_MAX_USER_PRIORITY; i++) {\n+\t\t*(data++) = pf->stats.priority_xon_tx[i];\n+\t\t*(data++) = pf->stats.priority_xoff_tx[i];\n \t}\n-\tfor (j = 0; j < I40E_MAX_USER_PRIORITY; j++) {\n-\t\t*(data++) = pf->stats.priority_xon_rx[j];\n-\t\t*(data++) = pf->stats.priority_xoff_rx[j];\n+\tfor (i = 0; i < I40E_MAX_USER_PRIORITY; i++) {\n+\t\t*(data++) = pf->stats.priority_xon_rx[i];\n+\t\t*(data++) = pf->stats.priority_xoff_rx[i];\n \t}\n-\tfor (j = 0; j < I40E_MAX_USER_PRIORITY; j++)\n-\t\t*(data++) = pf->stats.priority_xon_2_xoff[j];\n+\tfor (i = 0; i < I40E_MAX_USER_PRIORITY; i++)\n+\t\t*(data++) = pf->stats.priority_xon_2_xoff[i];\n }\n \n /**\n", "prefixes": [ "next", "S92", "9/9" ] }