Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/915562/?format=api
{ "id": 915562, "url": "http://patchwork.ozlabs.org/api/patches/915562/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180517080840.30192-8-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180517080840.30192-8-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-05-17T08:08:39", "name": "[next,S92,8/9] i40e: add function doc headers for ethtool stats functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b8423ce3286ce005bf4d14c95592cfc0f42a59d7", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180517080840.30192-8-alice.michael@intel.com/mbox/", "series": [ { "id": 45017, "url": "http://patchwork.ozlabs.org/api/series/45017/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=45017", "date": "2018-05-17T08:08:34", "name": "[next,S92,1/9] i40e: free skb after clearing lock in ptp_stop", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/45017/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/915562/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/915562/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 40mxKv0GBTz9s4Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 18 May 2018 02:17:54 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E036C882C4;\n\tThu, 17 May 2018 16:17:52 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id H5jb3U3ENoHh; Thu, 17 May 2018 16:17:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7F482882A7;\n\tThu, 17 May 2018 16:17:50 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6991F1C3F00\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 May 2018 16:17:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 66A7D896B3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 May 2018 16:17:49 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 49qK2xXev8tD for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 May 2018 16:17:48 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id BB7B289656\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 17 May 2018 16:17:48 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 May 2018 09:17:48 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga006.jf.intel.com with ESMTP; 17 May 2018 09:17:47 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,411,1520924400\"; d=\"scan'208\";a=\"42632767\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 17 May 2018 01:08:39 -0700", "Message-Id": "<20180517080840.30192-8-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180517080840.30192-1-alice.michael@intel.com>", "References": "<20180517080840.30192-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S92 8/9] i40e: add function doc\n\theaders for ethtool stats functions", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nAdd documentation for the i40e_get_stats_count, i40e_get_stat_strings\nand i40e_get_ethtool_stats explaining that the number and ordering of\nstatistics must remain constant for a given netdevice.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 38 ++++++++++++++++++++++++++\n 1 file changed, 38 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 94e1995..487a9a4 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1540,6 +1540,20 @@ static int i40e_set_ringparam(struct net_device *netdev,\n \treturn err;\n }\n \n+/**\n+ * i40e_get_stats_count - return the stats count for a device\n+ * @netdev: the netdev to return the count for\n+ *\n+ * Returns the total number of statistics for this netdev. Note that even\n+ * though this is a function, it is required that the count for a specific\n+ * netdev must never change. Basing the count on static values such as the\n+ * maximum number of queues or the device type is ok. However, the API for\n+ * obtaining stats is *not* safe against changes based on non-static\n+ * values such as the *current* number of queues, or runtime flags.\n+ *\n+ * If a statistic is not always enabled, return it as part of the count\n+ * anyways, always return its string, and report its value as zero.\n+ **/\n static int i40e_get_stats_count(struct net_device *netdev)\n {\n \tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n@@ -1571,6 +1585,20 @@ static int i40e_get_sset_count(struct net_device *netdev, int sset)\n \t}\n }\n \n+/**\n+ * i40e_get_ethtool_stats - copy stat values into supplied buffer\n+ * @netdev: the netdev to collect stats for\n+ * @stats: ethtool stats command structure\n+ * @data: ethtool supplied buffer\n+ *\n+ * Copy the stats values for this netdev into the buffer. Expects data to be\n+ * pre-allocated to the size returned by i40e_get_stats_count.. Note that all\n+ * statistics must be copied in a static order, and the count must not change\n+ * for a given netdev. See i40e_get_stats_count for more details.\n+ *\n+ * If a statistic is not currently valid (such as a disabled queue), this\n+ * function reports its value as zero.\n+ **/\n static void i40e_get_ethtool_stats(struct net_device *netdev,\n \t\t\t\t struct ethtool_stats *stats, u64 *data)\n {\n@@ -1667,6 +1695,16 @@ static void i40e_get_ethtool_stats(struct net_device *netdev,\n \t\t*(data++) = pf->stats.priority_xon_2_xoff[j];\n }\n \n+/**\n+ * i40e_get_stat_strings - copy stat strings into supplied buffer\n+ * @netdev: the netdev to collect strings for\n+ * @data: supplied buffer to copy strings into\n+ *\n+ * Copy the strings related to stats for this netdev. Expects data to be\n+ * pre-allocated with the size reported by i40e_get_stats_count. Note that the\n+ * strings must be copied in a static order and the total count must not\n+ * change for a given netdev. See i40e_get_stats_count for more details.\n+ **/\n static void i40e_get_stat_strings(struct net_device *netdev, u8 *data)\n {\n \tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n", "prefixes": [ "next", "S92", "8/9" ] }